From: Andrew Lunn <andrew@lunn.ch>
To: Cindy Lu <lulu@redhat.com>
Cc: dtatulea@nvidia.com, mst@redhat.com, jasowang@redhat.com,
parav@nvidia.com, sgarzare@redhat.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATH v5 0/3] vdpa: support set mac address from vdpa tool
Date: Tue, 23 Jul 2024 20:45:13 +0200 [thread overview]
Message-ID: <66239ba4-d837-48da-aaba-528c6ab05ce9@lunn.ch> (raw)
In-Reply-To: <20240723054047.1059994-1-lulu@redhat.com>
On Tue, Jul 23, 2024 at 01:39:19PM +0800, Cindy Lu wrote:
> Add support for setting the MAC address using the VDPA tool.
> This feature will allow setting the MAC address using the VDPA tool.
> For example, in vdpa_sim_net, the implementation sets the MAC address
> to the config space. However, for other drivers, they can implement their
> own function, not limited to the config space.
>
> Changelog v2
> - Changed the function name to prevent misunderstanding
> - Added check for blk device
> - Addressed the comments
> Changelog v3
> - Split the function of the net device from vdpa_nl_cmd_dev_attr_set_doit
> - Add a lock for the network device's dev_set_attr operation
> - Address the comments
> Changelog v4
> - Address the comments
> - Add a lock for the vdap_sim?_net device's dev_set_attr operation
> Changelog v5
> - Address the comments
This history is to help reviewers of previous versions know if there
comments have been addressed. Just saying 'Address the comments' is
not useful. Please give a one line summary of each of the comment
which has been addressed, maybe including how it was addressed.
Andrew
next prev parent reply other threads:[~2024-07-23 18:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 5:39 Cindy Lu
2024-07-23 5:39 ` [PATH v5 1/3] " Cindy Lu
2024-07-23 6:01 ` Jason Wang
2024-07-23 6:16 ` Cindy Lu
2024-07-23 18:48 ` Andrew Lunn
2024-07-24 2:12 ` Cindy Lu
2024-07-23 5:39 ` [PATH v5 2/3] vdpa_sim_net: Add the support of set mac address Cindy Lu
2024-07-23 6:01 ` Jason Wang
2024-07-23 18:51 ` Andrew Lunn
2024-07-23 5:39 ` [PATH v5 3/3] vdpa/mlx5: " Cindy Lu
2024-07-23 6:02 ` Jason Wang
2024-07-23 7:49 ` Dragos Tatulea
2024-07-23 11:29 ` Michael S. Tsirkin
2024-07-24 2:12 ` Cindy Lu
2024-07-23 18:45 ` Andrew Lunn [this message]
2024-07-24 2:12 ` [PATH v5 0/3] vdpa: support set mac address from vdpa tool Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66239ba4-d837-48da-aaba-528c6ab05ce9@lunn.ch \
--to=andrew@lunn.ch \
--cc=dtatulea@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®