From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751493AbdANSAR (ORCPT ); Sat, 14 Jan 2017 13:00:17 -0500 Received: from vern.gendns.com ([206.190.152.46]:36017 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdANSAP (ORCPT ); Sat, 14 Jan 2017 13:00:15 -0500 Subject: Re: [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips To: Jonathan Cameron , devicetree@vger.kernel.org, linux-iio@vger.kernel.org References: <1484157171-15571-1-git-send-email-david@lechnology.com> <1484157171-15571-2-git-send-email-david@lechnology.com> Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org From: David Lechner Message-ID: <662a48e1-39fc-4fb7-a3b9-b671d2e40029@lechnology.com> Date: Sat, 14 Jan 2017 12:00:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2017 06:53 AM, Jonathan Cameron wrote: > On 11/01/17 17:52, David Lechner wrote: >> This adds device tree bindings for the TI ADS7950 family of A/DC chips. >> >> Signed-off-by: David Lechner > This is in of itself good, but we may need to have some deprecated > elements to continue supporting what was implicitly happening with > the missnaming so as to avoid accidentally breaking someone's device > tree. > As I mentioned in my cover letter, this driver, as far as I can tell, only exists in your testing branch, so I find it highly unlikely that we would be breaking anyone. It is not in mainline and it is not even in linux-next. > Jonathan >> --- >> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> new file mode 100644 >> index 0000000..e77a6f7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> @@ -0,0 +1,23 @@ >> +* Texas Instruments ADS7950 family of A/DC chips >> + >> +Required properties: >> + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", >> + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", >> + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" >> + - reg: SPI chip select number for the device >> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt >> + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V >> + reference voltage >> + >> +Recommended properties: >> + - spi-max-frequency: Definition as per >> + Documentation/devicetree/bindings/spi/spi-bus.txt >> + >> +Example: >> +adc@0 { >> + compatible = "ti,ads7957"; >> + reg = <0>; >> + #io-channel-cells = <1>; >> + vref-supply = <&refin_supply>; >> + spi-max-frequency = <10000000>; >> +}; >> >