From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891E12076C6 for ; Wed, 16 Oct 2024 13:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729085671; cv=none; b=YOZ9ybSgOA1LDOYWLzqQG1jyV1VNWceLmZqIjJ419e+7Lncw3FFGwUgDeMQU5aOFrkgF3nR9zSwtzPHxwjGZDhKIvN7hfuwqNQeaP1mEY9Q1pKMA9nZ7GLDI1ih2HdxdPmZDibBxVxxk2vpMvSTs/Zz/Fadkj39vzDdpGRyf3nA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729085671; c=relaxed/simple; bh=4TDceqBwB5/CSA70st1bX9f2C9Pa3VHqCT+1UuQ4cko=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=eKVZTs9LgfRcHZpeQ1hUd2OOibMVBYN2APXDuYO+mvfOPQ5xKbtGiBZQ7uQnrFcv0i1Ilj1aPgJUVBld+tNutcQkQRdJ2RLqoaeu7XsfSaSybuBTGe8OyrfOEZ0nHIywBM8glm4rNTkpBxxsotsRApEwjuTrt6JlFI9xUHvRF/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=aOIvnR6R; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="aOIvnR6R" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6cbd1ae26a6so47074866d6.1 for ; Wed, 16 Oct 2024 06:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1729085668; x=1729690468; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=60BUvf9HqnbeuKt+3QuiFsp8g1MCOzdKxeoyAqr2mHQ=; b=aOIvnR6RnBFlhG54TZOCTmd5zWkDcsruHzmDFHxA/cHayDDY9vjoJ+Ewz0GbdWWCwi 81jLcH/yfB1DIYvgiUAfMKEYjC2mfSHI3McJM99AoG0TkKG8b/lM/dhgRyy4+kSSwImD euejiFlFL7apjXevpIw5bta55dtfzb99nu5V9bD+/xTyKAg7vHJieJTzZJzKat82CEE1 rfIJuGNInlTq18Cheu3aco4thaN+pZMKd0KQ0LVPpEYBe4cEPDQiL2x6eoWIqn8g0olS yoBImiRP/l/lkhT0h768uMII0Y47JCzM6Ddhpoc4GyenI6Uk7DYQ8psiyknVkxEput/9 H3mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729085668; x=1729690468; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=60BUvf9HqnbeuKt+3QuiFsp8g1MCOzdKxeoyAqr2mHQ=; b=Ft7cloI7HJniDEMxtr0qRrckq53JQVcaHpG0xytPFc67sqo1dZD2qoY+r02aaOEryM KBfk5eS3vDdxCZXOhCpKJuAGCZFYra5CkgGzkyv1nfxYbhNOI/onPw6gh9qLKlqJOQpm UvkEKT+z/Rf2Y04uaRofd/GDpay9S/57A8v8PQHaGlhqr4GQrrIiimBGZil4LaF2rAWa 9rCxJJorZFiI6tcJvByFRx1wIopuKomYt0QGsLKeK1XyzeURkH1dBB128fskSdq3Yvap cgwaBFIUXHw1GxOvoEZ7xufcfqXXz8GOvR/8bFlAQYilFgmoN6Z4VB7i45t+Ld42MaY+ ryeQ== X-Forwarded-Encrypted: i=1; AJvYcCWzJ/FTKYwLvVFB+2A5+vVDGiheL1/arbTQ/6VvOG6MbwuMGzmpfxQhJS8ve9EO0cpzQ2VKQjKFPEE1s6A=@vger.kernel.org X-Gm-Message-State: AOJu0YxPctNCJeNwM6Ijq6A8lFA2lFwepBFA6JzTW3lDvfV9JDHBzYFJ 38D871PDYq6/es4pV+5jFkYVKHhEwL+dFrdqNEFft4nsMQ/zxW9Mw42iCDq8DIzkPU4/a0T+hHQ 3SEY= X-Google-Smtp-Source: AGHT+IGkt9nV2zFDYZc7p68pW9RiNJVGEAerCIXZvjfqozTAP2VCLEad5feNiIsFKsPyFiMd9pqK4g== X-Received: by 2002:a05:6214:4987:b0:6cb:e6fa:495d with SMTP id 6a1803df08f44-6cc2b8d371dmr52417516d6.21.1729085668158; Wed, 16 Oct 2024 06:34:28 -0700 (PDT) Received: from [192.168.0.189] (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cc22961be9sm17901106d6.114.2024.10.16.06.34.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2024 06:34:27 -0700 (PDT) Subject: Re: [PATCH v3 4/5] arm64: dts: qcom: x1e80100-crd: add rtc offset to set rtc time To: Johan Hovold Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20241015004945.3676-1-jonathan@marek.ca> <20241015004945.3676-5-jonathan@marek.ca> From: Jonathan Marek Message-ID: <663cf3f6-3254-e490-d557-a12aa41a1628@marek.ca> Date: Wed, 16 Oct 2024 09:31:00 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/16/24 2:51 AM, Johan Hovold wrote: > On Mon, Oct 14, 2024 at 08:47:29PM -0400, Jonathan Marek wrote: >> See commit e67b45582c5e for explanation. > > It's good that you reference commit e67b45582c5e ("arm64: dts: qcom: > sc8280xp-crd: enable rtc") but your commit message still needs to be > self-contained and provide the explanation here in some form (e.g. > quoted or paraphrased). > > Also spell out the commit summary in parenthesis when referring to > commits as I did above. > >> Note: the 0xbc offset is arbitrary, it just needs to not be already in use. > > How did you verify that nothing is using this offset on this platform? I > assume we need someone with access to the docs to make sure it's not in > use as we did for sc8280xp. > AFAIK qcom allocate things from the start of the SDAM, so allocating from the end of the SDAM should be safe. And AFAIK this is supposed to be a general purpose HLOS (linux/windows) SDAM block, so should be mostly free to use. (its possible windows uses this offset for something, I don't know about that)