From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1312BEC57 for ; Wed, 28 Jan 2026 10:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769596204; cv=none; b=J7KfKzlg9iDHZidZsI21rhw3OO6nEcL64yg2bpxhv81/E0y7pzo3n7ON4U7Qznt5JdKu5bgwixoXmzaKjrIR98gnmBYkK/DJWO4Kx0oK8Q6zSHY67dSJgiHGzsuzaiiDyNkBz/B+YmiTECvejpi2Nwa0pmSA2DhCRgJQWmIHq10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769596204; c=relaxed/simple; bh=Ku1dicgL2xpotWHSMBu9pXBNXEFotq5+e2fMmlKlf28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=USE16ahe9LC876pi89cM/rVoU1FvMaQsbdSaKQzMwof9cFGdYzeG9xt1uVhquZOfupTtDJaI0wdVng6gvhqArJCtXNE+Bj8P1i/ZM7alcyJqEYUUDp3PoVd9vdJkIMVUGDK5RDHwbitrwZtp4bX7+rPfvOPLhkbpBuCz7fRLHBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SMmpt+tY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PY+joWuW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SMmpt+tY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PY+joWuW" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S9286b3921050 for ; Wed, 28 Jan 2026 10:30:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9sNgo83WOwXJW4+gUjlHILnrYJlHZyRwyZOx9BXqRn0=; b=SMmpt+tYOCKtv4we /AQhuxAhvoEhkenJJDs/NZq5yVLfo0S93hZLuSIP5/H5RgdO6RvQ0Q2O2BifWC3N zH/ihOn9/h8ZgeJFLEHsk6Dl0Z20/SuPiHK9laKXFXcUkNTU9p/BQz3jiYdxTrks RRIzF0g1reJ9Wp3UBd94OULESQmSsgYkwweoA9n7ZocClClk3Sep7xcJZUW1fSTf bf0tkkD1AfAOPYdfkRmJxbT18UXOdbbq9Nr4xcV5FC7gjkilC544n59tnimIxjkk j7+V26ppl3N3VPZyUc5bhWLd4p3WOOu+LpoxA8s/spCpM/2t77mwnhgvicqdhP+h jEQ6jA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by211axet-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 10:30:01 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c710279d57so47353585a.3 for ; Wed, 28 Jan 2026 02:30:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769596201; x=1770201001; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9sNgo83WOwXJW4+gUjlHILnrYJlHZyRwyZOx9BXqRn0=; b=PY+joWuWCnzbwfVCekhjwfHhPdFxd+Pw7FbsQYp18k3S7MGjwduBMVPZ63Ch78SKGf rZxzNNb0AOe9qqxQ9H0cjX6820BQmk/4phcGRdstch+a+1FvdfSVdEQp6i3dWW9CuzgI QWIoDKH4KpyBRZi9AboGjAsMqJzyKzUVe9uCAEhLJ/uNK5SfeeEVyOX43XAfKO1FwdJY RwppJ/xLjgFNXiKzHYj/aKd+VCS7dnAG2FRW16Ra86Kyef/lvdChHKKVevM/72OJdg5Z T7eQhEXAmt9cIMjXqe5Kf3CPOhbaIphId4v6zMe6/Wb1kN7v58r3w6Hax341/pgq5MdO WDwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769596201; x=1770201001; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9sNgo83WOwXJW4+gUjlHILnrYJlHZyRwyZOx9BXqRn0=; b=pJ0ZRZ3O2TiptZWJfmXCs1uXeeIC1nAmfl0vgAP31WZipIXvkx6Gw+oA2UbxgfM2nM vmdcw7qVy9DQo+4Z6LBK4o1SwJCp9QB+xvUK3SntWj9hrz/kJnAgSGntV9W4UYcPrIAb 651HJseFus8EAxe+8idS/81YB19H5DK1hrCtCZ3+OO7CEauwfCAKwL//Zq8jBz/7zJb/ Qb71UyTB3iwhlqmO7VJN8KLHGMAr98N3I7s92HAfnmA79treKLB3cLz+AHqOwv2U4QJA ydZ4zZ12cPKvjcVUqj32BH+HT92E4+TyDCGYyo5Ly8qG0DcPDCSlJKio2i9PxQsmaFBw a83A== X-Forwarded-Encrypted: i=1; AJvYcCUZUKfDz32vrY100XcNdhZ4e3oJPO2H4/Un66VPDfM51YfAN6NdQg4361mBQZvomXse8zWBJHRlOkyBfUE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4/LPvy1cXuVCyz4UWJGGJaYP4CmzH8zqVNLEDmqZKneMxODix PaOeWGsvJbHw7EKEfCEXnS9F8W4akTZZsUVBxMNSpB2ZdSEJcKEuonRxB0wnhY5s/RIyFCC2jgj 0Z04plIK5ZjnYwIijTECMme7dO+m2iqv0+8Ov+rW+vQNcT7HaMupSJaOko+GxCPybBgo= X-Gm-Gg: AZuq6aIIxsdS6+Sa8gaAW8VB8byP3FPO1ELD53SUkC4i02L1VnFRlnn8gGVa0b0RH/F RgwqhWlF+o+8OUSJcFX0iDdvI9SQd/GrcypJDE5l9CWM5nzd8kz9ghtDKd5OAjKpnNvyKIP7rO/ 53C7Wwq+UWQA1iyDfb1uqMCUp7Hq67hNUh5yBb8xLMS7OgamWRoBtQClLJPQlSB6EOGkixELqBK +7wc0frlZkydRWGQNHzL7OeofopVCh6KJdjmK/WnsAoA0W5usJ4ht8mFIkVvagmF1wrKfzFI1s/ WXNQwIptRvF2zgl44cS3pFMy+ZonbPH1UE3/8TsTqVha5fUB17BApWkIt0/53JwWPKbWftT9uFf zt22PyPIgPiZ8vNcM8WWhi9N4jEUJuN1oqcBGbYnutJFhuJe1dFhbwOcsXiXg7MIeP7M= X-Received: by 2002:a05:620a:4723:b0:89f:5a1b:1ec9 with SMTP id af79cd13be357-8c714b4467emr120128285a.1.1769596200634; Wed, 28 Jan 2026 02:30:00 -0800 (PST) X-Received: by 2002:a05:620a:4723:b0:89f:5a1b:1ec9 with SMTP id af79cd13be357-8c714b4467emr120126785a.1.1769596200133; Wed, 28 Jan 2026 02:30:00 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c0213sm109996666b.48.2026.01.28.02.29.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 02:29:59 -0800 (PST) Message-ID: <663cfee5-ea40-4990-9391-3b12d9279cea@oss.qualcomm.com> Date: Wed, 28 Jan 2026 11:29:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] regulator: qcom-rpmh: Add support for regulator-off-on-delay-us To: Saikiran , broonie@kernel.org, lgirdwood@gmail.com Cc: andersson@kernel.org, konrad.dybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127173736.82976-1-bjsaikiran@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260127173736.82976-1-bjsaikiran@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA4NSBTYWx0ZWRfX1fpr9gRVmfaP OWbuMJecjXpxDNua02/cpsWvjiXATdacl3IAGkEXUD1PDNDpZTkWjmiX9Ii5kOjBx1P4xnhnpXI hvQG84haiT6Ydsd2goQssJ0Kmj+rQISV2DtLdCq00QsXGHp0lcSPjWc8YEoZFTnJgmxe1FN4Ghz eM1kCINEswfcI9x+H1GoDS7qGoGSMkOLk6JLjQrXRr2qO2rfDnxnTfSyC0dIS9coQ7X0KMXmW18 galM95NYl1ifqB4ppd5wGo2T1Qf1qmh8i7YDaachmPaWvrLrYwSbgj9geywKVYb6hIwpS/MHXUg 7tvdy/1nHhtqEqtxeKg/z5c0Ysoqd+8KgAD58HUuFt8dJ5w6OFpi2DF5iy6Sn4lm09q1wQwfLFR EBbk7ebj7u6FYkmBJ6dspZ+JxqL4oumKUPsXeP+oGBb4JuRHb2g5cfEFV/wV5G4Cc0yyDsojSlI HeyS03IeoJhh4azCFDQ== X-Authority-Analysis: v=2.4 cv=GuxPO01C c=1 sm=1 tr=0 ts=6979e529 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=rk3K33iGrHrTizFJfSAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: mdQ5HZA4wW4ru3QrW55NUo6OHw60Lvr9 X-Proofpoint-ORIG-GUID: mdQ5HZA4wW4ru3QrW55NUo6OHw60Lvr9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280085 On 1/27/26 6:37 PM, Saikiran wrote: > The core regulator framework supports enforcing a physical off-time via > standard properties, but the `qcom-rpmh-regulator` driver currently ignores > them. This prevents boards with slow-discharging rails from enforcing safe > power-cycling constraints. > > On the Lenovo Yoga Slim 7x (Snapdragon X Elite), certain camera regulators > rely on passive discharge and require a significant off-time to drop below > brownout thresholds. Without this driver support, we cannot enforce this > constraint via Device Tree, leading to sensor initialization failures during > rapid power cycling. > > Add support for parsing the `regulator-off-on-delay-us` property from > the device tree. > > I have tested this on the Yoga Slim 7x. When the delay property is present > in the device tree, the regulator core correctly blocks re-enable calls > until the delay passes, fixing the camera brownout issues. > > Signed-off-by: Saikiran > --- > drivers/regulator/qcom-rpmh-regulator.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c > index 6e4cb2871fca..aafba61551b3 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -503,6 +503,9 @@ static int rpmh_regulator_init_vreg(struct rpmh_vreg *vreg, struct device *dev, > vreg->always_wait_for_ack = of_property_read_bool(node, > "qcom,always-wait-for-ack"); > > + of_property_read_u32(node, "regulator-off-on-delay-us", > + &vreg->rdesc.off_on_delay); Would it not be a better fit for of_regulator.c? Konrad