From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757214AbbCMTvh (ORCPT ); Fri, 13 Mar 2015 15:51:37 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:62530 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754728AbbCMTvg (ORCPT ); Fri, 13 Mar 2015 15:51:36 -0400 From: Arnd Bergmann To: Alexandre Belloni Cc: linux-arm-kernel@lists.infradead.org, Nicolas Ferre , linux-kernel@vger.kernel.org, Brian Norris , Jean-Christophe Plagniol-Villard , Andrew Victor Subject: Re: [PATCH] ARM: at91: force CPU selection Date: Fri, 13 Mar 2015 20:50:59 +0100 Message-ID: <6645156.Abd4ZAJv10@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150313183200.GK4329@piout.net> References: <1425970798-14015-1-git-send-email-computersforpeace@gmail.com> <2279482.Ohk2PcyWHV@wuerfel> <20150313183200.GK4329@piout.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:/53qMSMGqV9UK8wE9Z+S0RNnX77GpRtNX3ArR82rz2EHSiwQz5S ufkspCzwqaxs34EFypAfUcmJkGgUb5ISnFPzB3BvY4jNjeSBWdp/bde7ZWCTWgmglHZaK0o rGfsdunemxc8GKY80IaZFBKNy29AaxRgTwK+RLFoTGupufEEgb24XlwwRun1hRxthiOwRR8 CnaT+NBU18WrHL+ByE3/g== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 13 March 2015 19:32:00 Alexandre Belloni wrote: > On 10/03/2015 at 14:42:24 +0100, Arnd Bergmann wrote : > > On Tuesday 10 March 2015 10:42:09 Alexandre Belloni wrote: > > > > > > > > I actually added a bunch of these in other places, but have stopped > > > > doing so because Russell didn't like them, and I tend to follow > > > > his argument now that it's actually pretty confusing. > > > > > > > > In case of at91, we can do better now, once we have multiplatform > > > > enabled, and we can simply remove the SOC_SAM_V7 and SOC_SAM_V4_V5 > > > > symbols entirely (if Alexandre's patch doesn't already do that). > > > > > > > > > > I didn't remove it to keep the sub menus SOC_SAM_V7 -> SOC_SAMA5D4 and > > > SOC_SAMA5D3, SOC_SAM_V4_V5 -> SOC_AT91SAM9 and SOC_AT91RM9200. But I can > > > also expose SOC_AT91RM9200, SOC_AT91SAM9, SOC_SAMA5D3 and SOC_SAMA5D4 > > > instead of SOC_SAM_V7 and SOC_SAM_V4_V5 and remove them. > > > > Exposing multiple levels won't help here since you can never enable > > both v4/v5 and v7 at the same time in multiplatform. > > > > Just use one level for a 'menuconfig ARCH_AT91' entry and put the > > four options below that. > > > > Actually, I had a closer look today and there is already just one level > in my current version of patches. > > I can put everything under menuconfig ARCH_AT91 but I can't remove > SOC_SAM_V7 and SOC_SAM_V4_V5 because that is what is used to select > which dtb should be compiled. > > This would also break sama5_defconfig. This is a simple fix but that > means that it makes it difficult to migrate an existing .config. > > I'd say let's keep it that way as this is not broken, unless you really > want to see SOC_SAM_V7 and SOC_SAM_V4_V5 being removed. > I'm not sure what the latest version looks like, but I think it's fine to have SOC_SAM_V4_V5 automatically selected when CONFIG_AT91 and CONFIG_MULTI_V4 || CONFIG_MULTI_V5 are turned on, or selected by AT91SAM9 and AT91RM9200. Arnd