From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 968B014374E for ; Mon, 1 Jul 2024 14:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.249 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719842511; cv=none; b=njlf7BahheyxdswfzPaJmkTNQqVZImiuKz1tRI6JE2lf7J7tVaRjEVpDQ45ANI6lY6qfMdODOQIiA+fr8CjDabxMEPEzd3ehvI/kxIf5tOFO86QFrrMBhU0xbZC72oO2m6ZxA03Z/RRg5OeMEiy1Db4wJu5Hc6aU03MZ1fDceGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719842511; c=relaxed/simple; bh=3reg4i/O4YiAE5aKRVANGYOBm/8AOHKu8/Lh8yOWM1w=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=gQMbiNbTJzpm+lR4mjWhQQTosLicue/v+nHih+PsAgYZJtYeZsmovXOTjp/3DomJO34IGysg2pmdth3rh9RTiZ8XdIBMbZWD0d964kb1SYunVugOJEeQ7Yj+qODHgVBUZD1qEnhiqraLX20NLCGX1en/MXT10XW0JofpPwbIH7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=r+sBtxYi; arc=none smtp.client-ip=198.47.23.249 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="r+sBtxYi" Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 461E0EUt074153; Mon, 1 Jul 2024 09:00:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1719842414; bh=jjxKQjXPGDBo7KD1g9SLb7Db/+v0i0QFj/MuvZQRvGE=; h=From:To:CC:Subject:Date:References:In-Reply-To; b=r+sBtxYiyUPBmKIZZ+6Li8yXVLl8t//deqhOz+TkK1RE0sVS9TD9AEtgfU1DTkwy5 g4hJ5tWBXY3HHX2Mq59rXbviXtUpxwne2CBnsjsi3deohEZ5Luq27mtf7wWxWbw0PC Yrc8Drq7UJboRayPxaXqR0D/54nuCIt8GT/e1doU= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 461E0ETD003409 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 1 Jul 2024 09:00:14 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 1 Jul 2024 09:00:13 -0500 Received: from DLEE101.ent.ti.com ([fe80::91ee:60bc:bfb7:851c]) by DLEE101.ent.ti.com ([fe80::91ee:60bc:bfb7:851c%18]) with mapi id 15.01.2507.023; Mon, 1 Jul 2024 09:00:13 -0500 From: "Ding, Shenghao" To: Mark Brown CC: "andriy.shevchenko@linux.intel.com" , "lgirdwood@gmail.com" , "perex@perex.cz" , "pierre-louis.bossart@linux.intel.com" , "13916275206@139.com" <13916275206@139.com>, "zhourui@huaqin.com" , "alsa-devel@alsa-project.org" , "Salazar, Ivan" , "linux-kernel@vger.kernel.org" , "Chadha, Jasjot Singh" , "liam.r.girdwood@intel.com" , "Yue, Jaden" , "yung-chuan.liao@linux.intel.com" , "Rao, Dipa" , "yuhsuan@google.com" , "Lo, Henry" , "tiwai@suse.de" , "Xu, Baojun" , "soyer@irl.hu" , "Baojun.Xu@fpt.com" , "judyhsiao@google.com" , "Navada Kanyana, Mukund" , "cujomalainey@google.com" , "Kutty, Aanya" , "Mahmud, Nayeem" , "savyasanchi.shukla@netradyne.com" , "flaviopr@microsoft.com" , "Ji, Jesse" , "darren.ye@mediatek.com" Subject: RE: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files Thread-Topic: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files Thread-Index: AQHaygy3zqcBdt6oi0KleesuzWGEKLHiIqwA///EuhA= Date: Mon, 1 Jul 2024 14:00:13 +0000 Message-ID: <664b818a177f4403bd60c3d4cd0bf4d1@ti.com> References: <20240629101112.628-1-shenghao-ding@ti.com> <8245d8e7-3ff0-4f05-9f99-666e9693603f@sirena.org.uk> In-Reply-To: <8245d8e7-3ff0-4f05-9f99-666e9693603f@sirena.org.uk> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-exclaimer-md-config: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Brown Thanks for your comment. > -----Original Message----- > From: Mark Brown > Sent: Monday, July 1, 2024 8:23 PM > To: Ding, Shenghao > Cc: andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com; > perex@perex.cz; pierre-louis.bossart@linux.intel.com; > 13916275206@139.com; zhourui@huaqin.com; alsa-devel@alsa-project.org; > Salazar, Ivan ; linux-kernel@vger.kernel.org; Chadha, > Jasjot Singh ; liam.r.girdwood@intel.com; Yue, Jaden > ; yung-chuan.liao@linux.intel.com; Rao, Dipa > ; yuhsuan@google.com; Lo, Henry ; > tiwai@suse.de; Xu, Baojun ; soyer@irl.hu; > Baojun.Xu@fpt.com; judyhsiao@google.com; Navada Kanyana, Mukund > ; cujomalainey@google.com; Kutty, Aanya > ; Mahmud, Nayeem ; > savyasanchi.shukla@netradyne.com; flaviopr@microsoft.com; Ji, Jesse > ; darren.ye@mediatek.com > Subject: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the > prefix name of DSP firmwares and calibrated data files >=20 > On Sat, Jun 29, 2024 at 06:11:10PM +0800, Shenghao Ding wrote: >=20 > > tas_priv->fw_state =3D TASDEVICE_RCA_FW_OK; > > - scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin", > > - tas_priv->dev_name); > > + if (tas_priv->name_prefix) > > + scnprintf(tas_priv->rca_binaryname, 64, "%s-%s_coef.bin", > > + tas_priv->name_prefix, tas_priv->dev_name); > > + else > > + scnprintf(tas_priv->coef_binaryname, 64, "%s_coef.bin", > > + tas_priv->dev_name); >=20 > I'll apply this but I do wonder if it's worth falling back to trying to l= oad the > unprefixed name if we fail to load the prefixed one. If fail to load dsp firmware, the driver won't load unprefixed name firmwar= e,=20 but switch tas2563/tas2781 to bypass-dsp mode automatically. In this mode, smartamp become simple amp. These day, I met a case from one of my customers, they put 2 pieces of tas2= 563,=20 and 2 pieces of tas2781 in the same i2c bus. In order to identify tas2563 a= nd=20 tas2781, I think name_prefix is a good solution for this case. Looking forward to your comment. Thanks.