From: "Christian König" <christian.koenig@amd.com>
To: Arnd Bergmann <arnd@arndb.de>,
Oded Gabbay <oded.gabbay@gmail.com>,
Alex Deucher <alexander.deucher@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
David Airlie <airlied@linux.ie>
Cc: Felix Kuehling <Felix.Kuehling@amd.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] amdkfd: always select MMU_NOTIFIER
Date: Wed, 28 Mar 2018 18:04:33 +0200 [thread overview]
Message-ID: <664e2827-5237-160b-6ecf-c2da163569e1@amd.com> (raw)
In-Reply-To: <20180328155340.2253343-1-arnd@arndb.de>
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann:
> Building amdkfd without MMU notifiers is broken:
>
> In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28:
> drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type
>
> This adds the missing 'select MMU_NOTIFIER' line to make it build
> cleanly all the time.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Christian König <christian.koenig@amd.com>, but I would wait
on what Felix says to that.
> ---
> drivers/gpu/drm/amd/amdkfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index ed2f06c9f346..5a26acb90e19 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -4,6 +4,7 @@
>
> config HSA_AMD
> tristate "HSA kernel driver for AMD GPU devices"
> + select MMU_NOTIFIER
> depends on DRM_AMDGPU && X86_64
> imply AMD_IOMMU_V2
> help
next prev parent reply other threads:[~2018-03-28 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 15:53 Arnd Bergmann
2018-03-28 16:04 ` Christian König [this message]
2018-04-19 10:56 ` Anders Roxell
2018-04-19 17:47 ` Felix Kuehling
2018-04-24 9:53 ` Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=664e2827-5237-160b-6ecf-c2da163569e1@amd.com \
--to=christian.koenig@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®