From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Puranjay Mohan <puranjay@kernel.org>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Thomas Gleixner <tglx@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH] perf/x86/amd/lbr: Freeze LBR on PMI only when kernel branches are recorded
Date: Thu, 19 Nov 2026 10:12:00 +0530 [thread overview]
Message-ID: <664ee2ad-d11b-42d6-bc9f-85f88b5e6f32@amd.com> (raw)
In-Reply-To: <CAEf4BzaPDnopvSoS=AwN-gNPdzD0Bs4PvVPP+qCrdBFQ8CyJsg@mail.gmail.com>
On 19-Nov-26 5:35 AM, Andrii Nakryiko wrote:
> On Fri, Nov 13, 2026 at 7:48 PM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>>
>> On 23-Oct-26 6:11 PM, Puranjay Mohan wrote:
>>> On CPUs with X86_FEATURE_AMD_LBR_PMC_FREEZE the LBR is always frozen on
>>> PMI, so the branch stack ends before the IP and callchain, which are
>>> taken when the NMI is delivered. IBS rejects branch-stack events, so
>>> there is no precise alternative.
>>>
>>> The freeze only keeps the PMI handler's branches out of the stack, which
>>> matters only when branches into the kernel are recorded; without it the
>>> stack fills with the handler's own branches. A user-only filter does not
>>> record them, and parts without the feature are never frozen (see commit
>>> 598c2fafc06f ("perf/x86/amd/lbr: Use freeze based on availability")).
>>>
>>> Freeze unless the value written to LBR_SELECT, which is shared by all
>>> events on the CPU, suppresses branches into the kernel.
>>>
>>> With perf record -e ex_ret_brn_tkn:u -j any,u on a Zen 5 part running
>>> CPython, the function of the sampled IP differs from the function of
>>> LBR[0].to in 84.3% of samples with the freeze and in 0.1% without it.
>>>
>>> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
>>
>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
>>
>
> Thanks, Ravi!
>
> Do I understand correctly (from [0]) that we'll just stick to this
> patch and there is nothing from Puranjay's side to follow up on?
> Thanks!
>
> [0] https://lore.kernel.org/all/5cf60aaf-2ee4-482f-9054-dff823710431@amd.com/
That's right.
Ravi
prev parent reply other threads:[~2026-11-19 4:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 12:41 Puranjay Mohan
2026-10-26 15:35 ` Sandipan Das
2026-10-29 20:12 ` Andrii Nakryiko
2026-11-02 10:08 ` Sandipan Das
2026-11-03 19:09 ` Andrii Nakryiko
2026-11-05 6:17 ` Sandipan Das
2026-11-05 16:58 ` Andrii Nakryiko
2026-11-05 17:03 ` [PATCH RFC] perf/x86/amd/lbr: Don't freeze the LBR on PMI for user-only filters Puranjay Mohan
2026-11-06 1:07 ` Andrii Nakryiko
2026-11-10 19:05 ` Andrii Nakryiko
2026-11-12 11:09 ` Ravi Bangoria
2026-11-12 16:40 ` Andrii Nakryiko
2026-11-14 3:46 ` Ravi Bangoria
2026-11-14 3:48 ` [PATCH] perf/x86/amd/lbr: Freeze LBR on PMI only when kernel branches are recorded Ravi Bangoria
2026-11-19 0:05 ` Andrii Nakryiko
2026-11-19 4:42 ` Ravi Bangoria [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=664ee2ad-d11b-42d6-bc9f-85f88b5e6f32@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=puranjay@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®