From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbdJWRib (ORCPT ); Mon, 23 Oct 2017 13:38:31 -0400 Received: from mga07.intel.com ([134.134.136.100]:10094 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932267AbdJWRi3 (ORCPT ); Mon, 23 Oct 2017 13:38:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; d="scan'208";a="166540433" Subject: Re: [PATCH v5 2/6] perf record: Get the first sample time and last sample time To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1508542074-29483-1-git-send-email-yao.jin@linux.intel.com> <1508542074-29483-3-git-send-email-yao.jin@linux.intel.com> <20171023150436.GA10746@krava> From: "Jin, Yao" Message-ID: <6652168b-70e0-d643-d0a1-64fb310e57b1@linux.intel.com> Date: Tue, 24 Oct 2017 01:38:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023150436.GA10746@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2017 11:04 PM, Jiri Olsa wrote: > On Sat, Oct 21, 2017 at 07:27:50AM +0800, Jin Yao wrote: >> In perf record, it's walked on all samples yet. So it's very easy to get >> the first/last samples and save the time to perf file header via the >> function write_sample_time(). >> >> In later, perf report/script will fetch the time from perf file header. >> >> Change log: >> ----------- >> v5: There is an issue that the sample walking can only work when >> '--buildid-all' is not enabled. So we need to let the walking >> be able to work even if '--buildid-all' is enabled and let the >> processing skips the dso hit marking for this case. >> >> At first, I want to provide a new option "--record-time-boundaries". >> While after consideration, I think a new option is not very >> necessary. >> >> v3: Remove the definitions of first_sample_time and last_sample_time >> from struct record and directly save them in perf_evlist. >> >> Signed-off-by: Jin Yao >> --- >> tools/perf/builtin-record.c | 20 ++++++++++++-------- >> 1 file changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c >> index a6cbf16..bd711e8 100644 >> --- a/tools/perf/builtin-record.c >> +++ b/tools/perf/builtin-record.c >> @@ -391,8 +391,19 @@ static int process_sample_event(struct perf_tool *tool, >> { >> struct record *rec = container_of(tool, struct record, tool); >> >> - rec->samples++; >> + if (rec->evlist->first_sample_time == 0) >> + rec->evlist->first_sample_time = sample->time; >> + >> + rec->evlist->last_sample_time = sample->time; >> + >> + /* >> + * If --buildid-all is given, it marks all DSO regardless of hits, >> + * so no need to process this sample. >> + */ >> + if (rec->buildid_all) >> + return 0; >> >> + rec->samples++; >> return build_id__mark_dso_hit(tool, event, sample, evsel, machine); >> } >> >> @@ -415,13 +426,6 @@ static int process_buildids(struct record *rec) >> */ >> symbol_conf.ignore_vmlinux_buildid = true; >> >> - /* >> - * If --buildid-all is given, it marks all DSO regardless of hits, >> - * so no need to process samples. >> - */ >> - if (rec->buildid_all) >> - rec->tool.sample = NULL; > > hum, could you still unset the sample if there's no time given? > and keep the speed in this case.. > > jirka > Oh, yes, I should do that. Thanks Jiri! Hi Arnaldo, do you have any comment for v5? I will prepare v6 for adding fixes according to all comments. Thanks Jin Yao