From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A08B538A2B6 for ; Wed, 7 Jan 2026 15:48:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800924; cv=none; b=POWaYzVShW+sW7zfPrlXnReed3BjvbvdTDD5Nq3QawdlAqHjCexUbHbtJ36gZnzCPJACiSwLeNlPywabxAuUBME30vzQLim7kUSf6NQPOQvZf0W20Z+99crk47mwjiA/T+Li047OpdTzTwjzhKNZr94oJl9+KgAjOXKMU+orhw8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767800924; c=relaxed/simple; bh=xF5GV7zpnAdkWAoPQOo3dKMdyzQJeMJjUs1QDabUyQ8=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=PXcN5VcPMOs/u4R+6UAq/pDqR8YA3qDoUWJi+4ulr7c7aO/VU1mqtgeEygZb/Td+Pa0vb7zG7Fc5ZV/Vkt6l6OolqNZib5GvzuhVH7gfOU+g0T0zQh8POLLxLNj4k8UtPB37nehKw1Mw0yRnoLzDqeO/8PlNPtBrfFPo9dQASr0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 35D18497; Wed, 7 Jan 2026 07:48:35 -0800 (PST) Received: from [192.168.178.6] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD4833F7D8; Wed, 7 Jan 2026 07:48:39 -0800 (PST) Message-ID: <6667e71b-a9ef-4c01-9453-171c07b2753f@arm.com> Date: Wed, 7 Jan 2026 16:48:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] sched: update the rq->avg_idle when a task is moved to an idle CPU From: Dietmar Eggemann To: Shijie Huang , Huang Shijie , mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org Cc: patches@amperecomputing.com, cl@linux.com, Shubhang@os.amperecomputing.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, vschneid@redhat.com, vineethr@linux.ibm.com, kprateek.nayak@amd.com References: <20251209094508.570049-1-shijie@os.amperecomputing.com> <20251209094508.570049-3-shijie@os.amperecomputing.com> <51a9e1c4-3061-488c-89f4-ed656f3a73e3@amperemail.onmicrosoft.com> <0486368b-9cc9-48f3-8074-b72c76aab7e1@arm.com> <99c18623-4533-4dde-a765-ea43c85ee02f@amperemail.onmicrosoft.com> Content-Language: en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17.12.25 17:15, Dietmar Eggemann wrote: > On 15.12.25 10:35, Shijie Huang wrote: >> >> On 12/12/2025 22:22, Dietmar Eggemann wrote: [...] > I think Vincent is right by saying the update_rq_avg_idle() should be > put into put_prev_task_idle() instead. > > Still waiting for the DCPerf Mediawiki test results to see if this > change fixes my 'rq->avg_idle being too big' issue. Turns out the patch didn't fix this issue. Still seeing a huge number of sched_balance_newidle() calls in which the system is (1) overloaded and (2) this_rq->avg_idle >= sd->max_newidle_lb_cost so that there is no early bailout and no task is pulled at the end. Must be something else ...