From: KY Srinivasan <kys@microsoft.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"JBeulich@suse.com" <JBeulich@suse.com>
Subject: RE: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately
Date: Mon, 14 Apr 2014 17:09:49 +0000 [thread overview]
Message-ID: <666b84109e704ababfebc8232238623f@BY2PR03MB299.namprd03.prod.outlook.com> (raw)
In-Reply-To: <534C15F2.105@zytor.com>
> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa@zytor.com]
> Sent: Monday, April 14, 2014 10:08 AM
> To: KY Srinivasan; x86@kernel.org; gregkh@linuxfoundation.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com; tglx@linutronix.de;
> JBeulich@suse.com
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
>
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > + new_val = inb(PIC_MASTER_IMR);
> > + if (probe_val != new_val) {
>
> Nitpick: Linux coding style should have this as:
>
> if (new_val != probe_val)
>
> -hpa
>
Will address this as well.
K. Y
prev parent reply other threads:[~2014-04-14 17:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 17:46 K. Y. Srinivasan
2014-04-14 17:02 ` H. Peter Anvin
2014-04-14 17:03 ` KY Srinivasan
2014-04-14 17:08 ` H. Peter Anvin
2014-04-14 17:09 ` KY Srinivasan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666b84109e704ababfebc8232238623f@BY2PR03MB299.namprd03.prod.outlook.com \
--to=kys@microsoft.com \
--cc=JBeulich@suse.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®