From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A072FC00140 for ; Thu, 18 Aug 2022 11:06:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244252AbiHRLGR (ORCPT ); Thu, 18 Aug 2022 07:06:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241318AbiHRLGP (ORCPT ); Thu, 18 Aug 2022 07:06:15 -0400 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC578A0312 for ; Thu, 18 Aug 2022 04:06:14 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VMaUtiI_1660820771; Received: from 30.240.98.116(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VMaUtiI_1660820771) by smtp.aliyun-inc.com; Thu, 18 Aug 2022 19:06:12 +0800 Message-ID: <667ced2a-2724-265e-2019-cf97fa661b6a@linux.alibaba.com> Date: Thu, 18 Aug 2022 19:06:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH] mm/damon/lru_sort: Move target memory region check to head of func To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220818082538.67825-1-xhao@linux.alibaba.com> From: haoxin In-Reply-To: <20220818082538.67825-1-xhao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Please ignore this patch, i have send a  patch v2 in there: https://lore.kernel.org/damon/20220818105732.34492-1-xhao@linux.alibaba.com/ 在 2022/8/18 下午4:25, Xin Hao 写道: > In damon_lru_sort_apply_parameters(), if "monitor_region_start" > and "monitor_region_end" is not a valid physical address range, > There no need to run the remainder codes in it. > > Signed-off-by: Xin Hao > --- > mm/damon/lru_sort.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c > index 9de6f00a71c5..ac50dca026f9 100644 > --- a/mm/damon/lru_sort.c > +++ b/mm/damon/lru_sort.c > @@ -378,6 +378,13 @@ static int damon_lru_sort_apply_parameters(void) > unsigned int hot_thres, cold_thres; > int err = 0; > > + if (monitor_region_start > monitor_region_end) > + return -EINVAL; > + if (!monitor_region_start && !monitor_region_end && > + !get_monitoring_region(&monitor_region_start, > + &monitor_region_end)) > + return -EINVAL; > + > err = damon_set_attrs(ctx, sample_interval, aggr_interval, 0, > min_nr_regions, max_nr_regions); > if (err) > @@ -401,12 +408,6 @@ static int damon_lru_sort_apply_parameters(void) > return -ENOMEM; > damon_add_scheme(ctx, scheme); > > - if (monitor_region_start > monitor_region_end) > - return -EINVAL; > - if (!monitor_region_start && !monitor_region_end && > - !get_monitoring_region(&monitor_region_start, > - &monitor_region_end)) > - return -EINVAL; > addr_range.start = monitor_region_start; > addr_range.end = monitor_region_end; > return damon_set_regions(target, &addr_range, 1); > -- > 2.31.0