From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750928AbdE2DVk (ORCPT ); Sun, 28 May 2017 23:21:40 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:16949 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750837AbdE2DVi (ORCPT ); Sun, 28 May 2017 23:21:38 -0400 X-AuditID: b6c32a35-f79806d000002bf4-fe-592b93c0e9b0 Subject: Re: [PATCH v3 1/2] mmc: dw_mmc: Use device_property_read instead of of_property_read To: David Woods , ulf.hansson@linaro.org, shawn.lin@rock-chips.com, hkallweit1@gmail.com, adrian.hunter@intel.com, cmetcalf@mellanox.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.linux.org From: Jaehoon Chung Message-id: <667edf5b-ed1c-1f00-8a00-e2eff7f6205e@samsung.com> Date: Mon, 29 May 2017 12:21:35 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: <1495835601-20327-1-git-send-email-dwoods@mellanox.com> Content-type: text/plain; charset="windows-1252" Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01Se2xLcRTOr7e993ZRrtI5JlhuQmKservX3ZgQwxX7Y0w8NtS1/bIu1ofe DpOQTURlQccsXTp/eCQbZpls3pliFdswhmWCmdciJox03mF0vSX77zsn33fO950cmtBWkVF0 vtWJHVaxgCUjlOf90/Sx18qnrza8bdPxbb2nSb7frecHXH6KP/axUsU/vHyY5G/8cSO+u7de xZfVPFLwLXUr56qFS95nlHC8qU8hdHc1kcIbj18h/PZeVQoDDZOEipJbZAaVhWebsZiLHdHY mmPLzbfmpbJLMk3zTQmJBi6WS+aT2GiraMGpbFp6RuzC/IKgMTZ6s1hQGGxliJLEzpwz22Er dOJos01yprLZHGfUc4YkvdFo1MfHrU0xJgQp67H5de83yn5qwtbb7itEMToRWYrUNDDxUFHx jZJxJHT01JOlKILWMhcR3HS7kFwMIOiv7FL9U3S2Dir/s1paKwm56EFw51hdkEXTYxgTlDUw Q/2xTDeC9vZBYkhNMOOh86Q/NIlkZsCFry2KIaxh5sCn3x0hjpKZAnVn34ewjlkBjc/7KJkz Gr6X9yiH5quZNPD5FsgjDVB5yK+Q8WRoPP0h5AeY8xTUfKgN+QFmIjRcI+QAaeC6fyAceQy8 azkbxlFQ0vdSIWtdCJ5895FysQfB9R9XwvHj4FZpSXjbSOj/sje8QAN7dmtligDe6p+kjOdB q+exQj6QB0FN2VeqDE32DsvjHRbCOyzEEUScQpHYLlnysMTZOb0kWqRCa54+x2ZpQKHHjEm4 iA7dTW9GDI3YEZoz86ev1qrEzVKRpRkBTbBjNRVbgi1Nrli0DTtsJkdhAZaaUULwxgeIKF2O LfjmVqeJi082xCcag8+WzHHsOI2uvmuVlskTnXgjxnbs+KdT0OqoYmTf8bn2pOrTxOoFgaPr siy3n1GB6lH27bOMvqSqyAsRBwO72aVU3KapxeWLXIt27v+8JjCifINvSedSTd8bg+fosstH Bt2ZKfOqdtyLe+CJWbHv19wbQsrNZdg6Wr3L0Pki+9fT3ilt7YsDluXt5veqxgkqVVHWzj/p unOekle6xFcdrFIyi1wM4ZDEv37jGe2uAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t9jAd39k7UjDXqvGlucfLKGzeJdv57F 5/bD7BaL3s9gtbi8aw6bxZH//YwWd56sZ7WYsPw6k8XxteEOnB47Z91l91i85yWTx51re9g8 nk0/zOTxd9Z+Fo/Pm+Q8pjaeYgtgj3KzyUhNTEktUkjNS85PycxLt1UKDXHTtVBSyEvMTbVV itD1DQlSUihLzCkF8owM0ICDc4B7sJK+XYJbxuMn39kLVklXnO7fy9zAuEKsi5GTQ0LAROLK iX8sELaYxIV769m6GLk4hAS2MUr8OtzNCuE8YJTofnodyOHgEBaIl5iwSQAkLiJwi1Hi0b85 zBBFMxklLq/fxgYyillAUuLKysOsIDabgI7E9m/HmUBsXgE7iQ9/LzCD2CwCqhJrt7xhBhkq KhAm8bzRCaJEUOLH5HssIGFOAReJfftcQUxmAT2J+xe1IIbLS2xe85Z5AqPALCQNsxCqZiGp WsDIvIqRK7WgODc9t9iowHATIzDOth3W8t/B+ONs9CFGAQ5GJR7eDc7akUKsiWXFlbmHGCU4 mJVEeKeWA4V4UxIrq1KL8uOLSnNSiw8xmgKdPZFZSjQ5H5gC8kriDU0sjUwMzMwMjQyMzZTE eScEfokQEkhPLEnNTk0tSC2C6WPi4JRqYJydrcAUrLtrgShrR+bCuCXHTPrm2z5KerN855ql 6VseZs03Yf4+qV798F6GCxfWtJr++zk1atrCfIb/D+Z/mNb+MH2ipdTr+p8Rncti55rq3+BT dA+emmS04MmO+Sc4N37g/XVZdP1RiR+aVvzSvfOUHSuP3BOOiLo+q/n2xQ2PPE4vY12ewSOi xFKckWioxVxUnAgA/QuKk8kCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170529032135epcas1p138b233f33343a1eaba2f20a43ab5a465 X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?7KCV7J6s7ZuIG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SmFlaG9vbiBDaHVuZxtUaXplbiBQbGF0Zm9ybSBMYWIuG1Nh?= =?UTF-8?B?bXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170527014552epcas2p16b1befaccf5dff3d7ab534dda60f4191 X-RootMTR: 20170527014552epcas2p16b1befaccf5dff3d7ab534dda60f4191 References: <1495835601-20327-1-git-send-email-dwoods@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27/2017 06:53 AM, David Woods wrote: > Using the device_property interfaces allows the dw_mmc driver to work > on platforms which run on either device tree or ACPI. > > Signed-off-by: David Woods > Reviewed-by: Chris Metcalf > Cc: stable@vger.linux.org Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/host/dw_mmc.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index e45129f..efde0f2 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2707,8 +2707,8 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > host->slot[id] = slot; > > mmc->ops = &dw_mci_ops; > - if (of_property_read_u32_array(host->dev->of_node, > - "clock-freq-min-max", freq, 2)) { > + if (device_property_read_u32_array(host->dev, "clock-freq-min-max", > + freq, 2)) { > mmc->f_min = DW_MCI_FREQ_MIN; > mmc->f_max = DW_MCI_FREQ_MAX; > } else { > @@ -2808,7 +2808,6 @@ static void dw_mci_init_dma(struct dw_mci *host) > { > int addr_config; > struct device *dev = host->dev; > - struct device_node *np = dev->of_node; > > /* > * Check tansfer mode from HCON[17:16] > @@ -2869,8 +2868,9 @@ static void dw_mci_init_dma(struct dw_mci *host) > dev_info(host->dev, "Using internal DMA controller.\n"); > } else { > /* TRANS_MODE_EDMAC: check dma bindings again */ > - if ((of_property_count_strings(np, "dma-names") < 0) || > - (!of_find_property(np, "dmas", NULL))) { > + if ((device_property_read_string_array(dev, "dma-names", > + NULL, 0) < 0) || > + !device_property_present(dev, "dmas")) { > goto no_dma; > } > host->dma_ops = &dw_mci_edmac_ops; > @@ -2937,7 +2937,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > { > struct dw_mci_board *pdata; > struct device *dev = host->dev; > - struct device_node *np = dev->of_node; > const struct dw_mci_drv_data *drv_data = host->drv_data; > int ret; > u32 clock_frequency; > @@ -2954,20 +2953,21 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > } > > /* find out number of slots supported */ > - of_property_read_u32(np, "num-slots", &pdata->num_slots); > + device_property_read_u32(dev, "num-slots", &pdata->num_slots); > > - if (of_property_read_u32(np, "fifo-depth", &pdata->fifo_depth)) > + if (device_property_read_u32(dev, "fifo-depth", &pdata->fifo_depth)) > dev_info(dev, > "fifo-depth property not found, using value of FIFOTH register as default\n"); > > - of_property_read_u32(np, "card-detect-delay", &pdata->detect_delay_ms); > + device_property_read_u32(dev, "card-detect-delay", > + &pdata->detect_delay_ms); > > - of_property_read_u32(np, "data-addr", &host->data_addr_override); > + device_property_read_u32(dev, "data-addr", &host->data_addr_override); > > - if (of_get_property(np, "fifo-watermark-aligned", NULL)) > + if (device_property_present(dev, "fifo-watermark-aligned")) > host->wm_aligned = true; > > - if (!of_property_read_u32(np, "clock-frequency", &clock_frequency)) > + if (!device_property_read_u32(dev, "clock-frequency", &clock_frequency)) > pdata->bus_hz = clock_frequency; > > if (drv_data && drv_data->parse_dt) { >