From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15574C4332F for ; Thu, 9 Nov 2023 13:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234212AbjKIN4G (ORCPT ); Thu, 9 Nov 2023 08:56:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231586AbjKIN4E (ORCPT ); Thu, 9 Nov 2023 08:56:04 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DFE5272C for ; Thu, 9 Nov 2023 05:56:01 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-407c3adef8eso6504015e9.2 for ; Thu, 09 Nov 2023 05:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699538160; x=1700142960; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FZeLfPHVqMBuayrhJ/3sdbY4wdW0+rsHSntZWGqtzq8=; b=djrQgnGP2/L8L1O1iKnzNh7mesNWY9s/6N0QQ9SzgqvFjJLQj4/1Bjb/1AJDCk3Y4K 845PvpB1KkScD790yi1Qjx5Ce3+vkM0t2AVxF0zMRQ4pfkHSOKbwI/gjyFA0J/d9RRAH KyVGBKOsLLhRKLTy0x43I6qWqQXFCpU0WC566g2HRl0dwTlTS/IMSvgHpdvEkYQiI8rV JngSSLRWBZ+82zpxNA2F1bPnh8f+dzCDIADzcqE+3j7IZJ+C/ZeGz+r7MFmg+mKYJM/I fNJqJGw5P6QIiYT7M/ZcDipJkhLERHn5H54pxMLFZRW5e8R/TQxVJOA5f8Hy26uSTVEb sWHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699538160; x=1700142960; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FZeLfPHVqMBuayrhJ/3sdbY4wdW0+rsHSntZWGqtzq8=; b=D58v8rypw520S/TSNFtk59SrC4uJ4jWA00ja+cPkez0Ysm9YfOb+V8t53Uj8j8XobA MuJ5A35UqRtE3w/vb0pkhVnrwELmAcoygCu5VwYZ8KqVWBNqba3y5L47WJMzqJtbS693 jk1ll8SqGBGWEPGKclyjQ8CDi/1oriNqzwyrTwCTQPfDSAXAO8o2Un8EpbnhyP3blnGX T+Jwr7vFVxDxjmNkBs3OBbV6a+z8fpjcETOtcdrxq0iG+oqWZiWSrbRZL++m5HkoQ23s X5asZZxrFX2hVLBmO28AhmLP1ILhshWQg9GWCyh14g6HaXopSNsRvYpZkz8tBrVkBX+F Pwig== X-Gm-Message-State: AOJu0Yz5tGWVnfgUozRTZ0oz2OIlsW7PrX8Za17DStDc1l4QOr+8XAuN YX3Tf9edN/ZSJFaL0YT5enLpag== X-Google-Smtp-Source: AGHT+IFW5u0UUDAvXxhE/6joXL6md5DC36QI87dVcaE2HhVVu3xycPZUCAqwrEw+XzT6s4DrR+dE3w== X-Received: by 2002:a1c:6a14:0:b0:408:4eb2:3b1b with SMTP id f20-20020a1c6a14000000b004084eb23b1bmr4409497wmc.21.1699538159828; Thu, 09 Nov 2023 05:55:59 -0800 (PST) Received: from [10.66.66.2] (9.ip-51-91-159.eu. [51.91.159.9]) by smtp.gmail.com with ESMTPSA id u3-20020adfed43000000b003140f47224csm7411099wro.15.2023.11.09.05.55.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 05:55:59 -0800 (PST) Message-ID: <66837892-365f-4845-95d1-d7329234d87e@linaro.org> Date: Thu, 9 Nov 2023 14:55:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 two-phase MIPI CSI-2 DPHY init Content-Language: en-US To: Bryan O'Donoghue , hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, Andy Gross , Bjorn Andersson , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , vincent.knecht@mailoo.org, matti.lehtimaki@gmail.com, quic_grosikop@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231109-b4-camss-sc8280xp-v4-0-58a58bc200f9@linaro.org> <20231109-b4-camss-sc8280xp-v4-3-58a58bc200f9@linaro.org> From: Konrad Dybcio In-Reply-To: <20231109-b4-camss-sc8280xp-v4-3-58a58bc200f9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/23 12:30, Bryan O'Donoghue wrote: > Add a PHY configuration sequence for the sc8280xp which uses a Qualcomm > Gen 2 version 1.1 CSI-2 PHY. > > The PHY can be configured as two phase or three phase in C-PHY or D-PHY > mode. This configuration supports two-phase D-PHY mode. > > Signed-off-by: Bryan O'Donoghue > --- [...] > + {0x0000, 0x90, 0x00, CSIPHY_DEFAULT_PARAMS}, > + {0x0008, 0x0E, 0x00, CSIPHY_SETTLE_CNT_LOWER_BYTE}, > + {0x000c, 0x00, 0x00, CSIPHY_DNP_PARAMS}, Forgot to add, please choose one capitalization for hex numbers. Konrad