From: Jason Wang <jasowang@redhat.com>
To: Tariq Toukan <tariqt@mellanox.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: mst@redhat.com, jbrouer@redhat.com,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH net-next V2 2/2] tuntap: XDP transmission
Date: Thu, 11 Jan 2018 10:35:10 +0800 [thread overview]
Message-ID: <668445bc-5920-23a6-c59f-3b09e2c4fed1@redhat.com> (raw)
In-Reply-To: <aede4fe5-baac-f50e-1ece-9b3562c03a6d@mellanox.com>
On 2018年01月11日 00:11, Tariq Toukan wrote:
>> +EXPORT_SYMBOL(tun_ptr_to_xdp);
>> +
>
> Hi Jason,
> I started getting the following compilation issues.
>
> + make -j24 -s
> net/socket.o: In function `tun_xdp_to_ptr':
> /images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46:
> multiple definition of `tun_xdp_to_ptr'
> fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:46:
> first defined here
> net/socket.o: In function `tun_ptr_to_xdp':
> /images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50:
> multiple definition of `tun_ptr_to_xdp'
> fs/compat_ioctl.o:/images/autom/buildbot/worker/merge-net-next/build/./include/linux/if_tun.h:50:
> first defined here
> make: *** [vmlinux] Error 1
>
> Seems you missed adding the following ifdef:
> #if defined(CONFIG_TUN) || defined(CONFIG_TUN_MODULE)
>
> Thanks,
> Tariq
My bad and sorry for that.
It should have been fixed by
https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=1125b008711581a8962ee028e2982d7757093600
Thanks
next prev parent reply other threads:[~2018-01-11 2:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 3:14 [PATCH net-next V2 0/2] XDP transmission for tuntap Jason Wang
2018-01-04 3:14 ` [PATCH net-next V2 1/2] tun/tap: use ptr_ring instead of skb_array Jason Wang
2018-01-04 3:14 ` [PATCH net-next V2 2/2] tuntap: XDP transmission Jason Wang
2018-01-10 16:11 ` Tariq Toukan
2018-01-11 2:35 ` Jason Wang [this message]
2018-01-09 16:06 ` [PATCH net-next V2 0/2] XDP transmission for tuntap David Miller
2018-01-10 3:00 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=668445bc-5920-23a6-c59f-3b09e2c4fed1@redhat.com \
--to=jasowang@redhat.com \
--cc=brouer@redhat.com \
--cc=jbrouer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®