From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jianhua Lu <lujianhua000@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250-elish-*: Fix panel compatibles
Date: Wed, 12 Apr 2023 22:22:33 +0200 [thread overview]
Message-ID: <66851ec3-b797-6b40-865c-ec375b5ded68@linaro.org> (raw)
In-Reply-To: <ec2rxutblwlm2wxm6e4zlu3v5d3f6l2eqxjafq2emky6t2kvgt@3u2lo4e53ixs>
On 12.04.2023 22:20, Marijn Suijten wrote:
> On 2023-04-12 21:47:20, Konrad Dybcio wrote:
>> The fallback compatible was missing, resulting in dtbs_check failing.
>> Fix it.
>>
>> Fixes: 51c4c2bd6f31 ("arm64: dts: qcom: sm8250-xiaomi-elish-boe: Add mdss and dsi panel")
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>
> As usual: Krzysztof already sent these:
>
> https://lore.kernel.org/linux-arm-msm/20230408130809.52319-2-krzysztof.kozlowski@linaro.org/T/#u
Right.
>
>> ---
>> foo b4 requires i put something here
>
> What?
git checkout linux-next/master
<craft a single patch>
b4 prep -e $(cat localversion-next| cut -c 2-)
b4 prep --edit-cover
/* you get a bunch of EDITMEs that b4 really insists you fill out */
Konrad
>
>> ---
>> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts | 2 +-
>> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
>> index 8b2ae39950ff..de6101ddebe7 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-boe.dts
>> @@ -13,6 +13,6 @@ / {
>> };
>>
>> &display_panel {
>> - compatible = "xiaomi,elish-boe-nt36523";
>> + compatible = "xiaomi,elish-boe-nt36523", "novatek,nt36523";
>> status = "okay";
>> };
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
>> index a4d5341495cf..4cffe9c703df 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-csot.dts
>> @@ -13,6 +13,6 @@ / {
>> };
>>
>> &display_panel {
>> - compatible = "xiaomi,elish-csot-nt36523";
>> + compatible = "xiaomi,elish-csot-nt36523", "novatek,nt36523";
>> status = "okay";
>> };
>>
>> ---
>> base-commit: 7d8214bba44c1aa6a75921a09a691945d26a8d43
>> change-id: 20230412-topic-elish_compat-73c4511957a5
>>
>> Best regards,
>> --
>> Konrad Dybcio <konrad.dybcio@linaro.org>
>>
next prev parent reply other threads:[~2023-04-12 20:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 19:47 Konrad Dybcio
2023-04-12 20:20 ` Marijn Suijten
2023-04-12 20:22 ` Konrad Dybcio [this message]
2023-04-12 20:23 ` Konrad Dybcio
2023-04-12 20:28 ` Marijn Suijten
2023-04-12 20:29 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66851ec3-b797-6b40-865c-ec375b5ded68@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®