From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F5D30C637 for ; Fri, 27 Mar 2026 12:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774616014; cv=none; b=f4hz9q/LJZyaiyuncO0C2hXa7W/WUjWqdbc5XiWjTSqtcuBwIeCk3rXoMbROTaw1iK5EMjvhPhpjHG04ElIs04kUyXCpG6vyUSEr2ix+pIHy4DwDZIu/TVWkUgXbBw3kv2g8AZ98+/OD134HKGTstQ1sEF68Gk4aSwgBs1X+ObY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774616014; c=relaxed/simple; bh=82hBkgUQBRYsEeYM1Pt/3YAGZ95NIaM+aAvRhDaBC/A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F590gE4d/dmjqW4Aql22XQnclOQ56+BR9IIl/KO0kCyJtzdQxQ8XRiVwlQZpdDWFuciwGV7JmIOF6DcthgDWM+z13lqSdGmvpjU/2A0NR2mauTmXaPNsEoIjWJl0gf8BHID3QNNWRiUu5jKF5JflNa8g9zw8jm9/KFiET5kf1q4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QTxLJmX1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eNG6qGZE; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QTxLJmX1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eNG6qGZE" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6w3AQ1860247 for ; Fri, 27 Mar 2026 12:53:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nCgve90m/nG4dKANvG2uOMtnscJK8H1SmJtIiWg4EQs=; b=QTxLJmX1xYvlflEM 7OSRLyfE66HZq8dqabIU5HUK1AS5eKSTzyz8PLle3UkpqXOqMd7sd4NwzXwe2csL zTUjLkJBRLPSYs5XnNZ3giKZEcO8S+6X86yL5zglgq3QPRng33vJgIkQgaoVpfJw VpQ2Rire22tEXIyd263tPkOjpKBD4uYKHZSrr7KHNu/1vM6lJnTTtSUT+rr/9j1n 6+7BwPpZx9n0eEJ7RmjUMP760lyzXTBwbrZfjKA3QNY7fazSVrVAkdk1hfAsc8w+ IcgH6R5Hl37BGBmwAM0Cvz3iKqDySqrcmiDAdv8GdD0XZ8oEKr3JHHLMqVSKG3wN 2IITsQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5bxv32jj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 12:53:32 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50b2d5e61f6so5155621cf.1 for ; Fri, 27 Mar 2026 05:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774616012; x=1775220812; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nCgve90m/nG4dKANvG2uOMtnscJK8H1SmJtIiWg4EQs=; b=eNG6qGZEP65LDmVMVQPmT5iM1HoHsg57gWwxyRfdTCLzUdSYIGzonPLMsosxQoYhhi lc7WZy29VHHpb/U1ZupsjsWs57xiBIsgcIGwdMGrXgOuLjUVxKPsEhiJ1EdSNZ2oaJ7V 29rDHY7dqtuvHtWxATVX8a4E6x4eSUTMHAK5pCQTn75trTIz6cqMtNXor/kp+3xp0JAm WoukDmcuqp1lqvHnvo6zY9iyXYImoNOEMBV0PJ7ZjO58R2TF4Byf26/YvSJCUN2dH/nW dOsqwiVJ6Qwdv3/BAIEBVOHubABuEuRqp8oHmiBGOHPbUT99ESHsdZr7ldRyQHdz4t3F 0FEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774616012; x=1775220812; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nCgve90m/nG4dKANvG2uOMtnscJK8H1SmJtIiWg4EQs=; b=Y50ts/76Ntfiqcoo2CWFIOLaiceq3R6GrFXcWfakJ4uCfd1BJhZmDAsCSWS26hpNNO dhPlYgQ5RyBur8sO8U5aLzdqUhEAJTWkaNaU+tDQXuaC94P4uowHac9xLlJYA5hq+ubY 1dhwqMLiffz1JUJjYdsPFQi+t+iLdb/svC66dEOUPRBrU8NXrM3yUQz250ZQngwUcorr vALyMJOGAdrPkBst3Hg4412zyOiRJyudX1zEyzBR+rmrWWN0dxIikbamSZqHaU+OpsPj yfNDcgCAqBAfFeLTZgT1RJ3OjcZEw98exmYOIoYbn8lsv1ZTUr3DxOyP6pyNFwpE6UBI n4Xw== X-Forwarded-Encrypted: i=1; AJvYcCUGZVSfX1AD9A5j+yLYBDe5D4OzH/t147DrorSQGb9p9EFurKbwYztJdm/7NQC9CVj8H7jRbTJkvwPAeJQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxVg6l9DjdUGimJesmJDLc7W57wsOp2lWWhSwDvYNYPrXFcKk4d vjxjUTDWuxVXn8luTCys2E9I3xEgIfNeShDVOPzA23YZjStMR7UrHgeg4e/qcOOUjqhmgvLRt3m wdLsGKQprl/tI2QUllKuKJ5oTWVoPREk1J1H18XeRwrOmw6RvY7PZJud3k6XTOyX4kFc= X-Gm-Gg: ATEYQzwxABQ+XGHjVYG44J7+wRRb1sBv9/R4jikDRC9BQUfYfFFzoyQZ0Os+lqtPlTu lBkhYDo2zQlvykelaQlm2XpQEtxk1jGm0vbtROS0jBFzljeyRgc2xaJSmbPDgu5LyOVlqHQxnFw CtR+3mooB3dCabWrBvKdgPReHO7k+RtIbMdSZdKYSOjbRItmu5242euG3emVJfFBe0BPbtNa+a0 breczh4Qxb+vUo5EveWTmkBxSKgWHNxzKFCMgfLnm/REA/ccUk2wzUQacsS0Wau1anFzMS0Bha7 VjNPcvfzFmmZzIFt3lNDz5CpvQhlybVdGFsLCbInj9IYyl7AA6L++S/fR8cjMVzb/3eg7TRHR9X KUGOjT9Jx4D6zipGV5cFMDvW4o6gCHdzdVtGaeGnCZIHNY6kr1vnzHbiM/4l6zItKh+f0MkA/VD CLA2Y= X-Received: by 2002:ac8:5a11:0:b0:509:2a92:8088 with SMTP id d75a77b69052e-50ba382505bmr24444011cf.1.1774616011805; Fri, 27 Mar 2026 05:53:31 -0700 (PDT) X-Received: by 2002:ac8:5a11:0:b0:509:2a92:8088 with SMTP id d75a77b69052e-50ba382505bmr24443631cf.1.1774616011338; Fri, 27 Mar 2026 05:53:31 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b2029be87sm248918866b.28.2026.03.27.05.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 05:53:29 -0700 (PDT) Message-ID: <66879526-15e3-42af-a2ed-153f9cfc66d5@oss.qualcomm.com> Date: Fri, 27 Mar 2026 13:53:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/7] dt-bindings: media: qcom,x1e80100-camss: Add simple-mfd compatible To: Bryan O'Donoghue , Krzysztof Kozlowski , Bryan O'Donoghue , Dmitry Baryshkov Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Vladimir Zapolskiy , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-0-fdfe984fe941@linaro.org> <20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-1-fdfe984fe941@linaro.org> <20260316-glaring-jaybird-from-wonderland-4f8fd6@quoll> <94f4fda4-504e-44eb-87f0-e34e557402f8@linaro.org> <471895f6-dc60-44d8-84ce-8ba0069110e4@kernel.org> <1671b8ce-cbf9-45ae-947b-f35d174be93e@kernel.org> <61fa4409-e19c-49d9-b7fa-dc6f8413c181@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <61fa4409-e19c-49d9-b7fa-dc6f8413c181@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=A99h/qWG c=1 sm=1 tr=0 ts=69c67dcc cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=13ZpxKrbrQONVxPmPHwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: OpgUVBSSizaG5OmZGieARIZjNTHBjovN X-Proofpoint-GUID: OpgUVBSSizaG5OmZGieARIZjNTHBjovN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA4OCBTYWx0ZWRfX09bY9D+SZwsy YCPk+TKvs1ONcdj3SG8QmROUqjQxIjkJJc6TRPfn8rqHETMY4p2u4Qa2A0BNbWG77QIfAzdL8TB n3VjvToBmh8L/UULo8NAKRAfkWhEdRNANJ56uQFp1MZc4hM4KsPbbItgdGVyP9ugXjS4k3v2vFO qK/hRQGZ49iVfX4gtnjtte2owuo7HTWxVDKYXUCRb/4gBAb2LHu8es6j+JIQGjcPc7Hnwo0+2XT FJAfileVddJIz3s89HWelsmQW0QjiJoKwoEVAsuj8d8FOOacocFuMpD9/+nsgNtmdI7iKLWO2yc xNiQZ02CxLBixLBJ8EGaUn5gBE6zBh9kEyIwGR+a/onG+CZIlY0wPDVy/iVnF2Anhrr05jhlTdN 96PecN0KI7qeqi2vi4SFuafeIBETmUVq3rEQFBuHrrYDBB3lra9ZNA7sb/8/Lm0XP/XR+jmPYtq M/WvoWbmESI1B2O8v/w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270088 On 3/17/26 5:21 PM, Bryan O'Donoghue wrote: > On 17/03/2026 16:00, Krzysztof Kozlowski wrote: >>>> I actually got the idea from: >>>> >>>> commit fe6a952b567f6a771d087d2e969914f31574d6ab >>>> Author: Krzysztof Kozlowski >>>> Date:   Fri Jan 27 20:40:50 2023 +0100 >>> If you refer to my commits, at least read them. Do you see children >>> there? Yes. You have none. >>> >>> Plus trying to get 13 year old legacy device without dtbs_check warnings >>> is different thing than correcting a recently introduced bindings. >>> Terrible example to take... And if you find example from 20 years ago, >>> it will be even worse. >>> >> One more thing, that commit was still correct because it fulfilled the >> simple-mfd requirement of lack of dependency on the parent. I do not >> believe your code fulfills it. I am pretty sure it does not. > > Yeah I take the logic of that point: > > CSIPHY here depends on the GDSC, power-domains and clocks we've listed, its not being supplied by any of the other blocks that live inside of the rest. > > They don't require any resources from the parent and the parent consumes the child phys via phandles. > > To my mind that fits the criteria you've set of !depends on parent. FWIW the problem here seems to be the assumption that: "needs to probe child devices" == "must have simple-mfd compatible" You can just add a devm_of_platform_populate() somewhere in CAMSS probe (or do component_device like in drm/msm) Konrad