From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Liang Wang <wangliang101@huawei.com>, <palmerdabbelt@google.com>,
<mcgrof@kernel.org>, <linux-kernel@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <linux@armlinux.org.uk>,
<linux-arm-kernel@lists.infradead.org>
Cc: <stable@vger.kernel.org>, <wangle6@huawei.com>,
<kepler.chenxin@huawei.com>, <nixiaoming@huawei.com>
Subject: Re: [PATCH v3] lib: Use PFN_PHYS() in devmem_is_allowed()
Date: Wed, 4 Aug 2021 13:01:46 +0800 [thread overview]
Message-ID: <668986ec-bdc5-482f-39ed-8e059008016d@huawei.com> (raw)
In-Reply-To: <20210731025057.78825-1-wangliang101@huawei.com>
On 2021/7/31 10:50, Liang Wang wrote:
> The physical address may exceed 32 bits on 32-bit systems with
> more than 32 bits of physcial address,use PFN_PHYS() in devmem_is_allowed(),
> or the physical address may overflow and be truncated.
> We found this bug when mapping a high addresses through devmem tool,
> when CONFIG_STRICT_DEVMEM is enabled on the ARM with ARM_LPAE and devmem
> is used to map a high address that is not in the iomem address range,
> an unexpected error indicating no permission is returned.
>
> This bug was initially introduced from v2.6.37, and the function was moved
> to lib when v5.11.
>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
> Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
> Cc: stable@vger.kernel.org # v2.6.37
> Signed-off-by: Liang Wang <wangliang101@huawei.com>
Reviewed-by: Kefeng Wang <wangkefeng.wang@huawei.com>
next prev parent reply other threads:[~2021-08-04 5:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 2:50 Liang Wang
2021-08-02 22:40 ` Luis Chamberlain
2021-08-04 5:01 ` Kefeng Wang [this message]
2021-08-04 5:14 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=668986ec-bdc5-482f-39ed-8e059008016d@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kepler.chenxin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mcgrof@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=palmerdabbelt@google.com \
--cc=stable@vger.kernel.org \
--cc=wangle6@huawei.com \
--cc=wangliang101@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®