From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linusw@kernel.org>
Cc: Jun Nie <jun.nie@linaro.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 5/6] dt-bindings: display: Add Synaptics R63455 panel support
Date: Tue, 29 Sep 2026 15:35:45 +0200 [thread overview]
Message-ID: <668e83d0-a017-4f59-bc76-bf6c9a80b5ba@kernel.org> (raw)
In-Reply-To: <CAD++jLkX0m6_GJd4Pd1Ko4tghta4AXQ5ALZpLe_x-3xxqu1Cvw@mail.gmail.com>
On 29/09/2026 14:54, Linus Walleij wrote:
> On Mon, Jul 27, 2026 at 10:29 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Mon, Jul 27, 2026 at 04:08:44PM +0800, Jun Nie wrote:
>
>>> + reset-gpios:
>>> + maxItems: 2
>>> + description: 2 reset pins for 2 physical panels
>>
>> Won't work. gpio-consumer-common expects only one reset line. You need
>> two separate properties.
>
> Hm that is a big confusion for the head.
>
> reset-gpios is by it's very nature plural, because we structured
So GPIOs are plural, but not reset-gpios. Just like shutdown-gpios. If
you have two pins to turn off one device, how does it work? Maybe you
have simple two devices?
> all GPIOs like that, exactly in order to indicate that they can be
> arrays. :/
Yes, in many cases.
>
> I think it's appropriate to patch gpio-consumer-common to accept
>> 1 gpios, in a separate patch, can even be sent outside
> of this series.
>
> Unless the DT maintainers have some good reason to slap my
> hands for that suggestion...
Make a case, can be an exception in gpio-consumer-common. But if you
have two panels, why can't it go to the graph for each of them?
This entire binding seems like stitching two devices together, which
might be fine (I don't even remember this stuff... two months old) or
might be artificial grouping of separate devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-29 13:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 8:08 [PATCH v5 0/6] Add support to 2 panels in bonded-DSI mode Jun Nie
2026-07-27 8:08 ` [PATCH v5 1/6] dt-bindings: display: panel: Modify reset gpio number constrain Jun Nie
2026-07-27 20:23 ` Krzysztof Kozlowski
2026-07-29 8:01 ` Jun Nie
2026-07-29 8:05 ` Krzysztof Kozlowski
2026-07-29 8:17 ` Jun Nie
2026-07-27 20:24 ` Krzysztof Kozlowski
2026-07-27 8:08 ` [PATCH v5 2/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1 Jun Nie
2026-09-29 16:03 ` Dmitry Baryshkov
2026-07-27 8:08 ` [PATCH v5 3/6] drm/mipi-dsi: Add flag to support dual-panel configurations Jun Nie
2026-09-29 16:05 ` Dmitry Baryshkov
2026-07-27 8:08 ` [PATCH v5 4/6] drm/msm/dsi: Support dual panel use case with single CRTC Jun Nie
2026-09-29 16:20 ` Dmitry Baryshkov
2026-07-27 8:08 ` [PATCH v5 5/6] dt-bindings: display: Add Synaptics R63455 panel support Jun Nie
2026-07-27 9:47 ` Rob Herring (Arm)
2026-07-27 20:42 ` Krzysztof Kozlowski
2026-07-27 20:29 ` Krzysztof Kozlowski
2026-09-29 12:54 ` Linus Walleij
2026-09-29 13:35 ` Krzysztof Kozlowski [this message]
2026-09-29 16:27 ` Dmitry Baryshkov
2026-07-27 8:08 ` [PATCH v5 6/6] drm/panel: Add driver for Synaptics R63455 DSI panel Jun Nie
2026-09-29 13:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=668e83d0-a017-4f59-bc76-bf6c9a80b5ba@kernel.org \
--to=krzk@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=jun.nie@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®