mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: KY Srinivasan <kys@microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"olaf@aepfle.de" <olaf@aepfle.de>,
	"apw@canonical.com" <apw@canonical.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation
Date: Wed, 12 Feb 2014 16:48:42 +0000	[thread overview]
Message-ID: <6693126ee2ec4cab8de693b753fb987c@BY2PR03MB299.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20140212164157.GC22377@kroah.com>



> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, February 12, 2014 8:42 AM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the
> Freeze operation
> 
> On Wed, Feb 12, 2014 at 08:40:22AM -0800, K. Y. Srinivasan wrote:
> > If the guest has a FAT file system mounted, skip it during the FREEZE
> > operation. With this change we can support host initiated backup of
> > the guest even when the guest may have FAT file systems mounted.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  tools/hv/hv_vss_daemon.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
> > index 520de3304..6a213b8 100644
> > --- a/tools/hv/hv_vss_daemon.c
> > +++ b/tools/hv/hv_vss_daemon.c
> > @@ -87,6 +87,8 @@ static int vss_operate(int operation)
> >  			continue;
> >  		if (strcmp(ent->mnt_type, "iso9660") == 0)
> >  			continue;
> > +		if (strcmp(ent->mnt_type, "vfat") == 0)
> > +			continue;
> 
> Why should the filesystem type matter here at all?

As part of snapshotting the guest, we want to freeze all mounted file systems in the guest.
FAT file system does not support the freeze operation and so we want to skip these mount
points. For VMs on UEFI firmware, the EFI partition is a FAT partition.

Regards,

K. Y

      reply	other threads:[~2014-02-12 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 16:40 K. Y. Srinivasan
2014-02-12 16:41 ` Greg KH
2014-02-12 16:48   ` KY Srinivasan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6693126ee2ec4cab8de693b753fb987c@BY2PR03MB299.namprd03.prod.outlook.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®