From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpdh19-su.aruba.it (smtpdh19-su.aruba.it [62.149.155.160]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C76391D696 for ; Mon, 19 Aug 2024 12:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.149.155.160 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724071393; cv=none; b=pa+60DWETX4xtWTIeLhPRWaP1SDkT8fHJuaF4lQpuRG3byIwN+psGL79Br0TUc1g5Hj3wDQkTyCFo0W3TsSiH4RDrVbpNAq1vR2yrH2IZpBzWtqbALLGZnZ4jdCFRP9HVXFTkSIfxphLjbZJ+zlUOLzP5PdtW5Regfy5cVsExAM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724071393; c=relaxed/simple; bh=fCwrGowti2Y9FbC/WSwpnvpRmMD7BY8uWq1ug4s5oc8=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=k8u9vGgJbiJk+mULH5pWur6Djk5G6VOqymnGMK/s4/wQYETzIFXrvejg3TEqyXvc3a1ETRvup7mle+8rzEZUm+bjtp0LeMCbJKK1/7XyxBgzi40NTwCIcX/J0kWlsXnEuX0z+NiXE4P9+RE41Q1cBUWt3R0OYH6pVgO3S0Ds3UY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xhero.org; spf=pass smtp.mailfrom=xhero.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b=nJW55vb7; arc=none smtp.client-ip=62.149.155.160 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xhero.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xhero.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aruba.it header.i=@aruba.it header.b="nJW55vb7" Received: from smtpclient.apple ([84.74.245.127]) by Aruba Outgoing Smtp with ESMTPSA id g1g0s7h89GPpWg1g0sdU1V; Mon, 19 Aug 2024 14:40:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1724071202; bh=fCwrGowti2Y9FbC/WSwpnvpRmMD7BY8uWq1ug4s5oc8=; h=Content-Type:Mime-Version:Subject:From:Date:To; b=nJW55vb7YjZ9SvT5UohbI0ldLpGL7iTCUUl2BFPCDHyHdhx67JckO7U+YIjO9qiqi 1/n4hQ2Io27dp5IktOT6100XMkmiMUSaIpupCH8GgLv5qwu62UNZLJjsmuINMdElg9 QlyRxP02OelucC1HgynnPQPKdym6EQyFQyGcLF8jNueoJsGoKiv8DtsEKI/GFr2sYT t/QB9CO2RYTQPdABXVPSccdmcKt3GBbHfXbgMrzchnV5vPzlUQr+3KXyjvU2es7l9n /Vf+HuZPPocMqxz5i8HkkkmT4E6uqJ7SJSgUU7Pza4JxF0WT4TGPZqKdva5Um7EFVi G8sXyQ/2AWYww== Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: [PATCH net-next 2/2] appletalk: tashtalk: Add LocalTalk line discipline driver for AppleTalk using a TashTalk adapter From: Rodolfo Zitellini In-Reply-To: Date: Mon, 19 Aug 2024 14:39:49 +0200 Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Greg Kroah-Hartman , Jiri Slaby , Netdev , linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Doug Brown Content-Transfer-Encoding: quoted-printable Message-Id: <66CC3DF2-3877-4E59-924A-FA0B14AD4F46@xhero.org> References: <20240817093316.9239-1-rwz@xhero.org> To: Arnd Bergmann X-Mailer: Apple Mail (2.3774.600.62) X-CMAE-Envelope: MS4xfH4AXYnKIh2BVBscPttom5cXyZiRAjSs4ymV0/+jjynM3I2IRE/1MGshpfSSdbFowrwVfeP4DN6YlOMhpxI+Qi0PL2nobjWLqbHD+k5XaEaUJIN5Hkv/ r+wriLFaK+M+lRHfpnFyvnmbJwYBKhq+tJ2ZisE16PCdtNdQIBKiE4ACgeUglF1xWI+KABKWZ5EtKnL3Sp/gPyhhu3q1nurJGLf5kyfIm2pCHsOYzWXwJvgI mxPfBcCbVQ3ognRSsA/+dIY+PG/+lhqKbdk7wDpDkBNg4cwo+/H9/Bl2mj2d1Hz3gplnytcLLw7VuUn7QeMUmi0TSQvC8pGNs2bCTWBiZdyjMvXTXRscTKBn HnncabPcsQHXoxw1a9rEr1YZ0nNDhO8fPU6i+WQd1YNS2PbK3N4t2TR4r3YeB9WLDN+FNquZugPlhCHpr05JPysJOFZb7ZCXRD9BbwyIKIADYJBdz9qOy6BT ryPhz6s76O7rUGfiB2DwVZstHElf/BxjxDhdt85QoNMkVV8HquANl9PBL3Rfkv5VOn0+4fNluLdTdgbUPGglUaOOvBDKIlAL6x96GA== > On August 19, 2024, at 11:44 AM, Arnd Bergmann > wrote: > Nice to see you got this into a working state! I vaguely > remember discussing this in the past, and suggesting you > try a user space solution, Hi Arnd, Simon and Jiri, First and foremost, thank you so much for taking the time to review my = code and for providing your comments. I will do my best to address the issues and improve the code for the next submission. I will also add a longer description on why I went this route, it is = mostly due to compatibility with existing distributions of netatalk 2, which = can work without modification. > As we discussed in the past, I think this really should > not use ndo_do_ioctl(), which instead should just disappear. I will fix this in the next revision, I was not sure if I should touch = the appletalk code for my first submission, but I can add a third patch that takes care of this. Kind Regards, Rodolfo=