From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FCBC2D0C3 for ; Wed, 18 Dec 2019 07:14:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F42B206B7 for ; Wed, 18 Dec 2019 07:14:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="KYmT4pnK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbfLRHOv (ORCPT ); Wed, 18 Dec 2019 02:14:51 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:12067 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbfLRHOu (ORCPT ); Wed, 18 Dec 2019 02:14:50 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 17 Dec 2019 23:14:39 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 17 Dec 2019 23:14:48 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 17 Dec 2019 23:14:48 -0800 Received: from [10.2.164.84] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 18 Dec 2019 07:14:47 +0000 Subject: Re: [PATCH v4 13/19] ASoC: tegra: Add fallback implementation for audio mclk To: Dmitry Osipenko , , , , , , , CC: , , , , , , , , , , References: <1576613046-17159-1-git-send-email-skomatineni@nvidia.com> <1576613046-17159-14-git-send-email-skomatineni@nvidia.com> <7e49fef8-112c-1694-9316-7a23db8a01a4@gmail.com> From: Sowjanya Komatineni Message-ID: <66a28f8a-82e8-5b12-464c-4c91441d1511@nvidia.com> Date: Tue, 17 Dec 2019 23:14:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <7e49fef8-112c-1694-9316-7a23db8a01a4@gmail.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1576653279; bh=wEz6Ay8yiQe2GsVV1wxRrNco2RvygXF2+yfjYUns7fQ=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=KYmT4pnK+P+T6EgrAR8DilEBnQ4sf1uZoI0DjwAIIGozE9LvV3t18wMJMUp1ODUiZ YBx6CVnSAixFzeBVLhtPBHz3AM3uhLpcK4MbB4tkjfr9fFjKsCEbyeHERszl9YjS+d SFEY1Jc0KrvWj1c7hkbEIdcXtRatAxGrugDFx0Xux9Of+jT9burRmaHcryaOg3EkbC GF4CMb+haxcN+EPf2mc9hkj9QBLr8A3CX7wC+vp22ln9TdfhzI4oUCx/+7NuF5Qh6t jr6sRjJZEQDZl/7lwCJJDJ2+1SHM4PQxmhDamNF7WHvDsWZvmNlpV8CopekWVqP/J7 LqAOtMltQc+NA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/19 11:01 PM, Dmitry Osipenko wrote: > 18.12.2019 09:59, Dmitry Osipenko =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> 17.12.2019 23:04, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> mclk is from clk_out_1 which is part of Tegra PMC block and pmc clocks >>> are moved to Tegra PMC driver with pmc as clock provider and using pmc >>> clock ids. >>> >>> New device tree uses clk_out_1 from pmc clock provider. >>> >>> So, this patch adds implementation for mclk fallback to extern1 when >>> retrieving mclk returns -ENOENT to be backward compatible of new device >>> tree with older kernels. >>> >>> Signed-off-by: Sowjanya Komatineni >>> --- >>> sound/soc/tegra/tegra_asoc_utils.c | 11 ++++++++++- >>> 1 file changed, 10 insertions(+), 1 deletion(-) >>> >>> diff --git a/sound/soc/tegra/tegra_asoc_utils.c b/sound/soc/tegra/tegra= _asoc_utils.c >>> index fe9ca8acd0fb..1b88c6043082 100644 >>> --- a/sound/soc/tegra/tegra_asoc_utils.c >>> +++ b/sound/soc/tegra/tegra_asoc_utils.c >>> @@ -191,7 +191,16 @@ int tegra_asoc_utils_init(struct tegra_asoc_utils_= data *data, >>> data->clk_cdev1 =3D devm_clk_get(dev, "mclk"); >>> if (IS_ERR(data->clk_cdev1)) { >>> dev_err(data->dev, "Can't retrieve clk cdev1\n"); >>> - return PTR_ERR(data->clk_cdev1); >>> + if (PTR_ERR(data->clk_cdev1) !=3D -ENOENT) >>> + return PTR_ERR(data->clk_cdev1); >>> + /* Fall back to extern1 */ >>> + data->clk_cdev1 =3D devm_clk_get(dev, "extern1"); >>> + if (IS_ERR(data->clk_cdev1)) { >>> + dev_err(data->dev, "Can't retrieve clk extern1\n"); >>> + return PTR_ERR(data->clk_cdev1); >>> + } >>> + >>> + dev_err(data->dev, "Falling back to extern1\n"); >>> } >>> =20 >>> /* >>> >> [ 1.769091] ------------[ cut here ]------------ >> [ 1.769249] WARNING: CPU: 2 PID: 1 at drivers/clk/clk.c:954 >> clk_core_disable+0xa5/0x1d4 >> [ 1.769330] clk_out_1 already disabled >> [ 1.769459] Modules linked in: >> [ 1.769541] CPU: 2 PID: 1 Comm: swapper/0 Not tainted >> 5.5.0-rc1-next-20191213-00167-g6b9fbcdac8f3-dirty #266 >> [ 1.769676] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) >> [ 1.769775] [] (unwind_backtrace) from [] >> (show_stack+0x11/0x14) >> [ 1.769918] [] (show_stack) from [] >> (dump_stack+0x85/0x94) >> [ 1.770061] [] (dump_stack) from [] >> (__warn+0xc1/0xc4) >> [ 1.770144] [] (__warn) from [] >> (warn_slowpath_fmt+0x61/0x78) >> [ 1.770285] [] (warn_slowpath_fmt) from [] >> (clk_core_disable+0xa5/0x1d4) >> [ 1.770427] [] (clk_core_disable) from [] >> (clk_core_disable_lock+0x17/0x20) >> [ 1.770516] [] (clk_core_disable_lock) from [] >> (tegra_asoc_utils_set_rate+0x53/0x208) >> [ 1.770662] [] (tegra_asoc_utils_set_rate) from >> [] (tegra_rt5640_probe+0xd5/0x128) >> [ 1.770808] [] (tegra_rt5640_probe) from [] >> (platform_drv_probe+0x33/0x68) >> [ 1.770958] [] (platform_drv_probe) from [] >> (really_probe+0x14d/0x240) >> [ 1.771099] [] (really_probe) from [] >> (driver_probe_device+0x43/0x11c) >> [ 1.771187] [] (driver_probe_device) from [] >> (device_driver_attach+0x3d/0x40) >> [ 1.771328] [] (device_driver_attach) from [] >> (__driver_attach+0x37/0x78) >> [ 1.771469] [] (__driver_attach) from [] >> (bus_for_each_dev+0x43/0x6c) >> [ 1.771609] [] (bus_for_each_dev) from [] >> (bus_add_driver+0xe3/0x148) >> [ 1.771692] [] (bus_add_driver) from [] >> (driver_register+0x39/0xa0) >> [ 1.771833] [] (driver_register) from [] >> (do_one_initcall+0x43/0x1bc) >> [ 1.771979] [] (do_one_initcall) from [] >> (kernel_init_freeable+0x121/0x194) >> [ 1.772129] [] (kernel_init_freeable) from [] >> (kernel_init+0xd/0xd0) >> [ 1.772215] [] (kernel_init) from [] >> (ret_from_fork+0x11/0x34) >> [ 1.772349] Exception stack(0xde907fb0 to 0xde907ff8) >> > Although, that's probably related to the "ASoC: tegra: Add initial > parent configuration for audio mclk". > Actually I see these warnings of already unprepared and already disabled=20 for pll_a, pll_a_out0, and clk_out_1 even without this whole patch=20 series as well. I think its from tegra_asoc_utils_set_rate() doing clk_disable_unprepare=20 and these clocks are already unprepared and disabled so its just warning=20 from clk_core_unprepare and clk_core_disable.