From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011038.outbound.protection.outlook.com [40.93.194.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D27A221FB4 for ; Wed, 11 Feb 2026 07:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.38 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770796637; cv=fail; b=HQDy11ArNPt7flOwGddb2jOjd+2C2vsxnaO9BVxVpxKAJ4rMW52b38EaNbxgaXUGu7rq9AWulUSvObPHeYdCJ1O1WHpmPHtEHpA6dL7apYwE7Vuo1URZ7k2cGUfhClYVxgAHZVD6ia9XYPo03S9Q0Ag0hM5IgHWiiF4sihlSFPY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770796637; c=relaxed/simple; bh=PHUJiiKFgDqZONIp3g0irYvJerUM1Fe/yJDGMU/wm6Q=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=rvd6QWPJM8r44nVmAFKFgqN3fdJrN/JYun7Wtq4lkRSWzMhZj7FW5mPDgtzd7FJbbjKObTBJAjNNcPmZzDEDMZHFfy+u8ASQBa7uTxI71Gk9yN4R6nFQ7b8rqxpz2BS2+bSSPD1hgtUy5UlpdAjFnPZzxDNhpczUh11qkiAlFAk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=1bKrBkhw; arc=fail smtp.client-ip=40.93.194.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="1bKrBkhw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=I55e8PBhbhbSMpk16GlnRRwm8indaQS8Q/5jJ5uAveI7P8P/wUfsJwHLgy7waeDopnsLXC4cB3y73lOHfNV/Jt+hUj7RJt80MUSUJgSusLdryGNMSLYjT69ONDJQMe2+mwU4NfPI1MMK7oyBnbOVQj0xqfBzj+yIUbIRLVUM+LTz3ZPFlAdRtT439+NKS9DM2gTW955qASTl7IVJhFtFy9QbhRwWB1474AFm+2i/DfzOttwWDegikrL6BJPYRKKrCSYJS80d4xhkKb7zxXsLRm0trYXOrpfvW2I6Wxq/7OE1JLnBSpBHtCIe43gxv6HVv7dMUmi7d9xOQpaUonqMyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1wE0XbFF66rpbAaIc5K+Y53DOVJALKc3ZiQ5td0LqwY=; b=v+h1zRN3Xv8Q27IEvIWWhyWfYuU0aMsrlaOvQeS1tV5mejOMRQk20PP1JdFq5jNSkdNHcqJ7jsSpz3HL83pfDlNBIbN8akEWJAO/JSoqtQBeYlEURr7Rij1KotOGzPch34LnKBAlcTVpkd53a6svGtncdQ6qM75qpQR9wxUENUYwwEvSmby74fON9/q+JEq9aKBvQOTklornkh3bLM4FMarp9frQCsGHccV2af/L7sGx5hUL3J/N0UYCC/X1NL7mcZFyyfQSYGmhef20QbyJAYY+XdgLxIXKlm3f1gnKIUIrzfPcPqpmNERIhxRvh6wD5EmYITcC38TXh2XUVVLnOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1wE0XbFF66rpbAaIc5K+Y53DOVJALKc3ZiQ5td0LqwY=; b=1bKrBkhwpI8hO+CrPMEGLBm+JiD4GcpXlaZHptgVnaUb0DupoS2IRzS3sYFHySmHpGM3CTG3NKPoUAvgloild3gA8FKqz3575nrt4bn39Afnilj3AFewcoXHp2/M6DAg6xNpzxl55FCvu3YlN3jlnfs1QK/tuD7iqmFaIzJ+xGY= Received: from SJ0PR03CA0251.namprd03.prod.outlook.com (2603:10b6:a03:3a0::16) by CY5PR12MB6321.namprd12.prod.outlook.com (2603:10b6:930:22::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.18; Wed, 11 Feb 2026 07:57:11 +0000 Received: from SJ5PEPF000001CD.namprd05.prod.outlook.com (2603:10b6:a03:3a0:cafe::fe) by SJ0PR03CA0251.outlook.office365.com (2603:10b6:a03:3a0::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.8 via Frontend Transport; Wed, 11 Feb 2026 07:57:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SJ5PEPF000001CD.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8 via Frontend Transport; Wed, 11 Feb 2026 07:57:11 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 11 Feb 2026 01:57:09 -0600 Received: from [10.136.42.168] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 11 Feb 2026 01:57:07 -0600 Message-ID: <66a46fd2-d0cf-4f0d-9390-38df1dad886c@amd.com> Date: Wed, 11 Feb 2026 13:27:06 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] sched/rt: Move group schedulability check to sched_rt_global_validate() To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider CC: References: <20260119-sched-rert_groups-v1-0-80c1e5269910@suse.com> <20260119-sched-rert_groups-v1-2-80c1e5269910@suse.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260119-sched-rert_groups-v1-2-80c1e5269910@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CD:EE_|CY5PR12MB6321:EE_ X-MS-Office365-Filtering-Correlation-Id: 51f8f411-6503-4690-1e17-08de69432968 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|82310400026|36860700013|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TVRucW84NndPTnlQd3RERmhRQkZyZjBCeUVEWUxYWjJpd0VwUWtteFFCall1?= =?utf-8?B?a2EyeGcrUDJoUnFOQjd1aHVJRENiUFRTemY1bHRuU291WW9ob3kxczdJb1hQ?= =?utf-8?B?d1AzcUpXbTYxUnJlMHY0N1NWcUZiaElCeFNpdnY1Y0tIODVadmJFZ3dxSzV1?= =?utf-8?B?bEx2dy93c1BGUWttVWcxMVZYdXZlRU53R3MyVnlsLzVSWU9MVzVSRGtmUStn?= =?utf-8?B?bE9zWStvd2RCV2JYZHhSdUU4em5wNkhyMjJsQ0Fia1VmZm5xb3A2cE1jMXRv?= =?utf-8?B?TkJBYWRqZFBCUUlzR3RSUGw1YThFSTJPTUJ6NXJwQU9vd1Z6aWVsNUZlRDk4?= =?utf-8?B?ZmNGaDNmWE5kNHcwTUJERXUvdEtJM3d4V3g1SitYUDF5bjgyTDBBMHU1a0Vx?= =?utf-8?B?cDQ3QVhqc0IyU0FQOEZyV05PbjVaYnUzVnE3bVl4YUpnNnJxUEhWc0RON2xU?= =?utf-8?B?dm83dms0eWpwT0VOR0dGaXVtcU9uVEZ5eUQzaVpGOXBvMDdWNXcvVkFXTEdN?= =?utf-8?B?Zm5KYTAzcitqQ2VVMGgwY0VleWVLUEthcEc0dTJDdGprWXlCR3JpaUNDTXVk?= =?utf-8?B?OUc1NDU0cW02NVRDZk9SaVgvN1FwbC9mWUxYci9QNUlHWTdQdUtOVGpvY3Ft?= =?utf-8?B?YnZReW05NXdDL0dPdnhvR0tzS0RJZnRZZm5GMnJuT1NlbytTeTBIV0V0Rnpp?= =?utf-8?B?MmdCd0xBNiswWVIzTWxyQVJnSUpjanJGTkk2SEFtTUFjMm1yb0hSazJqaDNx?= =?utf-8?B?WkZleGYyUDMrSXBKUEZQd0MxRDBLeFp2QVNmMVhhTC9yVXRxU0ZsZmlqSDN1?= =?utf-8?B?VXQvaU1QeFRwejZGcFJrc3hhUXMyVUhGQndBN09RSGh3QmtBRXEwaVdtcVNp?= =?utf-8?B?RjdCeU51VkQ5TzFVZzBndG45Q2tMaU93L3N2ejFnQVQzZDNDMUg3eHg4Nnll?= =?utf-8?B?Y1pib1NtT3B3ZWwwYmdnQzZ2NnVkZjVITlphRVNSa0NJVXZDVVgyV0M1bTdH?= =?utf-8?B?Z2d3VE5oK2dvd095MGV0REFEb2FaOEtzR0RuVFFHclcwTG14bHN4YjFrOGxi?= =?utf-8?B?bEpCbnhIbDV0TmxNVnFmakxhcVg1MzVXRWpRVHhOTXRWeTBMYWNQdmJNQ2hH?= =?utf-8?B?Qk1WNm9MbmZOajM1SzRQVFovNkNlY3pSeUpMTUhRL1BSMGpGd0ozMTRORTEy?= =?utf-8?B?QW95VWdhWFhRakp2Vy9HNW82Rm1NL0hzbFIvRjZBdUpWUWFuTDhRNnR1a0Nn?= =?utf-8?B?NmdBVU01c3VhRnRMZEJSVzIxUzZTMTQyWS9LOVI1ek9PUjV5K2NLdU03WXRS?= =?utf-8?B?VTI1bWlNMitsUGFFbkxoZnZva2FObjRpSVNMMEhGU0c4ajV4UU45RmtFZTJT?= =?utf-8?B?Q1pqT1RKb0tKRmE4cUZRK0FlZHlCR1R2aHJ0U3RpdGR4MXhZMUpsTjBYcjJj?= =?utf-8?B?WmdrWjZVbmZYOEIzbW8zUzdxT3hNcld1RWZvWFNTT0Ywa0NhWWo5N09QeFl3?= =?utf-8?B?VWUwelRvbEM5eWZEWmFQOGsvOU45MEhyU0hBZ0MxQThTR0F2R1lOUTBXakl3?= =?utf-8?B?a2JxUHJHNnUxVXdQUi85V2ZkalFzdG9QVjNVbCs5bktMc3lDbFVlZ2MrRll2?= =?utf-8?B?UGRQUUppR1NlOEtGZVcrRHdqRlFuK3ZGVUUzRDFXNXJVZVZBc05nMGNQTEdY?= =?utf-8?B?TU5kaG55c3o5OU11QnJqcmxPajk3VGtIT2FzRmNxZTlRVzdzNzJsaEtaa3N3?= =?utf-8?B?bnJkcU1kaXBXYndFWkRIaEZZQThScHdScVBUT0t2M1N3WkdoUDRZWHBCaGZr?= =?utf-8?B?UDltN2FNYitGTDM0TGdtSzhBOG9mTHRyVVA1REZ3NXZwV3hEU2ZxUnBZK0dr?= =?utf-8?B?VllVeHA0T1BCRlBzOWV5OGwyZTNXZCs5TDAxTGYwNXBoSjVaY3JxUXN1b2ZM?= =?utf-8?B?blRUdUxTMS9VK3Fwc1hJM0NXN1Fod2dyMlpoWUJnWGY1SXBjQ0pXWDEzZ3Bs?= =?utf-8?B?Nk1NczVUZ0phZmNIWWVNcEZLSU9wQ3ZnOWx3RVRlYXNIRjFPNm12WUdLSGdK?= =?utf-8?B?VmdMRVdPY0FwNUlqYUgwTXRZZWI2amhDUThWVkl1VExOQXdwelVQSnhlZHEw?= =?utf-8?B?S1VvNjFuajFWWHBVNjk3Q0RpWXNqc1dUbjZIUlJmT1ZmbEV6MXdrQ0pLVnZw?= =?utf-8?B?R0NRVGx4REw2Mk1TY0tidURrVzlCcWpBQUFkMy91K29uRWl2c1hkckZMV2dw?= =?utf-8?Q?eWVDv6JVxTRdc7KUSeivN+dA8xrxg1r7zHI6NZtl5A=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(82310400026)(36860700013)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: B55WsXeTnVzQYIt0WDFxSGLUn6tOeNqK3PtV8DkBs/9aX6vkI7+rrkQ/RCoZXL8tfgWQK8Hu999TfYC4BazgRXe16d01NTpwja2PUz5eH/AAQHCxpplGXSzsRjQDwkpGjXvx+fbpghIELAdnThohTTCjJwFp4i+fb/93SwwliVfuCkUxjBYlHas8YpYlxAuQIiJmYL3ZDx7uB/QUzQ48yUXpNRDHrBtSDBtfKFhs8PAsbj/+mH4E94AgZ61hfm0coTbh0z6u+mRUTN7/T2M6/g+ST3WqAxwF6HbyehDwjrjAb39d5zCwh5zlqCR5KicgYKWF1cc8SKep4uUrXArTbmsx41w0L+Puts0rr+I9n+ZEImTP4bdP71CfdLLFMPn8ULLVSuy6Shai1GvfA0eqgOpH96cihru0oekmwHU1GGQqd6Uoml5sC+6W5ejStL1H X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2026 07:57:11.0265 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51f8f411-6503-4690-1e17-08de69432968 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CD.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6321 Hello Michal, On 1/19/2026 11:11 PM, Michal Koutný wrote: > The sched_rt_global_constraints() function is a remnant that used to set > up global RT throttling but that is no more since commit 5f6bd380c7bdb > ("sched/rt: Remove default bandwidth control") and the function ended up > only doing schedulability check. > Move the check into the validation function where it fits better. > (The order of validations sched_dl_global_validate() and > sched_rt_global_validate() shouldn't matter.) > > Signed-off-by: Michal Koutný > --- > kernel/sched/rt.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c > index 2dfdf2d9471be..c621e61568359 100644 > --- a/kernel/sched/rt.c > +++ b/kernel/sched/rt.c > @@ -2810,15 +2810,7 @@ long sched_group_rt_period(struct task_group *tg) > #ifdef CONFIG_SYSCTL > static int sched_rt_global_constraints(void) > { > - int ret = 0; A blank line after the definition would have been nice in the previous patch but I suppose this is transient. > - if (!rt_group_sched_enabled()) > - return ret; > - > - mutex_lock(&rt_constraints_mutex); > - ret = __rt_schedulable(NULL, 0, 0); > - mutex_unlock(&rt_constraints_mutex); > - > - return ret; > + return 0; > } > #endif /* CONFIG_SYSCTL */ > > @@ -2850,7 +2842,16 @@ static int sched_rt_global_validate(void) > NSEC_PER_USEC > max_rt_runtime))) > return -EINVAL; > > - return 0; > + int ret = 0; I'm not a fan of the additional ifdeffry here but if we must, the "ret" should either go at the beginning of the function, or you can get rid of it entirely by ... > +#ifdef CONFIG_RT_GROUP_SCHED > + if (!rt_group_sched_enabled()) > + return ret; ... returning 0 directly here ... > + > + mutex_lock(&rt_constraints_mutex); > + ret = __rt_schedulable(NULL, 0, 0); ... doing a scoped_guard(mutex, &rt_constraints_mutex) return __rt_schedulable(NULL, 0, 0); here and ... > + mutex_unlock(&rt_constraints_mutex); > +#endif > + return ret; returning 0 directly here again. > } > > static void sched_rt_do_global(void) > -- Thanks and Regards, Prateek