From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbdEJLa5 (ORCPT ); Wed, 10 May 2017 07:30:57 -0400 Received: from mail-bn3nam01on0086.outbound.protection.outlook.com ([104.47.33.86]:31648 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752046AbdEJLay (ORCPT ); Wed, 10 May 2017 07:30:54 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH 0/3] GPU-DRM-Radeon: Fine-tuning for three function implementations To: =?UTF-8?Q?Michel_D=c3=a4nzer?= , SF Markus Elfring , Alex Deucher , David Airlie References: <74d2df52-f509-e6d2-5b35-e25b7cbd1fbe@users.sourceforge.net> <799fb921-f620-9054-680d-90b14e4c517c@amd.com> <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4@daenzer.net> CC: , , , LKML From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <66a88c64-cc8f-45ed-81c6-f7e2947f1f18@amd.com> Date: Wed, 10 May 2017 13:30:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8c4e7dde-06d5-3f13-2322-f661e9d3dbf4@daenzer.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:dc86:7f84:5bb4:a9bc] X-ClientProxiedBy: VI1P190CA0030.EURP190.PROD.OUTLOOK.COM (10.165.188.171) To DM5PR12MB1306.namprd12.prod.outlook.com (10.168.237.149) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93fafcc5-dfda-4d24-a1df-08d497980428 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;3:wGxzowOrxc4XU3I/L0qc+ABFTMf6dOZ2N6XxmzPuBBabzIRdV8zBnthO8zlSAXBpNCrvsUs/yXgjGm1Vi1oRY7JxiT9qjTyzVCiiiPWYx2FRwLj26cDKsWBDvECZ0Cx++WkXJvaUrIsUnDYB6U1J/QzUlWg6w70dOSivbOtQOkjleW2dqSqepNqqdYagRcLpYWSODw9sJWLazJWfYzSINhXlt3fp0I450Uxvh8xZM/5pFf8AKB/keARPQngzthpQgvG4af22SFAkxl1hXlzeLplZRRe0Sq3fz59BziadwfKhvy1h6C0Jnyhv/0gQtn80Aqt1KYO/gzLYyAedzB1cFftTMcPmg+H2gla0+CLPGrY=;25:NuKnKbtVaS77ZuzEGtv7J97D8myxZ1T8SxH2v4OhNTfQAM8H+aU+0C0x5HD4gmzWuHrsE2XD+Jy/AlFulz0KxExE+7TYFx6mKEgpiWzxAj9h0/jZ4HWeoDHY0cO0e8VVVB11oVGTBAlvdprl5I6JnI5LkKn4sXli5IKpwZT5ptlFehh+FEaH7vcGxl/kpLfSDad8QzMl+25dAVKHj3eHnD6judE4Y440w/+w/G4l0p+0eya710Ki3Xnc/ZHYwL/3U4ruzMMVpcRRvnOILGBJqzwVJmdz/LPxr20UmPG6KugfNhqVIieUiWK9fGEu51DEF/mSX1MKDlC0W9hZQ7WwOfNz++ev9Tf7+FYHfNHXLHSDxhl20boKmn/OO920+Pn0HdhQC6CXT/xfnirzMqO+ubMThir2sJ+JaRmznqylqqqSDnlMJqA+i3lw4B7vh9NO09yXNw5T1bqwiPjn90/R9X7drYTvp96tN2TCPHz8Kzw= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;31:fRDq6YaTGw1LwAE43dNSynMSSrFpYCKkqHyduyp7mMXHteDtn31p/S5ivkTb4bqS6cOIl43swEpug1WG+pHCtpQau/HIau/N4zMLkghnITPH9UCKfj9tquFWUG4GSKxeazdI7bLLBwvvDFxE6YO/Q7rJHC/URXtEB2aUSHVcedyyb4f3OUkypR0LoaSRg2+8UUAbbPYr5ffsWm8Ldy/pKSP7RmNE0GLUtr/ko8E9TzcNrBmRSipJKjrLl4OePWSt;20:TvezjYCCdTRmUucVn8w2K07GBGGT8ipnOTv3olr+8rZfMZL9oCeuNaqdKbAJStKK9KZLYr89xuM3kByA3GAxbtg5Pbz5Hcb6ulUw0nHizZ/nejBIbaMNPiLe3+RUKzey9ZBMGu+ws/wv1huDOkbCHX6SPiKrAMFCeVD1XGq4w/c+MPvoQ2TLKz6id0J/uHqgTcmhG8HV3DHOWN26ZvoO1egPxr30kRt+POiqDcPINWNozYXW6vuipCvRJabMckKKAnOysZrR1InupOQgLzz2KK+HhmGlrU7Tn3zMK1aU5gIaGKSkJPGNApa84ITMfj+C70rsXr1kNoBh9oMYsuCWIG9fdCBwDgwu4zaF4CjA5xVWyAKsr6p25vc3cqgMXAIwCXLA35I6ReLYZMV868AcHeDkyAedKTdt2JZ6tqbcGnYstrgcebP7yroxWgb9tBJ+aRh2dHeO8u7cAZQdWYm7whpcTvFL+rVKe2gYR1FDM/UfQnN+Os+TVIoQm5Dr3ZDP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(42262312472803)(217544274631240); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(6072148);SRVR:DM5PR12MB1306;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1306; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;4:sp0XsTNnd/rJrHNsnkSkD6obyyo+q78vPOJ2TBaqQzxt0bn04/sfJeMU/8zQAXeA+sLFwvlbiN6V5YslEElcwg4CKyl1ouFZRk/8/kweOsIw80u8e5MG53LM8ppzHS/iBgLqvDJRKUu8qUR9G/hfEXJ+jNdD8Y9Xkt5WrFoa+hyiDC0GMaQM8yowuW3HtNc3XlTqbAGfvFjnDJweHQsNIZDC3A2ukRMpv4wFFoONm4uGF4Jmlq7ZrxkXUlvc0/i0c41a7jftsvOpzfoEPN7xFTEi3+O2lLeTorUp9l0kQlUXXORcK/PGa6EsQkUdGCZ12ik9PrvThbJHRCICOjRetZWiX6zpTptsjagFEMdehCaz0lNb7JqiS6MU9tDQKr+dHdEbC9Jw4AlxE5noHBq9Ml5Q+CnGutt8g5fX5GwmbAHxGbumSl+IGKSgUyyy6ne5iP0u0s5dIHYWQ+3Otv21JV1/8Hc+MNxM1tnXVjAl6KXCDaWUUHRhLqdbESSSS+iGRJnY4RedLkvhWbu7RKDDNnoM/fGKgW05xIvh1yPc2HDPHxpYPdWLUWQmfFH/G3IXlTvVckOIQvUFtrbY9g3l7SJtqpqMJzFEFLZczoIr6KMKSiAK+ukz9iMbYeeiVrJFnfxFUGpAeeK18eXHPD5WdJrjL7BKtsZyI9wu2bTgK+jKhhuBiEDpZBGY5jO0JDlIjEx1tz8sri0xxaeRm7Hi5z0gtPNvj5vA5pa0m19+V490f7RSsq1OPwvqPnwV2plPd72odGF1fgR1NW+UDpvte9W5N7CBzb0MiUvbTHCSueahyK4bjEWTMNWiQySthv9Lznd9a00OST476LHIFFvoBJcG2uWU6NWYJJPnJuf5SrjgoPA4PmRGlCnpbmQcH8yhZRiMPJgi2iry7xR7kr1JUapIfRKPJSUDE8rRlSNK8cA= X-Forefront-PRVS: 03030B9493 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39410400002)(39860400002)(39840400002)(39450400003)(39400400002)(39850400002)(377454003)(24454002)(83506001)(23676002)(47776003)(2870700001)(65956001)(50986999)(76176999)(53546009)(53936002)(36756003)(54356999)(5660300001)(6486002)(72206003)(8676002)(38730400002)(64126003)(4326008)(50466002)(6246003)(65826007)(305945005)(54906002)(81166006)(478600001)(33646002)(2906002)(25786009)(7736002)(42186005)(189998001)(2950100002)(4001350100001)(6306002)(229853002)(31696002)(31686004)(86362001)(230783001)(6666003)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1306;H:[IPv6:2a02:908:1251:7981:dc86:7f84:5bb4:a9bc];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMzA2OzIzOldSQTQ2WitkZFJqcUVHd0lONWJWaWdBNnd3?= =?utf-8?B?eG1UUHFnSEdaVUR4MWVtSE5vRVNYS2pJRHJhMno3UWdvQ2F1MEYzN2YwaGxw?= =?utf-8?B?MU15Q0NpaFhHcWc3UmJzaUQzNXEzK3YzWUtzUWp0emM4aU9KdGEyQ1o1V0s2?= =?utf-8?B?aXB0eURiT1JJR0dSdklkbDdMTlNwTkQ2UHFRMk9FbEJ3NWlFNkswMnFwa0VK?= =?utf-8?B?ZHREajBMT1BGUlU5eERIT1J4TC9rUmNmbEpHVTJ2dnV6LzVjRS9rc3Rvb2V4?= =?utf-8?B?L21SU0xNWU9DWXRoaEpDL0hRNDFhZnF4L0FTU29DbVJTR2JUemEyZVkvMW1J?= =?utf-8?B?NURxYlZJbUd0MXdXM08yYXFURWg4SDhuNkFlZGwyMEdiVXJkN1VvandKVmRy?= =?utf-8?B?NStRN1paWlpYZjRZTlArcDhEVUFuRU5ISEoxejdka21Kd2t2RmJ5cGo1aU5V?= =?utf-8?B?SzVucUQramcveE9KemhKTVRndDBheGJhRWtzUzZTakxFZlI3T3dqeWQ2Z0ts?= =?utf-8?B?UEdadS85TUU3Vk1tWXNTQ2JzMS96S2l0U1h3cXFvUkY5ZnJId0xxeEhkRFpY?= =?utf-8?B?S3ZUT2RBUzViVyttSy9VWHd5OGRaT3lMUHYzTHBBeUF4MmJ5T0lkNFlyaGNP?= =?utf-8?B?S0RvVU1OM1BGVU5JWnl4YkVVMVRmQnRSQnRwY1BDMGZ2TXBzU2k4OE8xVisw?= =?utf-8?B?ZEttV3ZEZEtoeU1zMzVpR25rSzEzL0MrT0F6YnF3Q2ZtdmZyWHBBREhObEhi?= =?utf-8?B?UXN4elJHNmFBUSt2SFhZQWo0L3Vyd3E0UkY4TUJpdkJJVGdsaG9OdW1PcHBH?= =?utf-8?B?bE8yMHBmVnBERUQ2S1FWaktUTFBpc0l5cW52emgrdC9GWGVKdjlvcmxzN283?= =?utf-8?B?T0p5cVJNbHRTNDd4anYxL01WeDlmRmdrQnJ0M3QvaXBNSUxSMDVhaXBXRi9v?= =?utf-8?B?WjVNcHNKYUIwYzhkdDEwWndObDAxa1lBaG1WQmdmN2Z0YWxHQnQxZ2tMMkEw?= =?utf-8?B?Z3YzdyswRURDRHdsdE1aUm1tZC9nZDNDT0FBYTNJR0VtVWFXSmdzYzdyWklD?= =?utf-8?B?dVB3c29sbytHSmRnb2NvMzkrYXBZVlJIV0hoQmVtYTE2ZklpZVU3WkFQMDMy?= =?utf-8?B?TGx6RFJGRzh6Vk1HeDk3VXFubisyeUtaSlJmZFRyQWNORm9QcnBxZmU2Uitm?= =?utf-8?B?bkFOdE1XYWFLdHFScFkwMmlXZldxOWRvT3AwVEZUZVVOdVY3QTZCWkZ2a3dD?= =?utf-8?B?S1J0enhoU0ZOTDZsanhra2hsekxGUjNUb25EN0VzYkhBcE9mMzU4ZHMzS3ZN?= =?utf-8?B?RWFza3I2dkxXZEYrMUFzR1RHR0JLSWY1UWVrSmJaVVB2U01KemZZVWNBWnNy?= =?utf-8?B?M0lZeGpjTXpoN0VsVnFRMklNZmdzRHVSekI2Rk5jTUlNeTlscmtTeVA2Q29L?= =?utf-8?B?dFZHOFNHVlZZc3lYZmdiZGZyVStGVGJ0U1Jwdnltcko3WmtEOTM5ZzZOU2lL?= =?utf-8?B?QlErM3F5VHpEZCtrSzlyVDF3bFdDN25HZ1NHam1XOGUxakp1U3dVYUszWTVR?= =?utf-8?B?dVBwamVwa2ljZU9PWlQreHpoMEUrV3RmWG9IVVZ2SjNFTFN0b2Qvd28vL2Fl?= =?utf-8?B?QzZ0Sk5jTUVjTDFCdzlvS1JCVGdGVjlQcXd5ZG91cDVudGRjbkMwNmtYM2Vy?= =?utf-8?Q?Z1V1v/lY+tGMsRlsV78X47QrtzJc62ztTqgPJ5E?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;6:u0lEu9RpRor2xKAssqWTvaTo8jg2UDnEXurU0IJtegSFPgvFMkmRJN7PIHg2ect1prh1j8HfetO+07rhEKo2QFi2NSKUtYfn04xredS7MrlOzs+kBG7T0m3L2yP5/ZyIP5u1GUbxLCiIsZqX+2r1q/99epSpO4pUkzH/ayAVBpsCksn6PaKu/bj9PoyFe4LZT3StoTXrd5o1ct0C1DvgeZ6mazluHTIEogxZ9c3EygCQkuucZywvLgVek7qr/xiNwsvZo79DCHjDEMeongC3+SKZdEh4Qzj7Fi/t3Zi7Ylns2JdosF2zkqLwx7OfgEww2wQuv6xSQ9hxTGUeEKiHa1bMlzz0g528Wgj/Q1zNI5WualdxWFkfejPZIrUO1NsTjTedVTthSJKMI4/DCbHGO9m+iSlybxuh/MzYDsiFnLNimLxA1wWNFeNKlEzRRN8tMWCHciSpACE6eW7rEnnoic38V9eflXh8DtFQTrun5y3x9UosGNjXwCn1iarzeRpdBHEBPz/IZ7a0Zr0r1330pmXRLtbQ0nO3f422lWf94EQ=;5:/sOW6DPUnV1EFFJ2PFHNc0Mj2gDJhiIRe+HowF41xiFUPmlh4gnPCZ4zYFVEpTwzYtM40vSVYhKNiY856ZamSz6Q7JpYQ8PqHeyPimtlI3o5W16rvHAJuwoHFixWFM+cxfNautyq6xp/b3CmNMmtrA==;24:HGsnKZ3AWwApovm8F0oceHppZd72lEIDk2ogpO5EFOe6eH7W9jsB6ye2qKomR0Qo90tdBDppZbjAwlPJOAuysqEMVmsQs35yoZNar7Pc23E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1306;7:/t0FSJoCsQNxBl/Pqjl6G7V9JscCzynncae7HWjma82kGnEF3yrnPk7XFcLWnwJm0fSk19z/aVBUTgALY12gv8b7PojrBm621wcO+lbRuTJfUC/R54iRnc/YVr0hQBTkhwxAyU2xlrVpLQEADuEMpMoeQsdxSkuleMdkoY0bfNcAGHTPzFdu2Xutlcrc8txb4WurWzqEG53sXAZCT4sAfLaeZeF6NZaWuOek/veZJoHp8f4R6Ut236tvr1I3TZzGWhJqtui9ZUcigp14uWYwSNB+rMCuAtoQCBJ0kYSW/Sa6VnqLYcrpjJ2h2KaYrUoVSYWzhwcsn3UHLpRr9Au4Fw==;20:GmtQMSJRVB54PHbx3RgJZzs5LbFbZZkcV60dUrJ/uvN/xdqxj+6JwSuLq3X6e7rcvjFqybmoGQjCrrKSpNiMfa39O/4vXbI2ZTJF/fIRDu3K1+x+uB/koj82ZG6kAMXrv+kgX/ZpTIMpwxLjmrU5r14HxcX4I3ZBKyZpR/sNpZHctAFFoRlwwIfA1tgv+E7qIM9eH8DKnJfVVug3rUDsNfnyRehmRmmsjLlwxP0xH62lsRvdT9N6+DhGwM73gy6f X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2017 11:30:51.0293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1306 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 10.05.2017 um 02:23 schrieb Michel Dänzer: > On 03/05/17 09:46 PM, Christian König wrote: >> Am 02.05.2017 um 22:04 schrieb SF Markus Elfring: >>> From: Markus Elfring >>> Date: Tue, 2 May 2017 22:00:02 +0200 >>> >>> Three update suggestions were taken into account >>> from static source code analysis. >>> >>> Markus Elfring (3): >>> Use seq_putc() in radeon_sa_bo_dump_debug_info() >>> Use seq_puts() in radeon_debugfs_pm_info() >>> Use seq_puts() in r100_debugfs_cp_csq_fifo() >> Reviewed-by: Christian König > Based on > https://lists.freedesktop.org/archives/dri-devel/2017-May/140837.html > and followups, I'm afraid we'll have to make sure Markus' patches have > been tested adequately before applying them. I can't judge the background of that decision, but at least those tree patches for radeon looked trivial to me. I don't see much what could go wrong when merging them. On the other hand you are right that trying to find hardware to test that stuff could be challenging. Christian.