From: Fenghua Yu <fenghuay@nvidia.com>
To: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>,
James Morse <james.morse@arm.com>,
Ben Horgan <ben.horgan@arm.com>,
Reinette Chatre <reinette.chatre@intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] resctrl: mpam: Fix potential per-CPU data leak on probe failure
Date: Fri, 20 Nov 2026 12:23:54 -0800 [thread overview]
Message-ID: <66ab6c3e-de92-4a22-8c72-c4f8df118cb7@nvidia.com> (raw)
In-Reply-To: <20261120173519.3923924-1-liguangshuo@mail.sdu.edu.cn>
Hi, Guangshuo,
nits:
Subject: [PATCH] resctrl: mpam: Fix potential per-CPU data leak on probe
failure
1. s/resctrl: mpam/arm_mpam/
2. s/data leak/memory leak/. Without this fix, there is no "data" leak,
which means information is disclosed, right? Not freed memory is memory
leak, I think.
On 11/20/26 09:35, Guangshuo Li wrote:
> The PPI device IDs are allocated separately from the MSC. If subsequent
> resource discovery fails, probe destroys the MSC without freeing its
> per-CPU allocation.
>
> Use devm_alloc_percpu() so the device releases the allocation when probe
> fails. Its cleanup remains valid even if the MSC is freed beforehand.
>
> This issue was found by our static analysis tool under development.
>
> Fixes: 49aa621c4dca ("arm_mpam: Register and enable IRQs")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <liguangshuo@mail.sdu.edu.cn>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Thanks.
-Fenghua
> ---
> drivers/resctrl/mpam_devices.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c
> index c067b6d57d71..3e89f9183041 100644
> --- a/drivers/resctrl/mpam_devices.c
> +++ b/drivers/resctrl/mpam_devices.c
> @@ -2351,7 +2351,7 @@ static int __setup_ppi(struct mpam_msc *msc)
> {
> int cpu;
>
> - msc->error_dev_id = alloc_percpu(struct mpam_msc *);
> + msc->error_dev_id = devm_alloc_percpu(&msc->pdev->dev, struct mpam_msc *);
> if (!msc->error_dev_id)
> return -ENOMEM;
>
>
> base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
prev parent reply other threads:[~2026-11-20 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 17:35 Guangshuo Li
2026-11-20 20:23 ` Fenghua Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66ab6c3e-de92-4a22-8c72-c4f8df118cb7@nvidia.com \
--to=fenghuay@nvidia.com \
--cc=ben.horgan@arm.com \
--cc=james.morse@arm.com \
--cc=liguangshuo@mail.sdu.edu.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®