From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D245882899 for ; Wed, 4 Mar 2026 09:32:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616774; cv=none; b=eBGMk3QxDt4Pf9pm/RJdcJ951kSpgDwRnRDPlxtMoHe2WjwRMNYoGiW2qQXLl1yl8ZdWPL5roSItNjbhykth2VPrfXR959tjUBP34rwT+PeEshynSFE78kCLYh1jW6v1ZeyQ2FBgec6/AanrNIq2wQpIHmDIkXRjdcva5AYdsog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616774; c=relaxed/simple; bh=Z/eJE9wFLrz8E+sUg7CGHUvq6+8QleCiP7NDH8UwBIY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=VEmRdcy9ZqHMsdpZNs6/+a5R6Ez9iUNU6BbpdjEjA32bRpktg0NjzPjQmspkDKLxaZNHrXOpfpVWDeVeOP9pGrOWgMz6QEq1cr2C7qpPgxxZDSZYr5Kxyrx8583vNhtIYPn1MS/N6Arhon1/+8ps3DzGhbwTYgNHkxL24ktnnEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dDo55Ke0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TirpKM9g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dDo55Ke0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TirpKM9g" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245TK671679436 for ; Wed, 4 Mar 2026 09:32:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bx3wpMkjZfdqRG0nPg8aof67AqNz/1s49xLwUjoGMng=; b=dDo55Ke0HYDMNGzK +Jd7adVzH9AX56D2xTbafJZMtcDuD5PGwkIkzA6vZMc2IbTDxxxgk82FDLqwC4qs Sp45f9qA6q1a8fVr9UkP8uros5vORMnWQkbiN4iGy/Ddri3/kaQg8VlDCXEfT3Jp lfvCp932loKgmRCSloII/3AVCV9relFNZp2W0CALOlwanIlTXv6xXBxSpn81neoX pH+IbzrPc4HNcCNqJsWij9UuKM84ma9gdlTjRwaZSPsjpshjK+2k4BkKvqmHTFc3 +xHnFNn8C8PNpNbKBlibogvyS1I4dRucwMm/4bjsqKD7Xh7iKoVv5tyxpYrx5RsT i0o/0A== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp73ha8x9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 09:32:51 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a174bd442so48014546d6.2 for ; Wed, 04 Mar 2026 01:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772616770; x=1773221570; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=bx3wpMkjZfdqRG0nPg8aof67AqNz/1s49xLwUjoGMng=; b=TirpKM9gKYGT6qKkkWcx967quXrlmoDWK1Ooe7bHj6LzwAUKwGVSgrwuT62o0vWSZG L71lC9n2I5ehd/HkKN+R9juRBLVt5EDmYQcpfVU4hsdoFynCboEaaLxBZRlxGrWeg5W6 tIRoHIbbfAPuLQVoARnmjyBw6uNRrpuZe+94enYMdKhPmUirTMQiayzYGBHZKvBRjZbD bVEpRIb7ZlozFj0MiufGwidMhh2kiT3Cb/tZ3KvalPOToR0JKHqIaUFYHwukn8qIrH38 dNOiOn/VBU7vWjatPyEWaWjJFOJtaBtRScf6+qSQXm92/a2Ny6qaN2HR+U25taQUQmvv nKsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772616770; x=1773221570; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bx3wpMkjZfdqRG0nPg8aof67AqNz/1s49xLwUjoGMng=; b=jV1phN1WD0hdJIGYca0MhJcymDejAkXO6T6pk9BMEjAASPX5a1C50ztLL7Ep40u2i/ V3u6VrRClcI1if0RnNtz7Jjga4ZV/48OcRA9xsbjz3Gv7N/MOS1rxX/gIWTKX77r+mpD botiQmQDikA9X+jeSltLNqeW7hjcs1821iPJrgq+WCyCo9XQdsbwKICRTSnGH1lnaylh VCLvISAI2WwNAW4h/DCXqFyrHOx+/tCybphUI6tPpVQO4R9C3XPKHZWZrJTJGo4AM2Ag XAEqQv+9fKYzxOLHbClY9z4XYKTSN1r+AsiSy0Gru5j4CiZV4rQdL24ohh7hzbMJz+Yt o1LQ== X-Forwarded-Encrypted: i=1; AJvYcCV9ZjjruQZwP6yTPMAyX9dAMdcHdPPfC1NO57u9eyE3W/KIbez8bxqkfXEO3NM7apwpZj/pi4X+77mr5HY=@vger.kernel.org X-Gm-Message-State: AOJu0YwBLqOp2d4WFaPWSdsXZxX7beM9h131K/FmmwGIQRREiNVQRAIb LX/Kb9VnGD+i4Gy92KeMlmC9YpIaAMB46PucBvi2nQjfGoBezKVDlh2hq8xeOePTCngaKoziAsf Xnfd1Icv7/x1Neq4ApQAX+iNn+xigXcRfHHeFSKjmU7M4i5I1t+wanSy6xy4IR5DD6sk= X-Gm-Gg: ATEYQzxzcdvS6DkdN/XIRoBAIwygrHI5HAKHkLbtZbs/CfwgiUVcQnwDlOeQd00R8RH i4mcZ2Z4Hn6jH61XVbktp89HkLJ348/kfwPXf+U8wgr1QWtQ5wwk+gM9R2dPLi0FlcgoIeq0he7 LAK1MRzaMv6MquOLgYUrSEovmH72NPrSn0AM8BgoWN/jQVdS4cznCwNnXpI/tdlK6eCYxmTTUJK VuV9FI4fshtdn5QWYQAe7iO5UP+2JTW9lVaF8pFmamGuGnCiPITpEUmjYGEPEGr8oNkRUhWpzjA 29YPRG65J3k1Vt/AU/0kokpQ5rg/QOyjIPA0EiPl9L1Wu9WJhAfRPRbE84LLI/obkf2cRBYuob/ q0YDr4ub8mWQkaUjh4dYGl6fGOxLdHRqmEKARKeoB6KIlPpAcJkAxxsJiH4RUVcbrWI5k51wRDu wlwf5KdJ3ZN4BqwMrX8/i/9iJ3/BI5VD2LWWlllvBvYr/fBbm7GjuvnF2rSLI+5s+hZi9Z9LM07 tZAN3CxPnkKL6Zw X-Received: by 2002:a05:620a:4406:b0:8b2:e5da:d317 with SMTP id af79cd13be357-8cd5afac71bmr157118185a.54.1772616770368; Wed, 04 Mar 2026 01:32:50 -0800 (PST) X-Received: by 2002:a05:620a:4406:b0:8b2:e5da:d317 with SMTP id af79cd13be357-8cd5afac71bmr157117085a.54.1772616769914; Wed, 04 Mar 2026 01:32:49 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-660bf4d8249sm1168978a12.17.2026.03.04.01.32.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 01:32:49 -0800 (PST) Message-ID: <66ac63ff-7369-4683-b802-5f5d30f3f530@oss.qualcomm.com> Date: Wed, 4 Mar 2026 10:32:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH v3 1/2] platform/x86: int3472: Add TPS68470 board data for Intel nvl To: Arun T Cc: sakari.ailus@iki.fi, sakari.ailus@intel.com, sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com References: <20260130092431.2335363-2-arun.t@intel.com> <20260302174644.1258718-1-arun.t@intel.com> <20260302174644.1258718-2-arun.t@intel.com> Content-Language: en-US, nl In-Reply-To: <20260302174644.1258718-2-arun.t@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kopjiBnaVudeIjTgDsHqEvuKAZhM7DiY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA3MiBTYWx0ZWRfX7ZFrsIxLnOX6 TyqP/8zY44HOYszJYRu8jAJsgDME30ZPW8skgG4kEnJa7muoI1ilQXy8KFqoh3g0GNqnvsGDhAm oq4lnx6PIt5sewYfZL6iuHVY3XCAufc4XlRXKG5QJI59Yfjo0apJXI05tz9gEe6fAoHtID2uAgq vq/g3HWw1Zp7ENN9KWk6yDVMKmo4IzeCbiXo5058OsvqLPKOwcFHVh73HVPNDqOM/GcFjBKm/b0 GG4FbxQVsYmOFoPjtBdKiOTbzTrPQ4yAiRISGzu1ynVTl2L6ld0U2l3E0t211mj+XJrPxMhRCsh uN7UeFXy1WaOZmAwXP+IjjsHLwbfM80svT+zHCjhUo/zymXpBN6ImP3tyjc/D4MbboKq8Gz2rnf hXXpJAK4CNaM4M0K+sI3p/Y01sH986yRVopmDmOwUmdiNUnGrSL4wD15xdAuxicKc9yjJRCOExt cnXeO62DEJK3juOeNew== X-Proofpoint-ORIG-GUID: kopjiBnaVudeIjTgDsHqEvuKAZhM7DiY X-Authority-Analysis: v=2.4 cv=BpWQAIX5 c=1 sm=1 tr=0 ts=69a7fc43 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=QyXUC8HyAAAA:8 a=e0fhDsDLZYdukTk1vE0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040072 Hi, On 2-Mar-26 18:46, Arun T wrote: > The Intel NVL platform uses IPU8 is powered by a TPS68470 PMIC,requiring board > data to configure the GPIOs and regulators for proper camera sensor operation. > > Signed-off-by: Arun T > --- > .../x86/intel/int3472/tps68470_board_data.c | 150 ++++++++++++++++++ > 1 file changed, 150 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > index 71357a036292..1efc0f8e9ba8 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > @@ -143,6 +143,34 @@ static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { > REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), > }; > > +/* Settings for Intel NVL platform */ > + > +static struct regulator_consumer_supply int3472_core_consumer_supplies[] = { > + REGULATOR_SUPPLY("dvdd", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int3472_ana_consumer_supplies[] = { > + REGULATOR_SUPPLY("ana", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int3472_vcm_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdd", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int3472_vsio_consumer_supplies[] = { > + REGULATOR_SUPPLY("dovdd", "i2c-OVTI13B1:00"), > + REGULATOR_SUPPLY("vsio", "i2c-OVTI13B1:00"), > + REGULATOR_SUPPLY("vddd", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int3472_aux1_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdda", "i2c-OVTI13B1:00"), > +}; > + > +static struct regulator_consumer_supply int3472_aux2_consumer_supplies[] = { > + REGULATOR_SUPPLY("vdddo", "i2c-OVTI13B1:00"), > +}; > + I only noticed this v3 after replying to v2. As per my comment on v2: https://lore.kernel.org/linux-media/0f2502fb-20cd-4638-8428-9a9eb5318147@oss.qualcomm.com/ this is still wrong. Regards, Hans > static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data = { > .constraints = { > .min_uV = 1200000, > @@ -220,6 +248,82 @@ static const struct regulator_init_data dell_7212_tps68470_aux2_reg_init_data = > .consumer_supplies = int3479_aux2_consumer_supplies, > }; > > +static const struct regulator_init_data intel_nvl_tps68470_core_reg_init_data = { > + .constraints = { > + .min_uV = 1200000, > + .max_uV = 1200000, > + .apply_uV = true, > + .always_on = true, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3472_core_consumer_supplies), > + .consumer_supplies = int3472_core_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_ana_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = true, > + .always_on = true, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3472_ana_consumer_supplies), > + .consumer_supplies = int3472_ana_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = true, > + .always_on = true, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3472_vcm_consumer_supplies), > + .consumer_supplies = int3472_vcm_consumer_supplies, > +}; > + > +/* Ensure the always-on VIO regulator has the same voltage as VSIO */ > +static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = true, > + .always_on = true, > + }, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = true, > + .always_on = true, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3472_vsio_consumer_supplies), > + .consumer_supplies = int3472_vsio_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_aux1_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3472_aux1_consumer_supplies), > + .consumer_supplies = int3472_aux1_consumer_supplies, > +}; > + > +static const struct regulator_init_data intel_nvl_tps68470_aux2_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3472_aux2_consumer_supplies), > + .consumer_supplies = int3472_aux2_consumer_supplies, > +}; > + > static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = { > .reg_init_data = { > [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, > @@ -232,6 +336,18 @@ static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = > }, > }; > > +static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pdata = { > + .reg_init_data = { > + [TPS68470_CORE] = &intel_nvl_tps68470_core_reg_init_data, > + [TPS68470_ANA] = &intel_nvl_tps68470_ana_reg_init_data, > + [TPS68470_VCM] = &intel_nvl_tps68470_vcm_reg_init_data, > + [TPS68470_VIO] = &intel_nvl_tps68470_vio_reg_init_data, > + [TPS68470_VSIO] = &intel_nvl_tps68470_vsio_reg_init_data, > + [TPS68470_AUX1] = &intel_nvl_tps68470_aux1_reg_init_data, > + [TPS68470_AUX2] = &intel_nvl_tps68470_aux2_reg_init_data, > + }, > +}; > + > static struct gpiod_lookup_table surface_go_int347a_gpios = { > .dev_id = "i2c-INT347A:00", > .table = { > @@ -258,6 +374,23 @@ static struct gpiod_lookup_table dell_7212_int3479_gpios = { > } > }; > > +static struct gpiod_lookup_table intel_nvl_int347a_gpios = { > + .dev_id = "i2c-OVTI13B1:01", > + .table = { > + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), > + GPIO_LOOKUP("tps68470-gpio", 8, "s_idle", GPIO_ACTIVE_LOW), > + { } > + } > +}; > + > +static struct gpiod_lookup_table intel_nvl_int347e_gpios = { > + .dev_id = "i2c-OVTI13B1:01", > + .table = { > + GPIO_LOOKUP("tps68470-gpio", 7, "s_enable", GPIO_ACTIVE_LOW), > + { } > + } > +}; > + > static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = { > .dev_name = "i2c-INT3472:05", > .tps68470_regulator_pdata = &surface_go_tps68470_pdata, > @@ -287,6 +420,16 @@ static const struct int3472_tps68470_board_data dell_7212_tps68470_board_data = > }, > }; > > +static const struct int3472_tps68470_board_data intel_nvl_tps68470_board_data = { > + .dev_name = "i2c-INT3472:04", > + .tps68470_regulator_pdata = &intel_nvl_tps68470_pdata, > + .n_gpiod_lookups = 2, > + .tps68470_gpio_lookup_tables = { > + &intel_nvl_int347a_gpios, > + &intel_nvl_int347e_gpios, > + }, > +}; > + > static const struct dmi_system_id int3472_tps68470_board_data_table[] = { > { > .matches = { > @@ -316,6 +459,13 @@ static const struct dmi_system_id int3472_tps68470_board_data_table[] = { > }, > .driver_data = (void *)&dell_7212_tps68470_board_data, > }, > + { > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Nova Lake Client Platform"), > + }, > + .driver_data = (void *)&intel_nvl_tps68470_board_data, > + }, > { } > }; >