From: Andrew Lunn <andrew@lunn.ch>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Diogo Ivo <diogo.ivo@siemens.com>,
Roger Quadros <rogerq@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org, srk@ti.com,
Vignesh Raghavendra <vigneshr@ti.com>,
kernel test robot <lkp@intel.com>,
Thorsten Leemhuis <linux@leemhuis.info>
Subject: Re: [PATCH net-next v2] net: ti: icssg-prueth: Split out common object into module
Date: Thu, 6 Jun 2024 17:54:18 +0200 [thread overview]
Message-ID: <66b917d6-3b72-41c5-9e30-e87cf5505729@lunn.ch> (raw)
In-Reply-To: <20240606073639.3299252-1-danishanwar@ti.com>
> +EXPORT_SYMBOL_GPL(icssg_class_set_mac_addr);
> +EXPORT_SYMBOL_GPL(icssg_class_disable);
> +EXPORT_SYMBOL_GPL(icssg_class_default);
> +EXPORT_SYMBOL_GPL(icssg_class_promiscuous_sr1);
> +EXPORT_SYMBOL_GPL(icssg_class_add_mcast_sr1);
> +EXPORT_SYMBOL_GPL(icssg_ft1_set_mac_addr);
> +EXPORT_SYMBOL_GPL(prueth_cleanup_rx_chns);
> +EXPORT_SYMBOL_GPL(prueth_cleanup_tx_chns);
> +EXPORT_SYMBOL_GPL(prueth_ndev_del_tx_napi);
> +EXPORT_SYMBOL_GPL(prueth_xmit_free);
> +EXPORT_SYMBOL_GPL(prueth_ndev_add_tx_napi);
> +EXPORT_SYMBOL_GPL(prueth_init_tx_chns);
> +EXPORT_SYMBOL_GPL(prueth_init_rx_chns);
> +EXPORT_SYMBOL_GPL(prueth_dma_rx_push);
> +EXPORT_SYMBOL_GPL(icssg_ts_to_ns);
> +EXPORT_SYMBOL_GPL(emac_ndo_start_xmit);
> +EXPORT_SYMBOL_GPL(prueth_rx_irq);
> +EXPORT_SYMBOL_GPL(prueth_emac_stop);
> +EXPORT_SYMBOL_GPL(prueth_cleanup_tx_ts);
> +EXPORT_SYMBOL_GPL(emac_napi_rx_poll);
> +EXPORT_SYMBOL_GPL(prueth_prepare_rx_chan);
> +EXPORT_SYMBOL_GPL(prueth_reset_tx_chan);
> +EXPORT_SYMBOL_GPL(prueth_reset_rx_chan);
> +EXPORT_SYMBOL_GPL(emac_ndo_tx_timeout);
> +EXPORT_SYMBOL_GPL(emac_ndo_ioctl);
> +EXPORT_SYMBOL_GPL(emac_ndo_get_stats64);
> +EXPORT_SYMBOL_GPL(emac_ndo_get_phys_port_name);
> +EXPORT_SYMBOL_GPL(prueth_node_port);
> +EXPORT_SYMBOL_GPL(prueth_node_mac);
> +EXPORT_SYMBOL_GPL(prueth_netdev_exit);
> +EXPORT_SYMBOL_GPL(prueth_get_cores);
> +EXPORT_SYMBOL_GPL(prueth_put_cores);
> +EXPORT_SYMBOL_GPL(prueth_dev_pm_ops);
> +EXPORT_SYMBOL_GPL(icssg_config_ipg);
> +EXPORT_SYMBOL_GPL(icssg_config);
> +EXPORT_SYMBOL_GPL(emac_set_port_state);
> +EXPORT_SYMBOL_GPL(icssg_config_half_duplex);
> +EXPORT_SYMBOL_GPL(icssg_config_set_speed);
> +EXPORT_SYMBOL_GPL(icssg_send_fdb_msg);
> +EXPORT_SYMBOL_GPL(icssg_fdb_add_del);
> +EXPORT_SYMBOL_GPL(icssg_fdb_lookup);
> +EXPORT_SYMBOL_GPL(icssg_vtbl_modify);
> +EXPORT_SYMBOL_GPL(icssg_get_pvid);
> +EXPORT_SYMBOL_GPL(icssg_set_pvid);
> +EXPORT_SYMBOL_GPL(icssg_ethtool_ops);
> +EXPORT_SYMBOL_GPL(icssg_mii_update_mtu);
> +EXPORT_SYMBOL_GPL(icssg_update_rgmii_cfg);
> +EXPORT_SYMBOL_GPL(icssg_rgmii_get_speed);
> +EXPORT_SYMBOL_GPL(icssg_rgmii_get_fullduplex);
> +EXPORT_SYMBOL_GPL(icssg_queue_pop);
> +EXPORT_SYMBOL_GPL(icssg_queue_push);
> +EXPORT_SYMBOL_GPL(emac_stats_work_handler);
Please could you clean up the namespace a little. icssg_ and prueth_
are O.K, but we also have arc/emac_rockchip.c, allwinner/sun4i-emac.c,
ibm/emac/, and qualcomm/emac/ using the emac_ prefix.
Thanks
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-06-06 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 7:36 MD Danish Anwar
2024-06-06 10:34 ` Thorsten Leemhuis
2024-06-06 15:54 ` Andrew Lunn [this message]
2024-06-26 7:19 ` Thorsten Leemhuis
2024-07-12 11:12 ` Thorsten Leemhuis
2024-07-12 11:40 ` MD Danish Anwar
2024-07-12 12:08 ` MD Danish Anwar
2024-06-26 7:37 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66b917d6-3b72-41c5-9e30-e87cf5505729@lunn.ch \
--to=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®