From: Bibo Mao <maobibo@loongson.cn>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: rafael@kernel.org, linux-acpi@vger.kernel.org,
acpica-devel@lists.linux.dev, lenb@kernel.org,
linux-kernel@vger.kernel.org, lixianglai@loongson.cn,
loongarch@lists.linux.dev, maciej.wieczor-retman@intel.com,
pawel.chmielewski@intel.com
Subject: Re: [PATCH v4 1/4] ACPICA: actbl2.h: Add bit constants of the Flags field in the IOVT IOMMU structure
Date: Thu, 5 Nov 2026 17:50:17 +0800 [thread overview]
Message-ID: <66b9d482-d577-748c-729d-0fba70701d3d@loongson.cn> (raw)
In-Reply-To: <CAAhV-H5k8EJrAuqPH44y_+1gcXGCjCoozzK5ii9cLtiLDj5eog@mail.gmail.com>
On 2026/11/5 下午5:31, Huacai Chen wrote:
> On Thu, Nov 5, 2026 at 5:14 PM Bibo Mao <maobibo@loongson.cn> wrote:
>>
>>
>>
>> On 2026/10/23 下午3:59, Huacai Chen wrote:
>>> Bibo,
>>>
>>> Now I have applied this series but with some modifications, please
>>> double check and test the code.
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/log/?h=loongarch-next
>> In my v4 submit, it is:
>> + case ACPI_IOVT_DEVICE_ENTRY_START:
>> + is_start = true;
>> + start_devid = ep->device_id;
>> + break;
>> however in rc1, it is modified as:
>> case ACPI_IOVT_DEVICE_ENTRY_START:
>> is_start = true;
>> entry->start_devid = ep->device_id;
>> break;
>> Here entry is not allocated and NULL pointer, it is allocated in
>> ACPI_IOVT_DEVICE_ENTRY_END switch case.
>>
>> I really do not know what is aid to modify it and let others to test.
> Sorry, it's my fault.
>
> In theory I should point out the modification (eliminating the local
> variable start_devid) and refresh a new version. But we have no time
> to do this because when the first patch is merged into the ACPI repo
> it is near the merge window.
Maybe our work style is different, I do not care much for the coding style.
>
> If you agree, I will submit such modifications to fix it.
fix is welcome.
>
> diff --git a/drivers/acpi/loongarch/iovt.c b/drivers/acpi/loongarch/iovt.c
> index 87cee4f0fc80..4cdac28a1fd0 100644
> --- a/drivers/acpi/loongarch/iovt.c
> +++ b/drivers/acpi/loongarch/iovt.c
> @@ -115,6 +115,10 @@ static int __init iovt_add_iommu(struct
> acpi_iovt_iommu *iommu)
> for (i = 0; i < iommu->device_entry_num; i++) {
> switch (ep->type) {
> case ACPI_IOVT_DEVICE_ENTRY_START:
> + entry = kzalloc_obj(struct iovt_device_entry,
> GFP_ATOMIC);
There will be memory leak problem if there are START/START/END in the table.
Regards
Bibo Mao
> + if (!entry)
> + return -ENOMEM;
> +
> is_start = true;
> entry->start_devid = ep->device_id;
> break;
> @@ -122,10 +126,6 @@ static int __init iovt_add_iommu(struct
> acpi_iovt_iommu *iommu)
> if (!is_start)
> break;
>
> - entry = kzalloc_obj(struct iovt_device_entry,
> GFP_ATOMIC);
> - if (!entry)
> - return -ENOMEM;
> -
> is_start = false;
> entry->end_devid = ep->device_id;
> list_add_tail(&entry->list, &np->ep_list);
>
> Huacai
>
>>
>>>
>>> Huacai
>>>
>>> On Mon, Oct 12, 2026 at 3:16 PM Bibo Mao <maobibo@loongson.cn> wrote:
>>>>
>>>> This change is already merged in acpica tree.
>>>>
>>>> slightly ping.
>>>>
>>>> On Tue, Sep 22, 2026 at 08:10:55PM +0800, Bibo Mao wrote:
>>>> > According to the IOVT specification, define macros for each bit of the
>>>> > Flags field in the IOVT IOMMU structure.
>>>> >
>>>> > Link: https://github.com/open-acpica/acpica/commit/352f750e4cc0
>>>> > Signed-off-by: Bibo Mao <maobibo@loongson.cn>
>>>> > ---
>>>> > include/acpi/actbl2.h | 7 +++++++
>>>> > 1 file changed, 7 insertions(+)
>>>> >
>>>> > diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
>>>> > index baef525367b5..76e4a5bc79b4 100644
>>>> > --- a/include/acpi/actbl2.h
>>>> > +++ b/include/acpi/actbl2.h
>>>> > @@ -919,6 +919,13 @@ struct acpi_iovt_iommu {
>>>> > u32 device_entry_offset;
>>>> > };
>>>> >
>>>> > +/* Masks for Flags field above */
>>>> > +#define ACPI_IOVT_IOMMU_PCI_DEVICE (1<<0)
>>>> > +#define ACPI_IOVT_IOMMU_PXM_VALID (1<<1)
>>>> > +#define ACPI_IOVT_IOMMU_MAGAGE_BY_SEGMENT (1<<2)
>>>> > +#define ACPI_IOVT_IOMMU_HW_CAP_SUPPORT (1<<3)
>>>> > +#define ACPI_IOVT_IOMMU_MSI_INT_BYPASS (1<<4)
>>>> > +
>>>> > struct acpi_iovt_device_entry {
>>>> > u8 type;
>>>> > u8 length;
>>>> > --
>>>> > 2.39.3
>>>> >
>>>>
>>
>>
next prev parent reply other threads:[~2026-11-05 9:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 12:10 [PATCH v4 0/4] ACPI: LoongArch: Add IOVT table support Bibo Mao
2026-09-22 12:10 ` [PATCH v4 1/4] ACPICA: actbl2.h: Add bit constants of the Flags field in the IOVT IOMMU structure Bibo Mao
2026-10-12 7:18 ` Bibo Mao
2026-10-12 7:20 ` Huacai Chen
2026-10-12 14:47 ` Rafael J. Wysocki (Intel)
2026-10-13 8:39 ` Huacai Chen
2026-10-13 12:00 ` Rafael J. Wysocki (Intel)
2026-10-23 7:59 ` Huacai Chen
2026-11-04 8:30 ` Bibo Mao
2026-11-05 9:15 ` Bibo Mao
2026-11-05 9:31 ` Huacai Chen
2026-11-05 9:50 ` Bibo Mao [this message]
2026-11-05 10:31 ` Huacai Chen
2026-11-05 11:23 ` Bibo Mao
2026-11-06 14:58 ` Huacai Chen
2026-11-07 1:45 ` Bibo Mao
2026-11-07 12:25 ` Huacai Chen
2026-11-09 1:12 ` Bibo Mao
2026-11-10 3:39 ` Bibo Mao
2026-09-22 12:10 ` [PATCH v4 2/4] ACPI: LoongArch: Add acpi_arch_[late]_init() Bibo Mao
2026-09-22 12:10 ` [PATCH v4 3/4] ACPI: scan: Add support for LoongArch in acpi_iommu_configure_id() Bibo Mao
2026-09-22 12:10 ` [PATCH v4 4/4] MAINTAINERS: Add entry for drivers/acpi/loongarch Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66b9d482-d577-748c-729d-0fba70701d3d@loongson.cn \
--to=maobibo@loongson.cn \
--cc=acpica-devel@lists.linux.dev \
--cc=chenhuacai@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lixianglai@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=maciej.wieczor-retman@intel.com \
--cc=pawel.chmielewski@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®