From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbdJaLh5 (ORCPT ); Tue, 31 Oct 2017 07:37:57 -0400 Received: from mout.gmx.net ([212.227.17.22]:59459 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbdJaLhz (ORCPT ); Tue, 31 Oct 2017 07:37:55 -0400 Subject: Re: [PATCH][V2] net: ethernet: slicoss: remove redundant initialization of idx To: Colin King , netdev@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171031100823.19733-1-colin.king@canonical.com> From: Lino Sanfilippo Message-ID: <66baa4b6-7588-501e-4ad7-e0617329ac4e@gmx.de> Date: Tue, 31 Oct 2017 12:37:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171031100823.19733-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/T/96btNMJGY6Bs5S6iVUco+MWnpYtm+H/xOav8wQXFPvJ6DF9N s0hEpDk1kXOemoUZdxderg4IQKuvqVMicObA0SOXoAtwIpDwjC3E56FG6lK4TL5Re0C8gDk SDxiZ7ObAulzjYhMSpbDDYEoESEoyG7QqqnPEzaIGVgSIP2x8I6mKQXxkpe1CFD1QRI6f+5 6A8MRYh+D5dQLhofhOVbA== X-UI-Out-Filterresults: notjunk:1;V01:K0:+dfWma2PEq0=:8rC5BddujT2UzCcE1xeCiY zmOR5vWtJKmt1Bt9sbH/Cj40qjvY1xzY8j2IqHH4eF38rUCDI5447+rYZUW0oQ+HEtujWmWzz yCFoGYtbsAtr0x6aFbahYfMywUidLhXTSYxtD6d1lgAN/R31V1c6Vti248kOwj35ao4x+E9TW dPBoSz++d7JkpIsl6z9h2QU+cdD5+EGJofnV2K8SFT2vhLk6KcIJ2U0DCJuVfYPWvXHex83R/ jkga117VAyf9DI2jkmOLdAuSc379UHD2JxVnswcKFfN7+3mvEwNf44OHDbyPcoqeZ3+PJ1a40 2zWk2TvndpBtlo8fzEXLHprnEQK7eZg/hnjfh7riiUG/6u516MDvQct/vSTpt6dvX1cdr89RW 7XJ6fJy68PBldnmNZwdAB2on6Q/kCKxsGJjFUeS75qIjgNcp7jtoV+zZga6bVP2WEFgEll6PE fhdzif/AYtSG9qrtZ+GoCtu7XRyHa/aAiI885pkp/Sjw57JC2BLEElZiq1klhtIvvz+vRxJIv YlysrleVX/c7B9eXKF2YsrEe/qyKfTaj+l9ybpyyFHqwPTuJalgej1AaK+gjwoXUO2jN8Ab1n nvE0K48n6A2nX0H3H/8MhNfrKL0VY2vZidT0JAxqo232KWFH1uQrJkpm08v5btq/7ShfcwEP9 /zyT0hM7u6ZDdbFjhLL4eaXvaz77/K1xxbJRV2ZZRkRV28EfS1vhEmSWVb/szGsQZt3yxmSml VbmO1KhHv0K/42oG2LiGz5umsVUr+GnxWnyzSH7YqGoG0ABf/H/1oiXlXjxzsOE7NUWAWKyjt zLvf9T334/al46sPNpFyResKW8989J3qVK34q7F/5Hu1PVBPT4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31.10.2017 11:08, Colin King wrote: > From: Colin Ian King > > Variable idx is being initialized and later on over-written by > a new value in a do-loop without the initial value ever being > read. Hence the initializion is redundant and can be removed. > Cleans up clang warning: > > drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value > stored to 'idx' during its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/net/ethernet/alacritech/slicoss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c > index 15a8096c60df..0b60921c392f 100644 > --- a/drivers/net/ethernet/alacritech/slicoss.c > +++ b/drivers/net/ethernet/alacritech/slicoss.c > @@ -355,10 +355,10 @@ static void slic_xmit_complete(struct slic_device *sdev) > { > struct slic_tx_queue *txq = &sdev->txq; > struct net_device *dev = sdev->netdev; > - unsigned int idx = txq->done_idx; > struct slic_tx_buffer *buff; > unsigned int frames = 0; > unsigned int bytes = 0; > + unsigned int idx; > > /* Limit processing to SLIC_MAX_TX_COMPLETIONS frames to avoid that new > * completions during processing keeps the loop running endlessly. > Acked-by: Lino Sanfilippo Regards, Lino