From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752637AbdL0Vjp (ORCPT ); Wed, 27 Dec 2017 16:39:45 -0500 Received: from mout.web.de ([212.227.17.12]:62396 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964AbdL0Vjm (ORCPT ); Wed, 27 Dec 2017 16:39:42 -0500 To: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Viresh Kumar Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] pinctrl/spear/plgpio: Delete two error messages for a failed memory allocation in plgpio_probe() Message-ID: <66c3f488-ffdf-e55d-e511-e4af35e670b4@users.sourceforge.net> Date: Wed, 27 Dec 2017 22:39:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:I8YhgGcgqIddi29d2ypx5oknAmUxMd/zxEl0LSG3ireSIEgz6W9 wGQn5OWepoi184AfcivJNah48PHwu/oUGZ8yU2YBKUc9xOXnEJpZ+Ylb2d89c12sD19zKbe kviIfOv7UHXKIh20uc3j+NuqKOubXwjfD3EX9jzcduWCfrJyR1XLSap/Uv4zsANHwXc67it B0SMl3X4G37p2AzthK7tQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:QG3ymbSif2g=:plsR67/Msx5ZF1y07xyXJj 9soCizdL3JqdtE5RRt0Zwl1fO95vStnEhzfzokOfS3owhKE8hK+zA657XwrFPcDhv+9+bYS9p PCfBluN+pn83o+K4rc5BoBwQ9rJOsh+LJnbtigRzGOOLDGtTzHQNjhspAd+7w5uTlp6T5y3Ga yAbea6hxyBk/gn2jzB+hWqSY+GjR+RAmMkeWmaUcbBkJAeXOxRXkFgR6SJrtS2lqov1r4AmZb hffAzx3ETpxgNl/crAtB3LwaQgDUNQ0ECChP+xxMfqn94DVc+Mpr1VhCNyLs2S5W9E3bvG05Q aHzqBUWKFf0yQBPu/9dZqj9JrifdoyroAT70sdAxCRMqdTPvYlpUjalt/GzTkVH54FAlYQRir qgQKddTH/E0HBy0erRlropohEBo5+eHJWp13pNeWsq0YPRVxoXoxFwmDpELv9p5vZ/zFTe9Px jtOY2oCMq7fE8Eh4Bs0i4qTHUhFAbUMFCGUernIKpda6f2Sk8DLJ1Dh3C93KS0xNvX0lxHSZc tReijThEyMq5THhlQfAKm1L/f6wWm49ayQ73Yx2J3nuruvEE9UtwIwO55OBFXvOEq0Gl4DB9x sLNZXL2icY8Pxh8M9drYtPlNQz72ZYA7B/HSOlgt20/XNTqEfVZcYcv5/d/fwxmn6FJO5v3P0 aPORQV7sMSIFyzcScUURl9purK1ELgkoIAZe0RD0JgPidEmt8RU2PO+kU89fJmvN07o+9ERzf 7LnPDgLU1/uvzVAI4PnoA0hiesYdSIguCoHTsonJQg9eF8k8CAE+hjFixliruzouYtrunWNAZ HkH8hzLq6K3aPwp3t7IW4cFYlrtniRtC5QdzmSAh970Dk0btq8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 27 Dec 2017 22:34:28 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/spear/pinctrl-plgpio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/spear/pinctrl-plgpio.c b/drivers/pinctrl/spear/pinctrl-plgpio.c index 6a0ed8ab33b9..d2123e396b29 100644 --- a/drivers/pinctrl/spear/pinctrl-plgpio.c +++ b/drivers/pinctrl/spear/pinctrl-plgpio.c @@ -519,10 +519,8 @@ static int plgpio_probe(struct platform_device *pdev) int ret, irq; plgpio = devm_kzalloc(&pdev->dev, sizeof(*plgpio), GFP_KERNEL); - if (!plgpio) { - dev_err(&pdev->dev, "memory allocation fail\n"); + if (!plgpio) return -ENOMEM; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); plgpio->base = devm_ioremap_resource(&pdev->dev, res); @@ -544,10 +542,8 @@ static int plgpio_probe(struct platform_device *pdev) sizeof(*plgpio->csave_regs) * DIV_ROUND_UP(plgpio->chip.ngpio, MAX_GPIO_PER_REG), GFP_KERNEL); - if (!plgpio->csave_regs) { - dev_err(&pdev->dev, "csave registers memory allocation fail\n"); + if (!plgpio->csave_regs) return -ENOMEM; - } #endif platform_set_drvdata(pdev, plgpio); -- 2.15.1