From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 913A11A0BE0 for ; Thu, 16 Apr 2026 01:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776303191; cv=none; b=VkrugoiL6ig/Yffg8AKCSJlw6jKt4OYsi5dwRLGRj0KaesqoxeSyUuRb/YNSbno0j6sFXni0638pF9w1tBTQ25S5kaNeivzbD5QfIQPo7s+bHDeJe8vktMu8kC4hpBv5+z+2qq3WfcW+xH7KDnjYO2qPVQ2E3m796sk9uPs28qo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776303191; c=relaxed/simple; bh=AOZHD46fIdmc34xi+MIwFHy+MZfZB/Lnlnu/aks3xw8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u2fefmM3Wkch8dJGEl/3DLH/n4LsvZvwKpm+KkL2JSNjdt5URw/UTme5KMD9VXDyiD+pMDzz5Cc8j9nKGrj+Gd5bTtjy0igZyLlLQTEyxUXTEv/v/f2UCOzmsmsEm1yL0im6FHT4Z4aMCMnZQd8TwT98abkx6Mh+fKP2vvZ58hQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XI+Ft3ub; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XI+Ft3ub" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35da2d35eccso5458571a91.0 for ; Wed, 15 Apr 2026 18:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776303190; x=1776907990; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aQgdNunScoEK1wjg3coA/JSZQspmY6ZwsZhqd+cVzz8=; b=XI+Ft3ubHjiKpOcYQIKDID5v3DtWuHt+ZA6ZRlavwpDqCh96Nf1aJruzL+MglOhPzr 7r41xhAf+Pf6WFEoS50QbgUEpL17XfdZb0xP0QdutFP99JzFJsXkJWwlf99aIghcMqH3 kidtnog55g7P2f+70890B/BzInzCybyghxWma5fCc0QUBI0h4+hAkfkPr4k/hJ0k4qpn HjhJdPfNcCgaSJao0fR0rE714kDJ+xS1/dMt9KhSIBxYieyyvrMcvqUcv3Iz7efNsExZ pRCm42ZsCdINIpoL8NKCKQFgFVV2YTBEnG/V0z229jkAvs8Kn6OwrUu6mn7OSoTDu5xA T+vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776303190; x=1776907990; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aQgdNunScoEK1wjg3coA/JSZQspmY6ZwsZhqd+cVzz8=; b=dU/FgddhKk67LP3z6YyQV5wHFWZU1zvw0oD/TtoUToa5+ozjrDq5sioEXYfYd1flpz FHBTA8tFMG6dny8siJE1yZXdpwOHkZACSMgET+qCzLsC0vc71UQ+Qpb+H1b7UGxaN+A4 OFVQN8CEBnbmTOo5394n4yL6jXPgLtYk4rv0ZfKNezGE+EqIh0g1ZlQym7h/zkph+1hM UiAanjSRvXjIwNUQNettNTlfkyqmlzc7WVxXacvF1ML8GMDbhj8Ryvw3jzzTBobaTDYW 6vDjkr7xyJcjxaMAD5J2h7C3CQke9BpapT6Y/4NI9LjLi9KW1vmUqwKfLW7hdt9j+Gkg iG0A== X-Forwarded-Encrypted: i=1; AFNElJ8uvMW3gi1RjWws9r5UegnEvcx7I/kVIUYnxGIkiDe1YAOqA7GN+TyW9khqvGcNonwwZJ5O+lI5BQ4quC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+vArLwgX9H1l5mfY7Gc7YCfeIH/ZoQJES5aeRtRUMZJWviJgV szMgjleJQpso8Dte3dI9w4GftL+wypQcOODO6runH579GSHTA4nM5Kfs X-Gm-Gg: AeBDievReCaw7IrJTqGh4kuqGORRVXec22cl+GSBKvEGYWTNt58al02Owe8yEk5TT3u LhL1nY78CNEXhBlH6GjijTc3UljR3teL5JlU0xF5YxrxNeOoegvMWgfRZvs5L4ODaaX33bi3KsU DG/lGuV5OxtY1uk1P+ET3siv2IoX0U4b91ZPT7QKRkWZh4PtMRlVIzVk3KDyj86wa7vRnmpYTEF cJebhJ1GOnKgm5B3V28TBz801jP5g/9y4Cma95zFVL1+conkuCj4aa8OiQEsXR8uai0FAj+2Qdv ySi31QlFE0haaqCEI0HNeGdn1NxI6BebdKAGnltqKHHpoH++uqfo2mqnEwxMryeMkhFhtt0LAzo jwHiqEx4kO4TaAet2mivGGw2eZ6OB77QzZhrtRSXZnmebeTWiC1jBHzcTghtUr23geVM+3AE/RG V6xaZdumt2GWxDbbE45L8lagZ7KTNionQMft6gvuQPUMlaxwCQp2N2FvMerzSwgejgISMZ41JUS K1UUUXRSYUtZTQ2Fjrwoic0e2Yg83cABMkXTonvo9Hdgisa4fVjSA== X-Received: by 2002:a17:90b:4c4e:b0:35d:a2d3:5c31 with SMTP id 98e67ed59e1d1-35e42858252mr25610929a91.29.1776303189780; Wed, 15 Apr 2026 18:33:09 -0700 (PDT) Received: from [127.0.0.1] (211-76-176-103.dynamic-ip.pni.tw. [211.76.176.103]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36132c8b96dsm432340a91.1.2026.04.15.18.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2026 18:33:09 -0700 (PDT) Message-ID: <66c7d579-c6f9-41e6-be43-1ba3c2229683@gmail.com> Date: Thu, 16 Apr 2026 09:32:59 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 13/13] mm/huge_memory: add and use has_deposited_pgtable() To: "David Hildenbrand (Arm)" , Lorenzo Stoakes Cc: Andrew Morton , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kiryl Shutsemau , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <41b1ff54-c120-42ae-8b74-54767abf3554@gmail.com> <2f29f66b-46db-4925-b922-4add61b633bf@gmail.com> <53d748d3-4150-4e7b-8c1f-4c58587e9183@kernel.org> <6125defb-3aa4-494c-abed-982be684f839@gmail.com> <6417587a-7e43-4615-9e2c-50a245842f59@kernel.org> <6edde1e9-0f42-4dae-b0d1-3f2895f2111b@kernel.org> <2987ed25-bba1-4218-a776-0bb98aa87bbc@gmail.com> <4993bd8e-427a-47b4-894b-d003d6717909@kernel.org> Content-Language: en-US From: Yin Tirui In-Reply-To: <4993bd8e-427a-47b4-894b-d003d6717909@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/16/26 00:06, David Hildenbrand (Arm) wrote: > >>>> Then, when we encounter a huge PMD, we know for sure whether it was >>>> installed through remap_pfn_range() (needs a deposited pgtable) or >>>> ->huge_fault() (no deposit needed, can be refaulted). >>>> >>>> So for Lorenzo's `has_deposited_pgtable()` helper, we could simply use: >>>> >>>>     /* Huge PFN map without a huge_fault handler must deposit */ >>>>     if (vma_test(vma, VMA_PFNMAP_BIT)) >>>>         return !vma->vm_ops || !vma->vm_ops->huge_fault; >>> As mentioned above, also considering vma->vm_ops->fault; >> >> >> Will do. > > > Please make sure to wrap such a check in a well named and good > documented helper function :) > > Sure! Will introduce a helper for this. Thanks! -- Yin Tirui