From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756081AbdJJJa1 (ORCPT ); Tue, 10 Oct 2017 05:30:27 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34563 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755844AbdJJJaZ (ORCPT ); Tue, 10 Oct 2017 05:30:25 -0400 X-AuditID: cbfec7f2-f793b6d000003243-7c-59dc932d34ff Subject: Re: [PATCH] clk: samsung: exynos5433: mark PM functions as __maybe_unused To: Arnd Bergmann , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski Cc: Ulf Hansson , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Marek Szyprowski Message-id: <66c87919-60a7-b1de-a880-90b007c7efe4@samsung.com> Date: Tue, 10 Oct 2017 11:30:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-version: 1.0 In-reply-to: <20171010091522.2286344-1-arnd@arndb.de> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTYRTGeXd37+5WV97myoNWxqo/UuwDK65WYlBwQ/qCQGZFjbyp6DR2 VTQD18f8mKWipbIUzJaCZJYL0dGXSi0yXTawxLXKQaPMzFSwL6ntKuy/33nOc3jPc3hpQvmS DKXTMrN5faY2Q00ppJ3Pfjqioqpdms2jTyPZv1XPZOybGS/JVnjGCdbhuCtjOzzDJDt12U2y Tls9xdY5HknYoRd72b6vxSQ797JMyrba/iDW3pYYz3C/f1UhbvKtUcY5y69IuG7zOxnX0VpK ca7hBxRntRRy5fdbETfdsfqQPEmxM5nPSMvl9ZviTipSvXXv0ZkhJq+8cg4ZkHWJCclpwFvh YblNKvIKeOVup0xIQSvxLQRzTdWEWEwjaPgyK1ucaLC4pGKjGcGlumaZWHgR3Bx8TflcwfgI 1PR88DdUuFsC3reXSF9B4DsIrpcNkT4XhbeAacLkn2BwHLTM9khMiKaleD1Y59f45OX4GBT3 jhCiZRnMVbv9y8rxNvCM1PqZwLHwad5IihwO1tsThMghcNE44l8VcK0MXp2voMQMe6DtWiMp cjB8sd9fyLYSnNVlC9eoQHDBGClyHYLBCUbkHdBnH1p4LAiqOmsJ386AGSgpUooWDtq6LZQo 7wazLcwnK3EJgo8D8koUbg5IYw5IYA5IYA5I0IikrUjF5wi6FF6I3ihodUJOZsrGU1m6DvT/ j/XP2390odnnsb0I00i9lOkqdWmUpDZXyNf1IqAJtYo5sva/xCRr88/y+qwT+pwMXuhFYbRU HcLsSirSKHGKNptP5/kzvH6xK6HloQakGU1chw88jU7Pan8cplBFKpsdaU+cxw8mGVcFhYxv fxxTv6+wQh98zxIjz9vfMljwvulo51R/ad/mRNUS3evKrLwU98MBMmJ5i+ei9TlyHP52tKDv cygaO2e/sXXD7QOayfirQrFubKa7PZa1ZBu+D65xGhM0NR7htMKdYFgKaqmQqt0SQegF7T83 rudcXwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsVy+t/xK7q6k+9EGrRuZbb4O+kYu8X1L89Z Lfofv2a2OH9+A7vFpsfXWC0+9txjtbi8aw6bxYzz+5gsLp5ytTj8pp3V4seZbhaLVbv+MFoc XxvuwOvx+9ckRo/3N1rZPS739TJ57Jx1l91j06pONo871/aweWxeUu/Rt2UVo8fnTXIBnFFc NimpOZllqUX6dglcGc9n3GcsuMhb0TfhB2MD42buLkZODgkBE4m5S+6wQNhiEhfurWfrYuTi EBJYwijx8N8HKOc5o8SyiXPZQaqEBUIkph18wA6SEBHYySTxoW0OmMMssI5RYu20PcwQLV2M EotXLQRrYRMwlOh628UGYvMK2Eks/3qQqYuRg4NFQFVi8z8FkLCoQIzEz0uPWCBKBCV+TL4H ZnMKmEo8vjkdzGYWMJP48vIwK4QtL7F5zVtmCFtcorn1JssERsFZSNpnIWmZhaRlFpKWBYws qxhFUkuLc9Nzi430ihNzi0vz0vWS83M3MQLjbtuxn1t2MHa9Cz7EKMDBqMTDeyH4TqQQa2JZ cWXuIUYJDmYlEd4QZaAQb0piZVVqUX58UWlOavEhRmkOFiVx3t49qyOFBNITS1KzU1MLUotg skwcnFINjL4rPU0FmzmrxWLctjgHJGaa9734zzGn41LO75yrR+LEe3cleQekeXr+2Rig3Oj1 Wu2DaeQB/ufdcrXWwtI7jh3keJi/Y84GptgdRxsvaL0yjfqQ6bpFQ3jyyt6JFz4ZdL/JZQh7 fNSKdWPkZ9WSrnnlCVtnGkSxNyq/vbfv7euFLzZ+2XpXWomlOCPRUIu5qDgRAMQmTxy3AgAA X-CMS-MailID: 20171010093021eucas1p18a41f4292de21987f7aabf6857b9a1d9 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRs=?= =?UTF-8?B?7IK87ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?TWFyZWsgU3p5cHJvd3NraRtTUlBPTC1LZXJuZWwgKFRQKRtT?= =?UTF-8?B?YW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-CMS-RootMailID: 20171010091530epcas3p2e03b0e52f91e7dc2ab0dd9fea687d891 X-RootMTR: 20171010091530epcas3p2e03b0e52f91e7dc2ab0dd9fea687d891 References: <20171010091522.2286344-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2017-10-10 11:15, Arnd Bergmann wrote: > The suspend/resume functions are referenced conditionally, causing > a harmless warning when CONFIG_PM is disabled: > > drivers/clk/samsung/clk-exynos5433.c:5476:12: error: 'exynos5433_cmu_resume' defined but not used [-Werror=unused-function] > drivers/clk/samsung/clk-exynos5433.c:5453:12: error: 'exynos5433_cmu_suspend' defined but not used [-Werror=unused-function] > > This marks both as __maybe_unused to shut up the warning. > > Fixes: 523d3de41f02 ("clk: samsung: exynos5433: Add support for runtime PM") > Signed-off-by: Arnd Bergmann Acked-by: Marek Szyprowski > --- > drivers/clk/samsung/clk-exynos5433.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index cd9337613dd8..db270908037a 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -5450,7 +5450,7 @@ struct exynos5433_cmu_data { > struct samsung_clk_provider ctx; > }; > > -static int exynos5433_cmu_suspend(struct device *dev) > +static int __maybe_unused exynos5433_cmu_suspend(struct device *dev) > { > struct exynos5433_cmu_data *data = dev_get_drvdata(dev); > int i; > @@ -5473,7 +5473,7 @@ static int exynos5433_cmu_suspend(struct device *dev) > return 0; > } > > -static int exynos5433_cmu_resume(struct device *dev) > +static int __maybe_unused exynos5433_cmu_resume(struct device *dev) > { > struct exynos5433_cmu_data *data = dev_get_drvdata(dev); > int i; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland