From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932236AbdJWNdJ (ORCPT ); Mon, 23 Oct 2017 09:33:09 -0400 Received: from mail-by2nam01on0041.outbound.protection.outlook.com ([104.47.34.41]:48372 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751113AbdJWNdG (ORCPT ); Mon, 23 Oct 2017 09:33:06 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v6 16/38] crypto: ccp: Implement SEV_PEK_GEN ioctl command To: Borislav Petkov References: <20171020023413.122280-1-brijesh.singh@amd.com> <20171020023413.122280-17-brijesh.singh@amd.com> <20171023093240.GC19523@nazgul.tnic> <20171023123223.GA24208@nazgul.tnic> From: Brijesh Singh Message-ID: <66c9f41e-868e-0d14-aaec-0858753c86d4@amd.com> Date: Mon, 23 Oct 2017 08:32:57 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171023123223.GA24208@nazgul.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: CY4PR04CA0028.namprd04.prod.outlook.com (10.172.133.14) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fbfa0374-25be-45ad-c038-08d51a1a9659 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;3:uuuT/18EIYDwb5P3o7UcCvCDmZtb5u1THCnYXeWfPu13xlqSq4+XE84XIuQb9y8d4hHMDqeWDWAnYd/DcBwLCZvYIX1mNlqIF6Z2oIi0tmB5U7v7gVDIftYAYwGr6wDkLthKIhoYOGVuFHTHBECFYvK51nnKmJ7ocZt9Pv+LHuPMuV59BVF329l2An/XIGl8PXolVs62rv5Nu8GQe8QgNNFvMFuDPYcLNNM8LDItirE7172+XgRfWaKYotBdb2Wd;25:U25DpkhApgyBO5Gi+glaXm+8sNL/wTCWaZfSesiAR1ICNTJaQJ9I8OAnLPybvsPNhli9+62u8WBpv4F+GGrIvyqwI8Zr9ZEFwaQTh/AgIxVcrtRdKTTvvqegdkTFMztHolykhOKRHjwFiFM3zXf5rxA8028Ux3DAHeldM/xQht9PQQTyMFDpHXbml+myTlJc9AXEg4Gzihut8uHoooi8wPD2DjkT9y2zDwl7xbypqNeDn4sZsbPrO17YrQjKihnD5yjylIscL/5gSc0jsrp31sfgCIMVlLXJn/cjZV9QLbGSdudofIGDraN0hbJZgYtokqG9OWhulwlH+CJgj0izYw==;31:KhRkQEW91rxOE7M7g0dqODZcAJyKAdEH1FpzFJmAlBL7sdeY9+w+YMweeYmsIhNY2n/9Z7V7JLzQWPuslfaJvPU+AOfq2aMdAbLAkbJ6HOALuN+2Bx5/MHW/Uaukwc590VJQcnW2MLasnStscJyyoATOM6DB9QsSqR8XHUyjOljHrluYc3HB/vbJljr3PpDNMszvR9WCELIUgG/GYc6i79makyaGdcS0urK9zF0Ag0w= X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:BBr5ucXG1w9wG+FvDWpTyAA19vARS/bAsvgb2oo73gM4AUYEdlqaOYgNMr6Wvr2bcbM+HFUjroHdrMMZE3jzv2iunN3l/jkV/kQrSQnhDCVozHcAoYzTd2FeqrBAYsbAQGW7nZsXULJkbUJLf9YMxUlZo2JJlHN2zDB9a0CNpsL9AV4AXPoDluEigUdWzG8pv9c6sZ9l6Qk6rG+tZeJ/o0y+H3onnJqMqBc6d0HlKLNahoLyKmgMRQ4gGJ+R+93EjLAy+2JN6/ksmzkhQilWZ1Bk6RdT0P1dLHEkiChfDY/AM2SVkCH4gmX018hnGd8vxdxkK3tWIncHA+glGI65qmJwRNFZazX+gPdakgCb5VXBA1iKluOOuGjvsYk54dgMaImL93MXesr6f1MdeZKNe56dliT/o4/qBSYL2RdBDsg7aoA+bWB7nVQks2a6wIrIE6PkR/2xUNM1kJxVuZv+rRvYr5YhMaJn4STxcWJYovT7zCoinSPEfbuAgDpGV1L2;4:xDakLywBTzF2zQ3KPgdiFz3mgnLyvYM22KUbIx8Fitus1Q1Xk6DN7pOAivrLnnfiOCdDPCoSpjxam+Lrj4LEYRC5G+yc4uvvS+Ghe/NOOogOO95Lw/viTXjdB3x3riWEXQelJA5FECtynJJmsn+drgLu8QkAFu4bx2dMCqbwLCSYcxXzNrp2W784aDMw8rZNeyRkMLfAN93/y1m4wa+Z0pYyxCTGV6Tro0rWVNFfObNlSPW3ktt49UqI/D2v1NhK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3231020)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0158;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0158; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(24454002)(3846002)(478600001)(54906003)(25786009)(97736004)(6512007)(16526018)(53546010)(86362001)(36756003)(23676002)(106356001)(4326008)(83506002)(6116002)(6246003)(58126008)(53936002)(31696002)(50466002)(229853002)(81166006)(230700001)(6506006)(8936002)(76176999)(54356999)(105586002)(81156014)(6486002)(50986999)(5660300001)(305945005)(8676002)(47776003)(65826007)(6666003)(31686004)(33646002)(64126003)(316002)(7736002)(2906002)(93886005)(6916009)(2950100002)(68736007)(189998001)(65956001)(66066001)(65806001)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0158;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOllIN0xVUEwxcmc0UUszQ0xuaXRneDJuQ3FX?= =?utf-8?B?bmtkeFFEVU5acTUwMFY1NTRaR3NFVVNRL2p6Vy9qSTlxVGZLYXdhbzVLOHVl?= =?utf-8?B?emloZitqNmhNeWwwR2dhVmZaRDc4UVZQb0llZytoblVxcXVFV3IxL1I0ajRy?= =?utf-8?B?WXArZ3JFZ2psaGhBRHBzeFN0aS9OSC9MU2xwYzVqQlQ4YWpSYzVMTkRsamF1?= =?utf-8?B?US9LM1B5NFJ0QmpUMmNDVmU3R1VaV0gvRWp4M2tFVFlaNlVWRWU4RkRVRVZU?= =?utf-8?B?QjdyWXM3WG1lQU83ZWJQMEN5UjVXa3Myc1J1TUNKVzNJenFhTXVwUXl2Nnph?= =?utf-8?B?cGtBYWNUbStENmxMRnhXTFZkNWkvTmx1ajV0WUtvOWdXY1hMNm45blE4Z3Vo?= =?utf-8?B?Zy8xQ1JvZjYxVnF3WjVGeGFGd3ZMUVFneFAvTTBDVGNURDd1S0VqL3RwYkky?= =?utf-8?B?UFRKMk44OGVMRWZFZUt3ZWZOT0EwRkE5NWEyQmVicXgvRE1jd3BiZWx6c0JO?= =?utf-8?B?Q3dOQWRlbisrc2hYMjJFSFIvTWN6NEFOZU83NndOM2FtcnZjaFNIR1hreWh6?= =?utf-8?B?WUVYOE51Z1dLWlBzVWZZelQvVDZXMSs0b0dTR3dMaU10TEd3QmMxZzJ0L3k4?= =?utf-8?B?THBDQVZOQUdJa0ovYnJiL2x3SmdZRllYRm0ySWR0V01iRXpqRHlIaFhucS9I?= =?utf-8?B?SzFKTUdMT3dEaHpjOUhaZ0w0V1NRUzNtb2MvMnFvckRUMjBzTzN5NTdvZkgv?= =?utf-8?B?TUgrYWY4NDgvelhXTmNGZFRJNmJTamNxMW5MYTZwS0RvQXV5bXhkRTYzQ2NB?= =?utf-8?B?UWR2OVp1TmxZL052ejRoVzBJS2tRcGZnQU5rbWtublB3bTZ1YVN4NDFsdnQ2?= =?utf-8?B?cGVkcUswamppR250enpXVkZBdEtJZXdUMzFhcTNrMFJ5d1NJNyt0NS9nM0hP?= =?utf-8?B?U3RvemlFdGJPeld4SzV2dk5ram02MVcwaUZnNFpXOFM5dlJjU1dPTms4TmxJ?= =?utf-8?B?UnFreFFjdnBza2tORGhxa2JjRVpGSUkvd25WTVpZVVQvZGtKUHpCR3gwNGYr?= =?utf-8?B?anlUODVwTUlDQ1JKNFRuN1hsWFBYbm9MbmtJSzN1NWRpRGdnMnVMcWRnVzFu?= =?utf-8?B?VVRvMm9WaENHYlZ3bHZwWm9IeGYvV09WNXlaSWtJQlpUTkJyMUZjSWdtbmx2?= =?utf-8?B?RVkzeXpnR1ZCblE2WHZXcXJoR0xyZUNLcWZ0QkhzT05JL0dPbnFocWRRYW1T?= =?utf-8?B?OWRidERQN0ZnM3JaZnJPSDMzbkVGTGdvTDZ6djlJZVBYQitEczZoYmlPUFhw?= =?utf-8?B?dUlWQzVvYzV0Z2N4TVEvM3MwazRHMm1LaEZvdTNRM0JPOWMybE9WSTNDbGhW?= =?utf-8?B?dVA2Yk5PN2MvNWpUSGF6SHlleXZTOHZGd2dPR2FvTEtUcG1STkdzL1I2YVFJ?= =?utf-8?B?STJmYTk3TlhQQUtUa25qUmx4KzhNWDJ0UHdPY3NTRFhpSWdleWFpT2JTb1Bk?= =?utf-8?B?YnI5U3RzUlkyb0NKL2dKVnZ4UE1oZE5nSW9ZU2c2L0puZjNnUlo0U2JTcGN3?= =?utf-8?B?YXpYcnZWdTBZMHZQNjdickJVWm9mVzJWblFzZlVnZmNDdVcrTDBCZStvQ1k4?= =?utf-8?B?bGJjR1htOGNvN0UxbURYOEordnJld0hVT3lHOWsxczdsc1JFVzgyQVZyZkpv?= =?utf-8?B?VUx4U3BzdXZ2RlhtTUhqN0FaV2xoMDh5L3pDMzlrYkN2bGhZd2NJdERNRTFS?= =?utf-8?B?NzJsMDZkMTdxTnNNdGk5ZWRSME1tUlY1N2hqRWRvb0FUZnNiN2RtV0FROWM0?= =?utf-8?B?dUdhdUlqQ2dLLzNuRCszdFdrSzJJcEdrL2orTTgxTjd5M1E9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;6:HETVfp7YXQbU91doNoQsO3p9GxIhkPQv21+Ths4tfw6gYZenoRYooqAC9AHNFTf3zOrqZu901t7pmN3FRj9nk4wF+HaFUhbeIrdyiJlPGZ0SBprvWUhdG+L6i0XpzZ7LM6arGeD7V4otmHVfWk9MjxtW6UAcbjepEJSFZu2SmPNys+2lyayWSqmMZVdptJhMiIOmPwiwIbmtE803t9i4uCaNL3Ccz1u8U9fmU7nyxVZ5JpQn7DlWIKaz+ZXW3vEOAUR7hPvOUSzECkXlKhNQcJTomPKC6MbNyc8U1aCTG1s5nvdKJS/NhetgpdviOWyP8VN6+h7b2DbnTIPf9C68RA==;5:Qfp0UweAZFIIiGRtCXCsXsyZOcUapNFZ17QeCaEws/RkUJCD6ARfCRvKryX9CRAzA+pjq536gYRhhT9NcJiol33NdIE8IXsPj+612uUxba2H52jWgYSjG8UTMzccWMqvOv3FTVWpzJPVY/lCN1L8rw==;24:iJvZfnfDXUUzEfztEoA93cdenYT7HKS398Xu9Jz1M6tWskRrGvFYrv1MXEj/a9dvPociDo7d4rKfOl185CnmYjZ/K+LaSdatQLXd+4uygWM=;7:OFST6tZ8nu8vJd5oZiEzB99SE07+XT3rn3ySMxeni45WerD2NUmLMnVQnep4IH08V3k9MkM8CF8qczGVgmHKBNyHg8Qevi7JR3UPtGMW+5BaOAOJxyReTzl2B9FRNvx+02z2937vPMXXqucrZH5TNY6HNFkLj1kpzhjtBclOUkZ/kcn2VxLQZurupCzJXwsfe+MDO/G18AaCuyZjY0iQ881YP9DPySCqMiJZ1rWShMc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:ULtYeR4UTj8Ia+JRmhdAjSEGsBVq1nU8uUAfYzWbD7tw3YgBeM5u+OrFZzH9C2DhVI8LpXCumX6zyUQSQ6nE7oI76rwl4WyIkO8vYji/ipQFU41e9lNdI/GiRjFoRt+RnBQ/8cFxxfFWusRP5Ngc3tSM5uexIP4lUCCjgQxGAlQhlYAvjB/ORm9POc4wxyvs+g2mF7lBxADTjenNu51vFgEJIarV8dgun9i1mW7+eYA5udYASMzKkLF5u5I8KhFq X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 13:33:02.6573 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbfa0374-25be-45ad-c038-08d51a1a9659 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/17 7:32 AM, Borislav Petkov wrote: > On Mon, Oct 23, 2017 at 07:15:30AM -0500, Brijesh Singh wrote: >> I am not sure if I am able to understand your feedback. The >> sev_platform_shutdown() is called unconditionally. > How's that: > > If sev_do_cmd() fails and sev_do_cmd(SEV_CMD_SHUTDOWN, ...) in > sev_platform_shutdown() fails, then the first ret from sev_do_cmd() is > gone. If both the command fails then we return status from the last command. IIRC, in my previous patches I was returning status from sev_do_cmd() instead of sev_platform_shutdown() but based on our previous communication I thought you asked to return the status from the last failed command. Did I miss understood ? -Brijesh