From: yangxingui <yangxingui@huawei.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: <jejb@linux.ibm.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<prime.zeng@hisilicon.com>, <kangfenglong@huawei.com>,
<john.garry@huawei.com>
Subject: Re: [PATCH] scsi: sd: Update dix config everytime sd_revalidate_disk is called
Date: Tue, 29 Nov 2022 10:45:55 +0800 [thread overview]
Message-ID: <66c9f444-ef8f-c56a-0b95-ed39715e4a75@huawei.com> (raw)
In-Reply-To: <yq1h6zzz740.fsf@ca-mkp.ca.oracle.com>
On 2022/10/20 8:18, Martin K. Petersen wrote:
>
> Xingui,
>
>> When the host protection capabilities are 0x77 and a DIF disk is
>> connected, the DIX and DIF of the disk are default enabled. Then if
>> that DIF disk is reformatted as a non-DIF format, per the currently
>> flow, the DIX is kept enabled which is not correct
>
> DIX is orthogonal to DIF and a host property. DIX should not be disabled
> just because the disk is no longer formatted with protection
> information.
>
> That said, your patch is probably fine. I'll take a closer look
> tomorrow.
>
Friendly ping... Do you have other suggestions?
Thanks,
Xingui
prev parent reply other threads:[~2022-11-29 2:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:18 Xingui Yang
2022-10-20 0:18 ` Martin K. Petersen
2022-10-22 2:52 ` yangxingui
2022-11-29 2:45 ` yangxingui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66c9f444-ef8f-c56a-0b95-ed39715e4a75@huawei.com \
--to=yangxingui@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®