From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C83C2773C1 for ; Fri, 19 Dec 2025 08:05:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766131521; cv=none; b=Al6196Ty3I6JL6R5GF1FuqGDZBA3FiB/RYuyOQvPtraUIh1lgVy0SxNg5vF8EeUDjK4ERX8ZTFzoIZGkq2WWGZNOseGQhgJKxwI0RA1BfH7WXxHZNdf0yDvjpeI7ClPhnn2XpOagSBb52keX9xv/hrRla8EIAKXK2rddMZ4cuus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766131521; c=relaxed/simple; bh=+uhhIZfIZP5ybUp1SbCOMA9TE7F0d8nA8r9tVHOYtzE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jjK297ZAiOBGkD4/kijNs8lEDxxwUg66kZxCJar4432UwCl3MdGWM4ETuQrLnSlj1JAgamh7gnSKOwmQTRN9L0IXkKngDzSjSBuY4t0iXhoIhpjdzyJb3WX3pgpgBpJFwlNaDVyC6E5cAUQz9nf/ZDWsiCOPUfntPThn1hwEbu0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HIOYsbTs; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=B0+m008j; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIOYsbTs"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="B0+m008j" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766131518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hdOk7vDtGRSaLNKWE0lO0qkTVd58h7TvAR6pyplYZkc=; b=HIOYsbTsCJsQ9IChHUQfvGfaw+GXNeOsSl+8/1uPUERcDe/k57UnUekClgFzqPxVhDkmi/ HupH6woZdSEBip8Cl/qIW+0+aWRbKjkuG/3QTDd2PHc8arZHFrJISEwNj6MU2nTpULiTLg nNxCuP/R3T5Z4EGz/khXD4iZfGGVJzA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-e72O21cmPEKzCMPH2v49Sg-1; Fri, 19 Dec 2025 03:05:16 -0500 X-MC-Unique: e72O21cmPEKzCMPH2v49Sg-1 X-Mimecast-MFC-AGG-ID: e72O21cmPEKzCMPH2v49Sg_1766131516 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4775e00b16fso7905825e9.2 for ; Fri, 19 Dec 2025 00:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766131515; x=1766736315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hdOk7vDtGRSaLNKWE0lO0qkTVd58h7TvAR6pyplYZkc=; b=B0+m008jKDeIk5kBC0GhLyYzsLn+ZDGzRgQEPF3PUqAKi1hM6Eq9K4C714sK1GIF2a k+/qiDItbaqYYU44fK3/ni/GLtnKh5+Jc2xaLI/r9VOqwUOWBQaYfQUG7zl+kul/REEW NYt68Qm2pgzFvrSrzhLDzg3MmkEy1UNi6niZFyzd67oTWk7CY4AfCCZ7jFLEjyjFf15r nJQZqRZ4dC9NEG6bLDBYtiGoMhg3zKqBnK+5HS0QjQVdsLxPlu7NcXdXA71LgNtknJl7 OeSyKEy7Ci+Ngq7b6LBxlTARoGKcb5pURkbRux6ALNbZwuf9SD/IxzXCNZ59ZHRhEd4k /uAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766131515; x=1766736315; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hdOk7vDtGRSaLNKWE0lO0qkTVd58h7TvAR6pyplYZkc=; b=pGD2/q2W0xwtT96pPNNyfzDU9FtcLqJWkbz7WNKEm7CuO4CoJIxQEl+ZJmMn5L6mg8 lEFXkV2jqdsGWz4MQKQoXl3m5/Ube6OWULiNfngGmuba0NxMW2ThfOMi557v2oK5NARK F78mWNFY3g7t3898IK7nNOZJC7TAKPlUy+Xq53SFHf03XadOZAW/eeXR+P8UA5XL19hO 7XsQUAlK76T+ZJzS3gI+nkQFksHaZPdUlyEywNKnSIgLbr/3TQn4r308ISnw/1e4vUrj B62yw1YTQdNKIGrDKXG+ilefnAFc5tH9Q2Rb800JTq3zxR9YuWR4h6jzfHtQA3+rOrQy U3GA== X-Forwarded-Encrypted: i=1; AJvYcCV4PKP6rrBazXWadc2aAzIwB3ijxKEnpTzaFMiTj9PlQUcvXINlqgeeoFdSDB/U5hYfT4KfQICNtwG9+Xo=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw6FCNdloyFURVifRAceCfzjmf0SRs1eI925aOV/I3amk7MMZi eqcZg+DHAUwt3BVQwGVSMvUfe9AQfODcZmHkj5zbn+iOx/gpgMS0RhK/C6COJafrC3VE9XjXJbZ 0UunNKldf8zZEhmving+XWvmHJ2a4g7shSbenlzXhrijFZdnylYmAyYJgq8qpUD1A6w== X-Gm-Gg: AY/fxX6PvdQ5t9mxgY/87pqU+xlbxHlTOAkdRmI9qN7I1Wlt9XpgMvCZ21KzJgSZQwV jnOqNM2MP0HgGY6GrH+6ABNQEZKnzVYQvJA+TgfogxVWazRu+PyAZJdYLs1tvWcqQr3WINox7yT kf+/apDVOtwDleny8BnVjppTGLxFqaunDm5ajR06eO9Msdk7UUKsiIE0Z0sNsC/9ecwbjrjPxkS LvLp1S96l3l5kYcKJCgf8hdVQFTcrZev+ORaRoAYVIqsilTsghFS07tRsmVvnMjFyM0qrgsUt8X H8aswPIWN55nsYKc29u4bjfS5kF5aqFL4pEfXMUIP1QVnaD8NWienMS5Qv8HXZ9wqSK9Fd5UVZN knNMWEUkhBamd0Oo/LjHjXmk70h6nW8sIDWUW6Nsh35ZF6JgF2g== X-Received: by 2002:a05:600c:348f:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-47d1954a710mr18004925e9.10.1766131515638; Fri, 19 Dec 2025 00:05:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSR49Ko4AL5QzboiX/5MOQe6phBCVtU3Qiucp/1hT0zKe/DU+ql3J1wDyHHLXfa9gvtCnrlA== X-Received: by 2002:a05:600c:348f:b0:477:7925:f7fb with SMTP id 5b1f17b1804b1-47d1954a710mr18004525e9.10.1766131515256; Fri, 19 Dec 2025 00:05:15 -0800 (PST) Received: from ?IPV6:2a01:e0a:c:37e0:8998:e0cf:68cc:1b62? ([2a01:e0a:c:37e0:8998:e0cf:68cc:1b62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eab33f5sm3526617f8f.41.2025.12.19.00.05.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Dec 2025 00:05:14 -0800 (PST) Message-ID: <66d2643e-7549-4bb6-b435-f8f3cad3d749@redhat.com> Date: Fri, 19 Dec 2025 09:05:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/3] drm/draw: add check API to avoid spurious WARN To: Francesco Valla , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251217-drm_draw_conv_check-v3-0-15b6f8bc1cbc@valla.it> Content-Language: en-US, fr From: Jocelyn Falempe In-Reply-To: <20251217-drm_draw_conv_check-v3-0-15b6f8bc1cbc@valla.it> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/12/2025 09:06, Francesco Valla wrote: > When using the DRM draw support, the only way to check if a color can be > converted from XRGB8888 to a target format is currently to attempt an > actual conversion using drm_draw_color_from_xrgb8888(). This function > however will print a WARN the first time a conversion cannot be > performed, leading to two potential issues: > > - a WARN is emitted without a real reason if the caller is only > attempting a conversion to check if a format can be supported (which > is the case for two of the current user of this API); > - a failing call following the first one is not emitting a WARN, but a > "valid" color value (0x00000000) is returned nevertheless. > > The first issue was observed while using drm_log on a Beagleplay, which > lists AR12 as the first format for its HDMI modesets. > > The target of this patch set is to improve this situation; the first > patch introduces a new API devoted only to check if a conversion from > XRGB8888 to the specified format can be performed, while the other two > substitute drm_draw_color_from_xrgb8888() with this new API in the > current users (drm_panic and drm_log) where relevant. Hi Francesco, Thanks for this patch. If you can't push it to drm-misc-next, let me know, and I will push it for you. Best regards, -- Jocelyn > > Signed-off-by: Francesco Valla > --- > Changes in v3: > - Collected R-b tags from Jocelyn (thank you!) > - Link to v2: https://lore.kernel.org/r/20251014-drm_draw_conv_check-v2-0-05bef3eb06fb@valla.it > > Changes in v2: > - Moved to dedicated switch cases in separate functions instead of > single one inside common function. > - Fix copy-paste error in commit message. > > Link to v1: https://lore.kernel.org/r/20251005-drm_draw_conv_check-v1-0-9c814d9362f6@valla.it > > --- > Francesco Valla (3): > drm/draw: add drm_draw_can_convert_from_xrgb8888 > drm/log: avoid WARN when searching for usable format > drm/panic: avoid WARN when checking format support > > drivers/gpu/drm/clients/drm_log.c | 2 +- > drivers/gpu/drm/drm_draw.c | 29 +++++++++++++++++++++++++++++ > drivers/gpu/drm/drm_draw_internal.h | 2 ++ > drivers/gpu/drm/drm_panic.c | 2 +- > 4 files changed, 33 insertions(+), 2 deletions(-) > --- > base-commit: ea1013c1539270e372fc99854bc6e4d94eaeff66 > change-id: 20251003-drm_draw_conv_check-9cc3050ebd57 > > Best regards,