From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A2F803E3C47 for ; Wed, 6 May 2026 08:14:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778055255; cv=none; b=exjw2tEgNusMsaRq+MiGYODsftG+Z63rQB25XS9zzPo+BXOHGFIpu93iOV9hfh26ufDRn7n8Q4TQ7GvdZMoART4WRLFRPCCiVf3rmze5mYTMdJq1r6xJFWhVG+CFlylIfWQ9NBfTmHltt8YkdgxraJiykrQQw1yO84n8KqqeAEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778055255; c=relaxed/simple; bh=mwuOGC4zy+g0BeZwVT1YJf9nbSk9kdHByBoSkhxwGeM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h9bd23r+/KnIdoNrq7m7k/pNwNdSi1Ij+C3ebPvMnKy+R7d3Zc4FQBlnuQzCfLFK6gHm/311GlPeDIJFPV5YczeqW61eoivZlWenlBmNXpJmVVqXDgrw9LjBCk6c8YboETJMNrpqgnVXf28FnMeBYF43AgFE0TYyKc5DvFzEWRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=BOMn4LUc; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="BOMn4LUc" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 301AB1A25; Wed, 6 May 2026 01:14:04 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A43D53F763; Wed, 6 May 2026 01:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1778055249; bh=mwuOGC4zy+g0BeZwVT1YJf9nbSk9kdHByBoSkhxwGeM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BOMn4LUcYZAa1oEqRdHH+dAqOSoWyfBQntOu3Ke3XI15ywY6434txPBUCCGnFw9Su ybExIeE9toZRrKyXCqUJb5kQJ2DakQVzWC0rLoTO/VKIha2kIA8PtKAN3F8lggk70i +jkZ0J3Vg7M6ZOY6lpaevarXPkCbkIrxQLJWn3bA= Message-ID: <66d41554-74c7-4d98-9288-3b1a320dc4c8@arm.com> Date: Wed, 6 May 2026 09:14:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: [PATCH v6 1/7] fs/resctrl: Tidy up the error path in resctrl_mkdir_event_configs() To: Reinette Chatre , linux-kernel@vger.kernel.org Cc: tony.luck@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, fenghuay@nvidia.com, tan.shaopeng@fujitsu.com References: <20260505155741.3591201-1-ben.horgan@arm.com> <20260505155741.3591201-2-ben.horgan@arm.com> Content-Language: en-US From: Ben Horgan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Reinette, On 5/5/26 23:43, Reinette Chatre wrote: > Hi Ben, > > On 5/5/26 8:57 AM, Ben Horgan wrote: >> The error path in resctrl_mkdir_event_configs() is unnecessarily >> complicated. Simplify it to just return directly on error. >> >> Signed-off-by: Ben Horgan >> Reviewed-by: Reinette Chatre >> > > An unfortunate typo here. Without the "---" separator the list of > changes below will stay with the changelog. Ah, that is an annoying mistake. > > I'm actually not sure what would be the best course of action here. > Resubmitting whole series to address this seems like a lot but it > may also be best to avoid any confusion. I'll respin. Thanks, Ben > >> Changes since v5: >> Correct order of the tags >> --- > > Reinette >