Re: [PATCH v6 1/3] dt-bindings: phy: Add CIX Sky1 USB3 PHY

[Krzysztof Kozlowski <krzk@kernel.org>]

On 11/11/2026 04:09, Hongliang Yang wrote:
>> So previously you had two phys, now you have only one. Confusing. Where
>> did the second phy go?
> 
> The second PHY did not go anywhere. It is the second lane of the same
> block, and it has no resources of its own.
> 
> v5 described one child node per lane:
> 
> 	usb-phy@9210000 {
> 		...
> 		usb-port@0 {
> 			reg = <0>;
> 			#phy-cells = <0>;
> 		};
> 
> 		usb-port@1 {
> 			reg = <1>;
> 			#phy-cells = <0>;
> 		};
> 	};
> 

This clearly shows two phys - each node with cell=0, means each having
one phy. Two nodes, so two phys.


> Those child nodes had no register range, clocks or resets of their own;
> everything they described belongs to the parent. Both lanes are
> programmed through the same register block, with the same clocks and
> resets, and by the same initialization sequence, so a consumer has
> nothing to configure per lane. The two children only mirrored the two
> controllers.
> 
> v6 makes the parent the provider, with #phy-cells = <0>, and both
> controllers reference the same phandle:
> 
> 	usb3_phy4: usb-phy@9210000 {
> 		compatible = "cix,sky1-usb3-phy";
> 		reg = <0x9210000 0x40000>;
> 		clocks = <&scmi_clk CLK_TREE_USB3A_PHY3_GATE>,
> 			 <&scmi_clk CLK_TREE_USB3A_PHY_x2_REF>;
> 		clock-names = "apb", "ref";
> 		resets = <&s5_syscon SKY1_USBPHY_SS_RST_N>,
> 			 <&s5_syscon SKY1_USBPHY_SS_PST_N>;
> 		reset-names = "core", "apb";
> 		#phy-cells = <0>;
> 	};

I saw the code, why are you pasting the same? What happened with the
second phy?


Best regards,
Krzysztof