From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E78436B045 for ; Tue, 17 Feb 2026 15:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771342814; cv=none; b=k08FNpw1EaiT9b1fdVE6BNhCcSAHEz87Pnbb7YWQB7pUybK4iq3nRg+8Drc7J4rWKIyjqDPblbH2Vd+xsDTCxPkeohEJeEegFFaIG1SnflmMxXyFasFIk97WSrTzlCY9paM9yz0YM/aaRMTEeC4Pfj2SmWc5+shMht5ph8PPyRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771342814; c=relaxed/simple; bh=s70PzdSc3Ao+4XNUlHdv9TJh2ewm61rZ/huM10n9mVQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=nTI3ZKP38fvZ3T8gpOhXY9Uyr4eCbcRmskYQ/1VgMbQGRu6Iycq4Pk7nU/+G97sO0E5wTNhwL1OgPToz9SZBtgshXvtg06Z9sZXx2ZiPDYxX7fHjAwlbx+KGDAR/ZLZslZB6QMIFbvIRdxcwJU9SXhpCsTEXy0knkfkIVCrkOUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JmmoOooQ; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JmmoOooQ" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-4362c635319so4318957f8f.2 for ; Tue, 17 Feb 2026 07:40:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771342812; x=1771947612; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ppRI04Iu3sbbEiHUrACiv+HFyJ+09EOEv1pAadTo60c=; b=JmmoOooQGFcPVsjOJ+lx/igi/h3lwi+mIJc5UHRTdtzjegU42q0wpLRc5NG2v5BtLp s9Om3CyMqdzmTWdoQ2YzGQ4MonexPosH9jovS1MIEunQ6VURad09lZr8lJ6VQ+/W4h0S cl9P9SEp8DyxSHyzk5ZHtNp+MLWqRqKnKS5X4rBr+N+AHabEIdPi630VaAJcsbNWvomn Tqb+h/BbjaLvOYP0mOMPe3ZWmWrhQyDI7Gbd4r0s2tcldRJ59jH5NrbpthOBXHk8am0S UPtTuNvy9ds307HeIojY6dLmBlgO/fMnHQTmWp1U/+ZYfOysxPPy2BLF3c1tu499mZN/ UWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771342812; x=1771947612; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ppRI04Iu3sbbEiHUrACiv+HFyJ+09EOEv1pAadTo60c=; b=VxNwJb0pjvzXBedLv4SDqDue0qgGl/fG07vgxsBvlakpYrGBQS9mmSNQVFwry5kpBE nwT96XxEz/D+GUKvWi+aADCLvg5qWyfviNJu3coSt8uOmyu4HohPWr/II6AYV8Cw/ZXY I4tLIaIq1M5CHInZhyqXTD/2kw0fEq2hwMAHoVPpaIBYiLjUXe+k66ZRV7t5/HX8wtJc sgemsiaMO8k7Y0qoQj3LX0ywXqe9XGG7k0c9SQlZTanQZgVr7GDIt3Cx5oW4M8TLXfub TT5TZnHoiml7QDcLabUdycq0tkF5LxmV5cRpLy+efVMKqyz9veMiwLt3VZq67vfPcAXm AqzQ== X-Forwarded-Encrypted: i=1; AJvYcCVcnYCPVjkdn8K6tMMWOcIphoslkKOvivLhTFWdi2xekno/XApBK4lfn/c/tqXEHqc9MXlVx1C/0ClhLjU=@vger.kernel.org X-Gm-Message-State: AOJu0YxGPWjsj31wwXWi5O54W5+FFkVwJwIqAz+Rm9yIJqOkJDTC4CEJ vvPLFqjqs+LAedsuLNgcNu3WSEP03F09Ps4ac9OikttAve8+zfY1JbvK4BxSeOH8lQl0ZHsnViN CrzalNz4= X-Gm-Gg: AZuq6aL2FkiNbPxyZ0XQPDTTzxIah6C2egbVyPlzfxpW1uckRQvyV/AFcE8VQf35M7g t9nJpaHgKRlMKecH0I5rlakufp3Hw/wVPAmpOnjZkPG6DdLmapr/x7SBkIG+4y2TNhbZTeDV3la Dq/7XlzKeq3RkLdl7VOxfY5gOF0H3PZ7SyjbRkauSfqzWnXVvLP1nwcUD9/L8il4M6tmU8+OApH jDp3LPAL93xbFNcqGmLLs9uSIlKVDgXvi6JVksdVpUtdxd56/bc5omOJ70bwPP/92PynXlERvM6 PO8Lt7YS8KB3q51AhMGZRcrKezwur+RLKuKorDFNDRWCvJPSNNk2XUYd/UmCi5uxPrzzupAHsHZ A6qSs83bZOILG9JtbWFfWov81jkrsxzCx06oABWTJ+KpKXjS9oR0qINXOqiIwP00vPdHvzOVtCu kKKp2xGJDYETpV7S6ndMzhJXIm91f8OZL8wtAeRK2GV7peETRHFHit/DnUQP+cBnnAmBKQVwNUY Ih6aQ== X-Received: by 2002:a5d:5d11:0:b0:436:34e8:e665 with SMTP id ffacd0b85a97d-43797943442mr28768881f8f.54.1771342811730; Tue, 17 Feb 2026 07:40:11 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:72a2:f5f2:e023:2a2e? ([2a01:e0a:106d:1080:72a2:f5f2:e023:2a2e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad009bsm34212046f8f.39.2026.02.17.07.40.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 07:40:11 -0800 (PST) Message-ID: <66da94f1-7016-4fe6-bab0-693b55adc05d@linaro.org> Date: Tue, 17 Feb 2026 16:40:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2] PCI: dwc: Proceed with system suspend even if the endpoint doesn't respond with PME_TO_Ack message To: Manivannan Sadhasivam , jingoohan1@gmail.com, mani@kernel.org, lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com Cc: robh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260217113142.9140-1-manivannan.sadhasivam@oss.qualcomm.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260217113142.9140-1-manivannan.sadhasivam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/17/26 12:31, Manivannan Sadhasivam wrote: > PCIe spec r7.0, sec 5.3.3.2.1, recommends proceeding with L2/L3 sequence > even if one or devices do not respond with PME_TO_Ack message after 10ms > timeout. > > So just print a warning if the timeout happens and proceed with the system > suspend. > > Reported-by: Neil Armstrong > Signed-off-by: Manivannan Sadhasivam > --- > > Changes in v2: > > * Added 'ret = 0' to avoid failing callers > > drivers/pci/controller/dwc/pcie-designware-host.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 6ae6189e9b8a..ba183fc3e77c 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -1256,9 +1256,13 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) > PCIE_PME_TO_L2_TIMEOUT_US/10, > PCIE_PME_TO_L2_TIMEOUT_US, false, pci); > if (ret) { > - /* Only log message when LTSSM isn't in DETECT or POLL */ > - dev_err(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); > - return ret; > + /* > + * Failure is non-fatal since spec r7.0, sec 5.3.3.2.1, > + * recommends proceeding with L2/L3 sequence even if one or more > + * devices do not respond with PME_TO_Ack after 10ms timeout. > + */ > + dev_warn(pci->dev, "Timeout waiting for L2 entry! LTSSM: 0x%x\n", val); > + ret = 0; > } > > /* Allows ath12k to go ind3cold with [1]: Tested-by: Neil Armstrong # on SM8650-HDK [1] https://lore.kernel.org/all/20260217-d3cold-v2-0-89b322864043@oss.qualcomm.com/