mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ninad Palsule <ninad@linux.ibm.com>
To: Andrew Jeffery <andrew@codeconstruct.com.au>,
	brgl@bgdev.pl, linus.walleij@linaro.org, minyard@acm.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com,
	openipmi-developer@lists.sourceforge.net, netdev@vger.kernel.org,
	joel@jms.id.au, devicetree@vger.kernel.org,
	eajames@linux.ibm.com, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/9] DTS updates for system1 BMC
Date: Tue, 4 Feb 2025 13:40:01 -0600	[thread overview]
Message-ID: <66e2e5e4-5ce5-442c-ba0f-d12cbe79e868@linux.ibm.com> (raw)
In-Reply-To: <79b819b6d06e3be0aa7e7f6872353f103294710c.camel@codeconstruct.com.au>

Hi Andrew,

Thank you for the review.

>>
>> NINAD PALSULE (6):
> 
> Why is your name all in caps here but not for the binding patches
> below? Can you fix that up?

Fixed in the version 9


>> Ninad Palsule (3):
>>    bindings: ipmi: Add binding for IPMB device intf
> 
> This one needs an ack from Corey if I'm to take it.
> 
>>    dt-bindings: gpio: ast2400-gpio: Add hogs parsing
> 
> This one needs an ack from Linus W or Bartosz if I'm to take it.
> However, it's also causing some grief from Rob's bot:
> 
> https://lore.kernel.org/all/173859694889.2601726.10618336219726193824.robh@kernel.org/
> 
> As the reported nodes should all be hogs the name shouldn't matter
> anywhere else (as far as I'm aware). It would be nice if all the
> warnings were cleaned up before we merged the binding update. That way
> we don't cause everyone else looking at the CHECK_DTBS=y output more
> grief than they already get for the Aspeed devicetrees.
> 
> In order to not get bogged down it might be worth splitting out both
> the IPMB- and GPIO- related patches like you did the FTGMAC100 patch,
> and then I can merge what remains (from a quick look they seem
> relatively uncontroversial).
> 

The warnings are fixed by different patch by Krzysztof. As there are no 
more changes then I will wait for other responses. If I don't get those 
response in couple of days then I will split it.
https://lore.kernel.org/linux-kernel/20250116085947.87241-1-krzysztof.kozlowski@linaro.org/

I am also planning to fix old warnings in the system1 dts in separate patch.


-- 
Thanks & Regards,
Ninad


  reply	other threads:[~2025-02-04 19:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 14:44 Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 1/9] bindings: ipmi: Add binding for IPMB device intf Ninad Palsule
2025-02-03 15:00   ` Krzysztof Kozlowski
2025-02-03 15:17     ` Ninad Palsule
2025-02-03 16:01       ` Krzysztof Kozlowski
2025-02-03 14:44 ` [PATCH v7 2/9] dt-bindings: gpio: ast2400-gpio: Add hogs parsing Ninad Palsule
2025-02-13 11:30   ` Linus Walleij
2025-02-03 14:44 ` [PATCH v7 3/9] ARM: dts: aspeed: system1: Add IPMB device Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 4/9] ARM: dts: aspeed: system1: Add GPIO line name Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 5/9] ARM: dts: aspeed: system1: Reduce sgpio speed Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 6/9] ARM: dts: aspeed: system1: Update LED gpio name Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 7/9] ARM: dts: aspeed: system1: Remove VRs max8952 Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 8/9] ARM: dts: aspeed: system1: Mark GPIO line high/low Ninad Palsule
2025-02-03 14:44 ` [PATCH v7 9/9] ARM: dts: aspeed: system1: Disable gpio pull down Ninad Palsule
2025-02-03 15:37 ` [PATCH v7 0/9] DTS updates for system1 BMC Rob Herring (Arm)
2025-02-04  4:33 ` Andrew Jeffery
2025-02-04 19:40   ` Ninad Palsule [this message]
2025-02-05  0:05     ` Andrew Jeffery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66e2e5e4-5ce5-442c-ba0f-d12cbe79e868@linux.ibm.com \
    --to=ninad@linux.ibm.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@codeconstruct.com.au \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eajames@linux.ibm.com \
    --cc=edumazet@google.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=netdev@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®