From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F084B2594B9; Thu, 4 Jun 2026 11:48:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780573719; cv=none; b=lO06UBT5mSOiis30rOTIhd3AT/I+CvphsDq955LsOTM2UCOHNcc2QA5rh5d6F7W5RKtak6p5A359omEFwSRL9vbW2eHsL/qoog/4lOP1fYFQHCtJ3kx7OuP1MBrS0Y8+/flSO3DVAlWMDdqHKnUhuwyA25NWZZOhzZJ+o4YxtYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780573719; c=relaxed/simple; bh=91YV57NHkIKryjPwiOnA8wuaZX549ZxjQjZjyeqhpTs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=q6Xv/VkY48Wg7bLcXSxid1LRNsGnSku3Odq49JUFt4DOEUEEAcXmKc/chjqAticbw0IwFsm6nKeeySbRMg4mRlmqBdUKEaXTB5rpTpJ+uW9tmo+qnTGzpm3xTesllPuh47R8FHVZNfA2Gnr2xn8QptXc+kVb5NDhmzJC4SEBEfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net; spf=none smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=TDmOcmPi; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=permerror header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="TDmOcmPi" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=FxEVjqEZq5nxSjM7FBRBoVftG3fOIujov85xVsPkWvo=; t=1780573718; x=1781783318; b=TDmOcmPipe9DLSfOxHBnd8bwLXv1lnfdkfDa5O534tvuMgT UKU0blwl4s43T1Ix4lN5kwu5m2Ji0/thfgmhixvCgNv7cjEicJcBy5VezWdC1GZsmFxd0pRpWQJju hBt8jsClVuN25e8lNES7X8454OTVSUj48+t99WH4mcX0Z8Ji8jYPV2Wzt5epffE8zGwFrUOXqAXQx Iml6hMwKywj3Ad6+jb+3BxRuVoLObRoAHARJqNUH8UQB0YtLRBCHjx+pZHhG2PxpXT3XwyVVPQdhH eC2jWtaVLdBzVCkS8/DT2wk9gz92DKH5ic/ntXQjvJ4fm5knWnYNoB3OPAYoNvig==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1wV6Yt-00000000Sxw-2w4o; Thu, 04 Jun 2026 13:48:35 +0200 Message-ID: <66ec16ce60ab78c68d52312d98f316b74715742e.camel@sipsolutions.net> Subject: Re: [PATCH wireless-next v2 13/31] wifi: mm81x: add mac.h From: Johannes Berg To: Lachlan Hodges , Dan Callaghan , Arien Judge Cc: ayman.grais@morsemicro.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 04 Jun 2026 13:48:34 +0200 In-Reply-To: <20260430045615.334669-14-lachlan.hodges@morsemicro.com> (sfid-20260430_065748_226496_B841CF01) References: <20260430045615.334669-1-lachlan.hodges@morsemicro.com> <20260430045615.334669-14-lachlan.hodges@morsemicro.com> (sfid-20260430_065748_226496_B841CF01) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Thu, 2026-04-30 at 14:55 +1000, Lachlan Hodges wrote: >=20 > +static inline bool mm81x_mac_is_sta_vif_associated(struct ieee80211_vif = *vif) > +{ > + return vif->cfg.assoc; > +} > +static inline u16 mm81x_mac_sta_aid(struct ieee80211_vif *vif) > +{ > + return vif->cfg.aid; > +} Heh. Those function names seem way longer than the implementations, but YMMV :) > + > +static inline __le32 mac2leuint32(const unsigned char *addr) "le32" rather than "leuint32" might be more understandable, but perhaps this should also come with a comment about dropping the two octets or something? johannes