From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A571B30C606; Sat, 7 Feb 2026 09:41:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770457281; cv=none; b=KXGQv0LM6LS9HjXxhkT6xnuCwiq2ygWMOS3cbVAmnj1npOXwcCARC39HolqpPDXRRGIML0EDmaFOoYldMP1zRNDOKv8totK+6fgcqZaPKHY14sKMIPz2iXCUyNqV6C12hwYxOCGjKEznbQ2QVFAUne6tmP3s+1Lk73u5PYFQTZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770457281; c=relaxed/simple; bh=qW8TcPz0UQxQYUMu8yKoeqh2v77wrLOK+jgmmCIELG8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O2qkZuyN1jT7/4W82YTV0Rn03fynzSEwYI3SfMlDHpXHvlTHXvldMGYz4nKYl3uMBvjfxs0+6V5NPsiSJGZ3tS5ml4HtCSgNE2y5NH3jNnSqTwqNNPYGTAfic8Uu47zcv2G+muTr+VnHdDvQvpV68hx1aVBm/q8NFm+vAww5NDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=skTNDAQm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="skTNDAQm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09F22C116D0; Sat, 7 Feb 2026 09:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770457281; bh=qW8TcPz0UQxQYUMu8yKoeqh2v77wrLOK+jgmmCIELG8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=skTNDAQmWpztETtea7NDP3UijHUxmIsDxSeqa4KmIfsCwjdYAtODV9ImaN541jSLO J4YfvTv7owK56m1ycL8tWb9z9J8avF/lya8rXDUsrkjDncBcODXtw2gvnzc2x2Efsx +iSs8mHU+mehD5o4kih8pLNI/qDlkRZA7eIBN0MFE7pJQx0TfN58QkrfDge8TbA8Df jRI8PRY/94Kp/N3WG56B2I7IISsfPwDMCmGQHsJdhCOuPze6UGcQqJf3lGG+JRmLXR WE7+fsgdUTnEUGtrR4rzy8QyUFKo5P0NlbkDl/HDpDgZSheQym2INBixrJBfTPmgi5 euVvwY5BGtzyg== Message-ID: <66f082de-8f1e-464d-bedc-41c0a4db1f52@kernel.org> Date: Sat, 7 Feb 2026 10:41:18 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: mac80211: skip BSS_CHANGED_TXPOWER notification for monitor mode To: Dhyan K Prajapati , Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Dhyan K Prajapati References: <20260207050035.6720-1-dhyan19022009@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260207050035.6720-1-dhyan19022009@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/02/2026 06:00, Dhyan K Prajapati wrote: > From: Dhyan K Prajapati > > Monitor mode interfaces don't maintain BSS context. The BSS_CHANGED_TXPOWER notification > indicates transmit power constrains recieved from an associated access point which isn't really > applicable to monitor mode as it does not associate with any BSS > > after a commit back in july 2025,("wifi: mac80211: fix WARN_ON for monitor mode > on some devices") monitor interfaces with WANT_MONITOR_VIF began recieving link > change notifications during ieee_add_virtual_monitor(), when ieee_link_use_channel() > assigns a channel context it triggers ieee_recalc_power() which sends BSS_CHANGED_TXPOWER > notifications to driver, driver using legacy bss_info_changed callbeack recieve > link->conf as the bss_conf parameter for monitor mode that points to vif.bss_conf which is not fully initialised > in monitor interfaces, so drivers like iwldvm dereference null and crash > since BSS_CHANGED_TXPOWER notifications are meaningless for monitor mode, we can skip > the notification entirely,monitor mode transmit power remains configurable via You keep sending us microslop AI, so I don't think it is worth reviewing it. > nl80211 > Hardware: Dell Latitude E6430 > Device: Intel Centrino Advanced-N 6205 [Taylor Peak] > > Crash trace: > BUG: kernel NULL pointer dereference at 0000000000000000 > RIP: iwlagn_bss_info_changed+0x19d/0x640 [iwldvm] > Call Trace: > drv_link_info_changed+0x2b5/0x2c0 > ieee80211_link_info_change_notify+0x13d/0x160 > __ieee80211_recalc_txpower+0x44/0xd0 > ieee80211_recalc_txpower+0x5c/0x60 > ieee80211_assign_link_chanctx+0x182/0x410 > ieee80211_link_use_channel+0x413/0x450 > ieee80211_add_virtual_monitor+0x17c/0x2b0 > > Tested-by: Dhyan K Prajapati No, wasn't. AI is not testing. > Signed-off-by: Dhyan K Prajapati > --- > net/mac80211/iface.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Best regards, Krzysztof