From: Ivan Safonov <isaf21@yandex.ru>
To: Nishka Dasgupta <nishkadg.linux@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Straube <straube.linux@gmail.com>,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/8] staging: rtl8188eu: Remove function rtw_modular64()
Date: Sun, 12 Apr 2020 16:34:08 +0300 [thread overview]
Message-ID: <66fb1e37-107e-54f4-4986-ca4e4bb99d2d@yandex.ru> (raw)
In-Reply-To: <20190712071746.2474-5-nishkadg.linux@gmail.com>
> Remove function rtw_modular64 as all it does is call do_div.
This is wrong. Macro do_div(x, y) change first argument x, but
rtw_modular64(x, y) preserve it.
> + tsf = pmlmeext->TSFValue - do_div(pmlmeext->TSFValue, (pmlmeinfo->bcn_interval*1024)) - 1024; /* us */
rounddown(pmlmeext->TSFValue, pmlmeinfo->bcn_interval * 1024) - 1024
is a better replacement for
> - tsf = pmlmeext->TSFValue - rtw_modular64(pmlmeext->TSFValue, (pmlmeinfo->bcn_interval*1024)) - 1024; /* us */
Patch '[PATCH 01/10] staging: rtl8723bs: Remove function
rtw_modular64()' have same bug.
Ivan Safonov.
next parent reply other threads:[~2020-04-12 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190712071746.2474-5-nishkadg.linux@gmail.com>
2020-04-12 13:34 ` Ivan Safonov [this message]
2020-04-14 11:56 ` Dan Carpenter
2020-04-14 12:22 ` Ivan Safonov
2020-04-14 13:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66fb1e37-107e-54f4-4986-ca4e4bb99d2d@yandex.ru \
--to=isaf21@yandex.ru \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®