mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>,
	"Rob Herring (Arm)" <robh@kernel.org>
Cc: "krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	GEO-CHHER-bsp-development
	<bsp-development.geo@leica-geosystems.com>,
	"lee@kernel.org" <lee@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"pavel@kernel.org" <pavel@kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property
Date: Thu, 3 Jul 2025 11:56:07 +0200	[thread overview]
Message-ID: <66fb9c67-8f2b-4ce3-8fcb-f6479a1ea507@kernel.org> (raw)
In-Reply-To: <AM9PR06MB7955DCFFBADEF3A56A923D92D743A@AM9PR06MB7955.eurprd06.prod.outlook.com>

On 03/07/2025 10:52, LI Qingwu wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Thursday, July 3, 2025 3:12 PM
>> To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>; Rob Herring (Arm)
>> <robh@kernel.org>
>> Cc: krzk+dt@kernel.org; conor+dt@kernel.org; linux-kernel@vger.kernel.org;
>> GEO-CHHER-bsp-development <bsp-development.geo@leica-geosystems.com>;
>> lee@kernel.org; devicetree@vger.kernel.org; pavel@kernel.org;
>> linux-leds@vger.kernel.org
>> Subject: Re: [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property
>>
>> This email is not from Hexagon’s Office 365 instance. Please be careful while
>> clicking links, opening attachments, or replying to this email.
>>
>>
>> On 03/07/2025 05:54, LI Qingwu wrote:
>>>>
>>>> On Wed, 02 Jul 2025 19:47:58 +0800, LI Qingwu wrote:
>>>>> Some PWM LED chips have a dedicated enable GPIO.
>>>>> This commit adds the support to specify such GPIO.
>>>>>
>>>>> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
>>>>> ---
>>>>>  Documentation/devicetree/bindings/leds/leds-pwm.yaml | 8 ++++++++
>>>>>  1 file changed, 8 insertions(+)
>>>>>
>>>>
>>>> My bot found errors running 'make dt_binding_check' on your patch:
>>>>
>>>> yamllint warnings/errors:
>>>> ./Documentation/devicetree/bindings/leds/leds-pwm.yaml:44:21: [error]
>>>> empty value in block mapping (empty-values)
>>>
>>> Fixed in V3
>>
>> So your answer to my "never tested" was to send again the same as v2 and still
>> not tested?
> 
> Nop,  "Fixed in V3" answer "bot found errors running 'make dt_binding_check'"
> Testing info comes later in v4
I responded to you on v1 in the morning my time. 4 hours later you sent
v2, so what is the "Nop"?

Best regards,
Krzysztof

      reply	other threads:[~2025-07-03  9:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 11:47 LI Qingwu
2025-07-02 11:47 ` [PATCH V2 2/2] leds: pwm: Add optional GPIO enable pin support LI Qingwu
2025-07-02 13:28 ` [PATCH V2 1/2] dt-bindings: leds: pwm: Add enable-gpios property Rob Herring (Arm)
2025-07-03  3:54   ` LI Qingwu
2025-07-03  7:11     ` Krzysztof Kozlowski
2025-07-03  8:52       ` LI Qingwu
2025-07-03  9:56         ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66fb9c67-8f2b-4ce3-8fcb-f6479a1ea507@kernel.org \
    --to=krzk@kernel.org \
    --cc=Qing-wu.Li@leica-geosystems.com.cn \
    --cc=bsp-development.geo@leica-geosystems.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®