From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3EFC001DE for ; Sun, 23 Jul 2023 09:52:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbjGWJwn (ORCPT ); Sun, 23 Jul 2023 05:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229914AbjGWJwk (ORCPT ); Sun, 23 Jul 2023 05:52:40 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80C1610D8 for ; Sun, 23 Jul 2023 02:52:39 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-98dfb3f9af6so585692766b.2 for ; Sun, 23 Jul 2023 02:52:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690105958; x=1690710758; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3VrvByN/8nuSLSqkqBQiwTi662+hO3SXTsNA8vy2Xio=; b=g7VlPFJCUqoeAsUwdWUwZXDiwebB6RLPRNg7JFu/cg81RO+ra054ls+7M7/eJPwEOZ Y/YobxCG7FYjZfHxGCiKq4gv0zv0uwpLcwVZzXLsM1UkmL9xZNyfGibPVv5pccyq0ff8 wLGwQ39cJfIsOG+H/4cBzZAHrUZz6hswq8Jm/Pw6tMsDY9EVhVgCLwcSd8OhhdnH5l80 AwGJXD7YqocARXvzy+7Axkid95cWUZY1I6udTFf0HBivp2APV414PkYqdM/EukwYEpkL KMPuuOBsMa2HidWqIdjlvzj1/m64dHXcicv8PxY4iyADIotlMd8T1faEgZZPpZZs7DN7 RXiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690105958; x=1690710758; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3VrvByN/8nuSLSqkqBQiwTi662+hO3SXTsNA8vy2Xio=; b=QPdAlx1ooVplrh1eQMMz7YiaDOSyIUSiI2zyLKaeCobQfcdaDTB6rrCHxrQm42OMYn gcvrVriOaXbPRdJZSNDa++JKo82XFeEZ6Io8Tl46T5dtKpvzOmNoOgBz6A4XDfNyF7+s dcG0zrYnkwa/RR506ffndStg4ljtKU6NdMiV/cJyxcAJT2ebTcadCOo9WPBH+xKEEgs9 9sOVCs2xW5CydeU1zdQbOeh4ISt9txGoE2E+becNuLMXsc/0ApOzSd31Rx3DKvBpjhsk 9LgRI9n3OCpFbiVRDRXewCTXkuQfI1Km9fn3dNTRj4Q2h2FXUSLqEPj871QaNa+qsBpo RDhw== X-Gm-Message-State: ABy/qLa1JITGewoi4QpsJ2vBtElMUxruEaArm7fFKxnTP4tNyZK7SNh9 ZpErJM6Wq1M4egb/JRhueF/nrQ== X-Google-Smtp-Source: APBJJlGYHC/lniVtA/t7I3Ixv+3Xx7qz3wksoy9sBvq5H6hmO5tjSlYOn2P07wnrhmxZZhyNtdML8g== X-Received: by 2002:a17:906:3f56:b0:99b:5445:10d3 with SMTP id f22-20020a1709063f5600b0099b544510d3mr7020881ejj.75.1690105957975; Sun, 23 Jul 2023 02:52:37 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id jj28-20020a170907985c00b0098d93142ce1sm4891371ejc.109.2023.07.23.02.52.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jul 2023 02:52:37 -0700 (PDT) Message-ID: <66fc3434-8cc4-3316-ffda-2ffa08cce0f6@linaro.org> Date: Sun, 23 Jul 2023 11:52:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays Content-Language: en-US To: Viktar Simanenka Cc: David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230720124026.356603-1-viteosen@gmail.com> <5b9ceb0e-b7e4-d4b3-461e-c70f4a01fa5e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2023 14:25, Viktar Simanenka wrote: > On Fri, Jul 21, 2023 at 11:42 AM Krzysztof Kozlowski > wrote: >> >> On 20/07/2023 14:40, Viktar Simanenka wrote: >>> +allOf: >>> + - $ref: panel/panel-common.yaml# >> >> This is not a panel, is it? > > I can't clearly tell the difference between LCD display and panel. > I've added panel-common because of 'backlight' and 'reset-gpios' > properties. I've looked at 'sitronix,st7735r.yaml', > 'ilitek,ili9486.yaml' as examples. SPI controlled LCD displays, but in Probably your device is not a panel (datasheet says: LCD controller), thus it should not reference panel-common. > color. > In fact 'reset-gpios' is already in my yaml. I might just add the > 'backlight' property explicitly and remove this dependency. Should I? Best regards, Krzysztof