From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33CCC3B2D06 for ; Thu, 30 Jul 2026 08:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785401029; cv=none; b=XmxGEqpEtYnDv4WYdEcnJOL0r70PTI83UCAiILezS2kLsW+C6raOtf1hZhXSoxR8ARaq4Zeon9SxcpFDAxA1YUhhuVHEBGdouhkwCdw1Ykk7j8cGzqBCpit7rsj1MaJkHC3fe75e9mkbW/Q5QKvP9w93VVwLPALcUu72UfznGB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785401029; c=relaxed/simple; bh=auCBgk0v7+8BpvMxpnoaacS+mT+SxVCkPa6wybn3nTo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f4k9u9xInmQyCSt7dhrdN7OZj5OZJx2PhFSqahF7dvx+9zg3NB+MO2+QH+prdVo4bTMOYAwCDEBMI6S8+d/3yS9QNgd5dEtZpkmEC/Iap3YquHluvZqbvy7mXmNnGy0DKuOM2WTaoKBMEljqnWjQuu1VnxKQBqIzHfbPwrDiYFY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=b2D2ozxz; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="b2D2ozxz" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49545ba3d4eso8115895e9.3 for ; Thu, 30 Jul 2026 01:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785401025; x=1786005825; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=M2aUYlvSnFQyHqLqh6TDTs9lMuK0bX5eXRwDs/M2T8c=; b=b2D2ozxzcEPwu9ZNorupQKEA0vV99qD7WKMmjcl3tQ3IydPccPWRa+YYqr84Taj9BX PmeukBL61br8J7J1kLsN6wvu0FA2cxVPUXlqjtZgijnaMgCKJTz3cpOFy7cZ3uYjuYPD 2K73PvxqZhI5idC/iLA3p2XwtLwCEp/5F9iGb3cMbmAf/nM2B1VSRL5INUTKml58R3e8 7QbFRB1+H81MHWaI8AP6ehMWNGKXNgEIVlyCQi1I49d1izNTL8StsgB3y5YHoUH0t32Q LQT123KKDiU4QVr4BYaLVjhqkpqlgkSEgtcE95+lF2uCQ7vUzQ27pHBHs2KkLNhOH/SO WuxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785401025; x=1786005825; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=M2aUYlvSnFQyHqLqh6TDTs9lMuK0bX5eXRwDs/M2T8c=; b=VGRf0FK6juvoHem24CsuwLnSyN0E7Fu5PTUWwHD7eEllZUSRuhsGg8djEFzKwaZvhB SwfA92yZVvdBXhlTTFsVu+NeYGuBSM7qTL7NYCqtqQQvZNnK3ddeQxsxFsDe4Ov57k5R bGYnC0SU7++S/x62F69+SrJZHP6pXlhf2VtMxk3ZXMsvTxxL/bQjv+zQcMgPkKxnLXz9 ss7E7xTX/Pt9Fuit8yF4+LxoBz4VFO6vwddimb3vfQ18LIWaUZ+A5FxfngfwP0MZWhOB XRH9rRBTGVqRNMfqNqLWalMbjZCJeIrYJJOebxHt/7856gc56x3Sij5HtbmxJCgnleYn PwuA== X-Forwarded-Encrypted: i=1; AHgh+RoMe6cBSYPzhmDdXVXPfQmJ77zSHhe8OG3czwQ/mjIyzQmRM9X73E7c5yfGcRMFe0PvYrKswdPUvrpXvqc=@vger.kernel.org X-Gm-Message-State: AOJu0YxBtQbMvfbdyg7uuI8I9+aUAHBDe/w4Y1KaJO+AYJTT8LEql+D+ GQrdy4cA7ysoCyvyynSx1NYZi0r6LnwGorXNRMvQhW5ZXabyeQ0imQTVdF5wb+2E8A== X-Gm-Gg: AR+sD12ocRqWtukD/zgoRm0E5zcY6TorF3UXRLq+eRVF0iUYjIVR91sK8iOT2yV1HrE Axd4DRaKiv84BQNiPbLK28tArG4sSDjZ3cY3Rq0Mr0rk04cK+BapyKZFYMGCb6rOyl7boxQGUng b6LFN/miU4NBefK7q0gMtxBF0ZTJc7b+eQi8Ccei4g5iSB4oG7/feTMdfmCVNGGgwT5zwZSggVy 8IZUIE/2//bbss1/LHKcrTr9QN406pV2FAD0HqE7vwlQOJRyvMF7odzp2UyCHgKlvC2npzRwgHW lN1UAAC0oSuMTznuvf7GLtKJQYb6D0iqbO21SsnNb8ayexqiePWbOiAVDL4nMkO8WxvBzvG3Il3 ZY7++mfQs0CfIqYLjbAlpKoOKzQHFOahqXCf2bt/iWZOW+GbwUUKoDmy5slP743Gh4bOoUHOGY9 AI+x/bPYtTB0e6zQPSMP65VvJHa9ztex+vE/idHvEu8PLPP/4zffA1aygfUbmMqQurdPtN1unKV aM3m7TIQIn1aaYAGn+MmiT4TyPbevgmClp4HwCLtMV+0FXjinUAVw== X-Received: by 2002:a05:600c:b95:b0:495:3b8a:bf11 with SMTP id 5b1f17b1804b1-49800ebb830mr23188915e9.26.1785401025320; Thu, 30 Jul 2026 01:43:45 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49764d6d0f8sm114474435e9.2.2026.07.30.01.43.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2026 01:43:45 -0700 (PDT) Message-ID: <66fc571d-4e6e-4d2e-973c-2de4789df432@suse.com> Date: Thu, 30 Jul 2026 10:43:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xen/blkback: Prevent missed completion when draining I/O To: Gui-Dong Han Cc: axboe@kernel.dk, linux-block@vger.kernel.org, konrad.wilk@oracle.com, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, roger@xenproject.org, xen-devel@lists.xenproject.org References: <20260730084000.3305702-1-hanguidong02@gmail.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260730084000.3305702-1-hanguidong02@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30.07.2026 10:40, Gui-Dong Han wrote: > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -1021,6 +1021,13 @@ static void xen_blk_drain_io(struct xen_blkif_ring *ring) > struct xen_blkif *blkif = ring->blkif; > > atomic_set(&blkif->drain, 1); > + /* > + * Publish drain before checking inflight. Otherwise, > + * xen_blkbk_unmap_and_respond_callback() can decrement inflight with > + * atomic_dec_and_test() and still see drain == 0 after this path saw > + * inflight > 0, missing the completion. > + */ > + smp_mb(); > do { > if (atomic_read(&ring->inflight) == 0) > break; Yet then don't we also need a barrier in xen_blkbk_unmap_and_respond_callback()'s check? Barriers almost always come in pairs, after all. Jan