From: "Zhou Yingchao" <yingchao.zhou@gmail.com>
To: torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Remove redundant up() in stop_machine(2.6.18-rc4)
Date: Wed, 23 Aug 2006 18:27:27 +0800 [thread overview]
Message-ID: <67029b170608230327n580f8469m37a9dce00f73ea2f@mail.gmail.com> (raw)
An up() is called in kernel/stop_machine.c on failure, and also in
the caller unconditionally. I have reported, but now it is still here.
Signed-off-by: Zhou Yingchao <yingchao.zhou@gmail.com>
___
--- kernel/stop_machine.c.orig 2006-08-23 14:53:36.000000000 +0800
+++ kernel/stop_machine.c 2006-08-23 14:53:55.000000000 +0800
@@ -111,7 +111,6 @@ static int stop_machine(void)
/* If some failed, kill them all. */
if (ret < 0) {
stopmachine_set_state(STOPMACHINE_EXIT);
- up(&stopmachine_mutex);
return ret;
}
next reply other threads:[~2006-08-23 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 10:27 Zhou Yingchao [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-23 10:45 Zhou Yingchao
2006-08-23 8:31 Zhou Yingchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67029b170608230327n580f8469m37a9dce00f73ea2f@mail.gmail.com \
--to=yingchao.zhou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®