mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Alvin Šipraga" <alsi@bang-olufsen.dk>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage
Date: Sun, 10 Mar 2024 19:02:52 +0100	[thread overview]
Message-ID: <6705a278-d294-475f-bc4c-b08926c5017d@lunn.ch> (raw)
In-Reply-To: <20240310-realtek-led-v1-1-4d9813ce938e@gmail.com>

On Sun, Mar 10, 2024 at 01:51:58AM -0300, Luiz Angelo Daros de Luca wrote:
> Each port can have up to 4 LEDs (3 for current rtl8365mb devices). The
> LED reg property will indicate its LED group.
> +                properties:
> +                  reg:
> +                    description:
> +                      "reg indicates the LED group for this LED"
> +                    enum: [0, 1, 2, 3]

If this identifies the group, what identifies the actual LED? There
are four of them. How do i say LEDs 0 and 1 are unused, 2 and 3 are
wired to LEDs?

It would be much more usual for reg to be the LED number for the
port. And there then be a group property indicating what group the LED
belongs to. However, i'm wondering, is group fixed? Do we actually
need it in DT, or can there just be a table in the driver which maps
port:led to group?

	 Andrew

  parent reply	other threads:[~2024-03-10 18:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-10  4:51 [PATCH net-next 0/4] net: dsa: realtek: fix LED support for rtl8366 Luiz Angelo Daros de Luca
2024-03-10  4:51 ` [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage Luiz Angelo Daros de Luca
2024-03-10  8:34   ` Krzysztof Kozlowski
2024-03-21 11:56     ` Luiz Angelo Daros de Luca
2024-03-21 12:18       ` Krzysztof Kozlowski
2024-03-24  2:10         ` Luiz Angelo Daros de Luca
2024-03-25  7:41           ` Krzysztof Kozlowski
2024-03-10 18:02   ` Andrew Lunn [this message]
2024-03-21 12:03     ` Luiz Angelo Daros de Luca
2024-03-10 18:31   ` Linus Walleij
2024-03-21 11:57     ` Luiz Angelo Daros de Luca
2024-03-10 18:52   ` Andrew Lunn
2024-03-21 11:58     ` Luiz Angelo Daros de Luca
2024-03-10 23:08   ` Rob Herring
2024-03-21 12:00     ` Luiz Angelo Daros de Luca
2024-03-10  4:51 ` [PATCH net-next 2/4] net: dsa: realtek: keep default LED state in rtl8366rb Luiz Angelo Daros de Luca
2024-03-10  8:01   ` Krzysztof Kozlowski
2024-03-10 11:37     ` Simon Horman
2024-03-10 11:47       ` Krzysztof Kozlowski
2024-03-11 16:11         ` Jakub Kicinski
2024-03-11 16:19           ` Krzysztof Kozlowski
2024-03-11 17:14             ` Jakub Kicinski
2024-03-11 18:40           ` Konstantin Ryabitsev
2024-03-11 18:52             ` Jakub Kicinski
2024-03-11 19:11               ` Konstantin Ryabitsev
2024-03-10  4:52 ` [PATCH net-next 3/4] net: dsa: realtek: do not assert reset on remove Luiz Angelo Daros de Luca
2024-03-10 18:33   ` Linus Walleij
2024-03-10  4:52 ` [PATCH net-next 4/4] net: dsa: realtek: add LED drivers for rtl8366rb Luiz Angelo Daros de Luca
2024-03-10  8:02   ` Krzysztof Kozlowski
2024-03-10 11:49   ` Simon Horman
2024-03-24  2:31     ` Luiz Angelo Daros de Luca
2024-03-10 18:47   ` Andrew Lunn
2024-03-24  3:46     ` Luiz Angelo Daros de Luca
2024-03-24 15:32       ` Andrew Lunn
2024-03-25  2:50         ` Luiz Angelo Daros de Luca
2024-03-25 12:38           ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6705a278-d294-475f-bc4c-b08926c5017d@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alsi@bang-olufsen.dk \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luizluca@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®