From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C2FC433ED for ; Wed, 7 Apr 2021 14:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8592C61260 for ; Wed, 7 Apr 2021 14:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352965AbhDGOdj (ORCPT ); Wed, 7 Apr 2021 10:33:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbhDGOdg (ORCPT ); Wed, 7 Apr 2021 10:33:36 -0400 Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB18CC061756 for ; Wed, 7 Apr 2021 07:33:25 -0700 (PDT) Received: by mail-oo1-xc33.google.com with SMTP id j10-20020a4ad18a0000b02901b677a0ba98so4599247oor.1 for ; Wed, 07 Apr 2021 07:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+xPsdblmGzem/7lcmqnJl9sL6OnLBtSMGGgOJbe8nUM=; b=I0xNFJ1ENsf5lwfbo5u9d4dnnXTLBmTO/oHDY2aT3VYgtrMNZEQYySZ2KK92oZQkkG iWAkPX1i7HHnG6NfTRXB+F6HZY05YVr7Jq2RNpGBLU/yq8MQyB7dtXuGSf8kdC21S0qG SrViWMP22KrKoQPd0haL3RBz19TN2rlujp3pQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+xPsdblmGzem/7lcmqnJl9sL6OnLBtSMGGgOJbe8nUM=; b=NHkt/DKpOwbBNxTj7pGjfyeomV1laRXBRgOAzAhoio4Q7C04EUUBGrxlqCq3pHhgSc LU0C/gXrs5HdEoctzgVA6Z8fWUDARBnaxdHhzBxZkxDUcKdUGzTCOlaziJmdDfWijFJ6 +EN6h547WCHCBFMNxtJ1kzaIsphixzVXXIVn0wP25h52Zix8bubC4fRodK3ppbot2wj1 cxxkK20aJXh0DzHrL6QRvuGr5t107T7b+6j3oElG5DVChoJlTqiPfm7TzTCcf1szbRT3 RHTpz6Dcf7dtori+n7PJpbAzFE8l26VCjiIpSyraexbn8YRiLT5JhpHyGmR0AjDITpac eSXQ== X-Gm-Message-State: AOAM530FrwI+fQWDJWPKINLmiP5ojAoXM3hkxRdb7CLHhK41u4JjIuSP gNFrhc+DP2Ke1tBD9dPiiEoC8Q== X-Google-Smtp-Source: ABdhPJxCy5mdQg6UXu6kWlLFCHoVnQbZ9mjgZJhQg9DXI1Wj9k6o+8n5FBSjX3S73s4RAizE9x2i/Q== X-Received: by 2002:a4a:4cd6:: with SMTP id a205mr3305504oob.4.1617806005313; Wed, 07 Apr 2021 07:33:25 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id h59sm5427570otb.29.2021.04.07.07.33.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Apr 2021 07:33:24 -0700 (PDT) Subject: Re: [PATCH] selftests/resctrl: Change a few printed messages To: Fenghua Yu , Shuah Khan , Ravi V Shankar Cc: linux-kselftest , linux-kernel , Shuah Khan References: <20210406005242.3248706-1-fenghua.yu@intel.com> From: Shuah Khan Message-ID: <67062f6c-d09a-f8e0-4d22-49c4452d0552@linuxfoundation.org> Date: Wed, 7 Apr 2021 08:33:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210406005242.3248706-1-fenghua.yu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/5/21 6:52 PM, Fenghua Yu wrote: > A few printed messages contain pass/fail strings which should be shown > in test results. Remove the pass/fail strings in the messages to avoid > confusion. > > Add "\n" at the end of one printed message. > > Suggested-by: Shuah Khan > Signed-off-by: Fenghua Yu > --- > This is a follow-up patch of recent resctrl selftest patches and can be > applied cleanly to: > git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git > branch next. > > tools/testing/selftests/resctrl/cache.c | 3 +-- > tools/testing/selftests/resctrl/mba_test.c | 9 +++------ > tools/testing/selftests/resctrl/mbm_test.c | 3 +-- > tools/testing/selftests/resctrl/resctrlfs.c | 7 ++----- > 4 files changed, 7 insertions(+), 15 deletions(-) > > diff --git a/tools/testing/selftests/resctrl/cache.c b/tools/testing/selftests/resctrl/cache.c > index 362e3a418caa..310bbc997c60 100644 > --- a/tools/testing/selftests/resctrl/cache.c > +++ b/tools/testing/selftests/resctrl/cache.c > @@ -301,8 +301,7 @@ int show_cache_info(unsigned long sum_llc_val, int no_of_bits, > ret = platform && abs((int)diff_percent) > max_diff_percent && > (cmt ? (abs(avg_diff) > max_diff) : true); > > - ksft_print_msg("%s cache miss rate within %d%%\n", > - ret ? "Fail:" : "Pass:", max_diff_percent); > + ksft_print_msg("Check cache miss rate within %d%%\n", max_diff_percent); You need %s and pass in the ret ? "Fail:" : "Pass:" result for the message to read correctly. I am seeing: # Check kernel support for resctrl filesystem It should say the following: # Fail Check kernel support for resctrl filesystem Same for other such messages. > > ksft_print_msg("Percent diff=%d\n", abs((int)diff_percent)); > ksft_print_msg("Number of bits: %d\n", no_of_bits); > diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c > index 26f12ad4c663..a909a745754f 100644 > --- a/tools/testing/selftests/resctrl/mba_test.c > +++ b/tools/testing/selftests/resctrl/mba_test.c > @@ -80,9 +80,7 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) > avg_diff = (float)labs(avg_bw_resc - avg_bw_imc) / avg_bw_imc; > avg_diff_per = (int)(avg_diff * 100); > > - ksft_print_msg("%s MBA: diff within %d%% for schemata %u\n", > - avg_diff_per > MAX_DIFF_PERCENT ? > - "Fail:" : "Pass:", > + ksft_print_msg("Check MBA diff within %d%% for schemata %u\n", > MAX_DIFF_PERCENT, > ALLOCATION_MAX - ALLOCATION_STEP * allocation); > > @@ -93,10 +91,9 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) > failed = true; > } > > - ksft_print_msg("%s schemata change using MBA\n", > - failed ? "Fail:" : "Pass:"); > + ksft_print_msg("Check schemata change using MBA\n"); > if (failed) > - ksft_print_msg("At least one test failed"); > + ksft_print_msg("At least one test failed\n"); > } > > static int check_results(void) > diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c > index 02b1ed03f1e5..e2e7ee4ec630 100644 > --- a/tools/testing/selftests/resctrl/mbm_test.c > +++ b/tools/testing/selftests/resctrl/mbm_test.c > @@ -37,8 +37,7 @@ show_bw_info(unsigned long *bw_imc, unsigned long *bw_resc, int span) > avg_diff_per = (int)(avg_diff * 100); > > ret = avg_diff_per > MAX_DIFF_PERCENT; > - ksft_print_msg("%s MBM: diff within %d%%\n", > - ret ? "Fail:" : "Pass:", MAX_DIFF_PERCENT); > + ksft_print_msg("Check MBM diff within %d%%\n", MAX_DIFF_PERCENT); Here > ksft_print_msg("avg_diff_per: %d%%\n", avg_diff_per); > ksft_print_msg("Span (MB): %d\n", span); > ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc); > diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c > index ade5f2b8b843..91cb3c48a7da 100644 > --- a/tools/testing/selftests/resctrl/resctrlfs.c > +++ b/tools/testing/selftests/resctrl/resctrlfs.c > @@ -570,15 +570,12 @@ bool check_resctrlfs_support(void) > > fclose(inf); > > - ksft_print_msg("%s kernel supports resctrl filesystem\n", > - ret ? "Pass:" : "Fail:"); > - > + ksft_print_msg("Check kernel support for resctrl filesystem\n"); Here > if (!ret) > return ret; > > dp = opendir(RESCTRL_PATH); > - ksft_print_msg("%s resctrl mountpoint \"%s\" exists\n", > - dp ? "Pass:" : "Fail:", RESCTRL_PATH); > + ksft_print_msg("Check resctrl mountpoint \"%s\"\n", RESCTRL_PATH); Here > if (dp) > closedir(dp); > > thanks, -- Shuah