From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AB8JxZqFM1XI2k6p1X14epNQoy1U6GkqKCdTt8PX/z3G0GfOSs6KtEnAS2l2zAktxKAKZw3k79QX ARC-Seal: i=1; a=rsa-sha256; t=1524861745; cv=none; d=google.com; s=arc-20160816; b=iucNY9joLudGViB/7c6aduKqVb2Gz2zfIWA8Cl97iq67QNhNEvZ1L/gxch+Um5sMLC +9cKFMOOnBUlcNCGb1Mw8sqDwpx8xU1OdN0iTaIA0EgG2F9IqoqXhhZ6Hcl8wshft10d sbnwyA8ucvgZHXoIlLYVKQZfx6OtDGqwKtwO3F9we6hvwpDWrjGo9nt+P3flECNLYasX vlmFG6YylSC2W+IOOdEXHhyRJoRRLLB3JT63S0WcZ25/r8HDlMQZKB5w5LCqHXnzDaSV yWGTboL6py0QMoHsjb2oB8SaJ6lOdPki7yNaPs8Xce2objqO2XC5syQNgbi9HBP8QhWb 3nsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=7sq+3jZp9H7jL/npIJ+75Ax/LhlscbeDuXXmDVOKmto=; b=txpZeP7VQW4gRUqeBzFiCUFHGmB/AqEWF+8E2YGNqCVbUz9DKtakqDPykjf9I3xPYm 2tYj4zced5rsX8pGrhPWsA/S2F2aCrzsaNh+AymzQcyGbhpgUMd6GhyrbbwinexmVzkh /zW/voZMmVc1ohTKn34sAqK6fAERo13v2m6HczL5hHyJg7u6IP8WbOlZ4FJIqocCZSeg SYYAHbLC6c8ygrM39k8Rme6MKWrNQtDIk6j8PWEH4b/lENwybZDJgncaA/bp4eqZG5oh kukz6XNMF+FIccExEjfHZtcCO77j50732VaQDvoKKUcyijlN+fgAZlcX0uFgSKosa6fo H8OQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kselftest-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kselftest-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758945AbeD0UmY (ORCPT ); Fri, 27 Apr 2018 16:42:24 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:53674 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758703AbeD0UmX (ORCPT ); Fri, 27 Apr 2018 16:42:23 -0400 Subject: Re: [PATCH 1/1] selftests: Fix lib.mk run_tests target shell script To: Mathieu Desnoyers , Shuah Khan Cc: linux-kernel , linux-kselftest , Shuah Khan References: <20171028134639.16811-1-mathieu.desnoyers@efficios.com> <44e3d6b0-6e0d-4482-fa7e-d8dac8619d4e@osg.samsung.com> <1490563551.1701.1509574972486.JavaMail.zimbra@efficios.com> <1717349402.1702.1509575073204.JavaMail.zimbra@efficios.com> <740429490.6175.1524860259330.JavaMail.zimbra@efficios.com> From: Shuah Khan Message-ID: <670cba49-7419-5506-de06-05267f0493e9@kernel.org> Date: Fri, 27 Apr 2018 14:42:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <740429490.6175.1524860259330.JavaMail.zimbra@efficios.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org X-Mailing-List: linux-kselftest@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1582509238172680386?= X-GMAIL-MSGID: =?utf-8?q?1598933429594793390?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 04/27/2018 02:17 PM, Mathieu Desnoyers wrote: > ----- On Nov 1, 2017, at 6:28 PM, Shuah Khan shuahkh@osg.samsung.com wrote: > >> On 11/01/2017 04:24 PM, Mathieu Desnoyers wrote: >>> ----- On Nov 1, 2017, at 6:22 PM, Mathieu Desnoyers >>> mathieu.desnoyers@efficios.com wrote: >>> >>>> ----- On Nov 1, 2017, at 5:33 PM, Shuah Khan shuahkh@osg.samsung.com wrote: >>>> >>>>> On 10/28/2017 07:46 AM, Mathieu Desnoyers wrote: >>>>>> Within run_tests target, the whole script needs to be executed within >>>>>> the same shell and not as separate subshells, so the initial test_num >>>>>> variable set to 0 is still present when executing "test_num=`echo >>>>>> $$test_num+1 | bc`;". >>>>>> >>>>>> Demonstration of the issue (make run_tests): >>>>>> >>>>>> TAP version 13 >>>>>> (standard_in) 1: syntax error >>>>>> selftests: basic_test >>>>>> ======================================== >>>>>> ok 1.. selftests: basic_test [PASS] >>>>>> (standard_in) 1: syntax error >>>>>> selftests: basic_percpu_ops_test >>>>>> ======================================== >>>>>> ok 1.. selftests: basic_percpu_ops_test [PASS] >>>>>> (standard_in) 1: syntax error >>>>>> selftests: param_test >>>>>> ======================================== >>>>>> ok 1.. selftests: param_test [PASS] >>>>> >>>>> Hi Mathieu, >>>>> >>>>> Odd. I don't see the error. I am curious if this specific to >>>>> env. Can you reproduce this with one of the existing tests, >>>>> kcmp or breakpoints >>>> >>>> Yes, it reproduces: >>>> >>>> cd tools/testing/selftests/kcmp >>>> make run_tests >>>> gcc -I../../../../usr/include/ kcmp_test.c -o >>>> /home/efficios/git/linux-rseq/tools/testing/selftests/kcmp/kcmp_test >>>> TAP version 13 >>>> (standard_in) 1: syntax error >>>> selftests: kcmp_test >>>> ======================================== >>>> ok 1.. selftests: kcmp_test [PASS] >>>> >>>> cd tools/testing/selftests/breakpoints >>>> make run_tests >>>> gcc step_after_suspend_test.c -o >>>> /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/step_after_suspend_test >>>> gcc breakpoint_test.c -o >>>> /home/efficios/git/linux-rseq/tools/testing/selftests/breakpoints/breakpoint_test >>>> TAP version 13 >>>> (standard_in) 1: syntax error >>>> selftests: step_after_suspend_test >>>> ======================================== >>>> not ok 1.. selftests: step_after_suspend_test [FAIL] >>>> (standard_in) 1: syntax error >>>> selftests: breakpoint_test >>>> ======================================== >>>> ok 1.. selftests: breakpoint_test [PASS] >>>> >>> >>> The version of "make" on that machine is: >>> >>> make --version >>> GNU Make 3.81 >>> Copyright (C) 2006 Free Software Foundation, Inc. >>> This is free software; see the source for copying conditions. >>> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A >>> PARTICULAR PURPOSE. >>> >>> This program built for x86_64-pc-linux-gnu >>> >>> (if it helps reproducing) >>> >> >> Yup that's it. I have >> >> GNU Make 4.1 >> Built for x86_64-pc-linux-gnu >> Copyright (C) 1988-2014 Free Software Foundation, Inc. >> License GPLv3+: GNU GPL version 3 or later >> This is free software: you are free to change and redistribute it. >> There is NO WARRANTY, to the extent permitted by law. >> >> I will test with your patch and see what happens in my env. > > Hi, > > I still see the problem with v4.17-rc2. Did you have time to > consider merging my fix ? > > Thanks, > > Mathieu Sorry for the delay. It slipped through. I will queue this for the next rc. Thanks for the ping. Hope it applies :) thanks, -- Shuah