mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Simon Ser <contact@emersion.fr>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Vishal Sagar <vishal.sagar@amd.com>,
	Anatoliy Klymenko <anatoliy.klymenko@amd.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Michal Simek <michal.simek@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Pekka Paalanen <ppaalanen@gmail.com>,
	Dmitry Baryshkov <lumag@kernel.org>
Subject: Re: [PATCH v8 02/11] drm/fourcc: Add DRM_FORMAT_XV15/XV20
Date: Fri, 20 Mar 2026 12:37:31 +0200	[thread overview]
Message-ID: <67120b18-8763-4b93-b89f-7f919f38e08e@ideasonboard.com> (raw)
In-Reply-To: <K_oXHqtPM_1bdhpMkkQMreIZ9OFfJVpHO3GV_wzmK_PvjQEw4Qz3IMBhGDNVQllkLg_GQeMGyOi6wpIFaRjrNkHubTwWQm-wqvKYTi6zEA0=@emersion.fr>

Hi Simon, Dave,

On 19/03/2026 17:15, Simon Ser wrote:
> What is the difference between DRM_FORMAT_XV15 and DRM_FORMAT_P030?

Good question. I thought the Cr & Cb are swapped between those formats.

The VC4 driver uses HVS_PIXEL_ORDER_XYCBCR define, and the comment in
drm_fourcc.h starts with "YCbCr420". So, CbCr. But then the comments
then continue with CrCb.

XV15/20 isn't super clear either, starting with "YCrCb" but then "Cb:Cr
plane".

The components in the plane descriptions look identical though, hinting
they are the same. So to be sure, I tested it:

I had test pattern support for XV15/20 in pykms, which I can test on a
Xilinx board. P030 is a bit more difficult, as on RPi5 it requires
DRM_FORMAT_MOD_BROADCOM_SAND128. But with a linear -> SAND128 converter,
I was able to test linear NV12 converted to NV12+SAND128 and shown on
the screen (just for reference), and similarly linear XV15 ->
P030+SAND128. And, indeed, the linear XV15 test pattern shows correctly
on screen when converted to SAND128. So afaics XV15 is indeed identical
to P030, and I can drop XV15.

This then brings up the question about XV20. That format doesn't exist
yet, but should it then be named similarly to P030? However, I have no
idea what P030 means, so I don't know what a 2x1 subsampled P030 would
be called...

Thoughts/ideas? Or just keep XV20?

 Tomi


  reply	other threads:[~2026-03-20 10:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 17:25 [PATCH v8 00/11] drm: Add new pixel formats for Xilinx Zynqmp Tomi Valkeinen
2026-01-28 17:25 ` [PATCH v8 01/11] drm/fourcc: Add warning for bad bpp Tomi Valkeinen
2026-01-28 17:25 ` [PATCH v8 02/11] drm/fourcc: Add DRM_FORMAT_XV15/XV20 Tomi Valkeinen
2026-03-19 15:15   ` Simon Ser
2026-03-20 10:37     ` Tomi Valkeinen [this message]
2026-03-26 14:48       ` Simon Ser
2026-01-28 17:25 ` [PATCH v8 03/11] drm/fourcc: Add DRM_FORMAT_Y8 Tomi Valkeinen
2026-01-28 18:10   ` Laurent Pinchart
2026-01-28 17:25 ` [PATCH v8 04/11] drm/fourcc: Add DRM_FORMAT_Y10_P32 Tomi Valkeinen
2026-03-19 14:59   ` Simon Ser
2026-03-20 10:48     ` Tomi Valkeinen
2026-03-26 13:55       ` Simon Ser
2026-01-28 17:25 ` [PATCH v8 05/11] drm/fourcc: Add DRM_FORMAT_X403 Tomi Valkeinen
2026-01-28 17:25 ` [PATCH v8 06/11] drm/fourcc: Add DRM_FORMAT_XVUY2101010 Tomi Valkeinen
2026-03-19 15:21   ` Simon Ser
2026-01-28 17:25 ` [PATCH v8 07/11] drm: xlnx: zynqmp: Use drm helpers when calculating buffer sizes Tomi Valkeinen
2026-01-28 17:25 ` [PATCH v8 08/11] drm: xlnx: zynqmp: Add support for XV15 & XV20 Tomi Valkeinen
2026-01-28 17:25 ` [PATCH v8 09/11] drm: xlnx: zynqmp: Add support for Y8 and Y10_P32 Tomi Valkeinen
2026-01-28 18:11   ` Laurent Pinchart
2026-01-28 17:25 ` [PATCH v8 10/11] drm: xlnx: zynqmp: Add support for X403 Tomi Valkeinen
2026-01-28 17:25 ` [PATCH v8 11/11] drm: xlnx: zynqmp: Add support for XVUY2101010 Tomi Valkeinen
2026-03-03 13:34 ` [PATCH v8 00/11] drm: Add new pixel formats for Xilinx Zynqmp Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67120b18-8763-4b93-b89f-7f919f38e08e@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=anatoliy.klymenko@amd.com \
    --cc=contact@emersion.fr \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michal.simek@amd.com \
    --cc=mripard@kernel.org \
    --cc=ppaalanen@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=vishal.sagar@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®